Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Ted Husted
On 9/17/07, James Holmes <[EMAIL PROTECTED]> wrote: > I fixed the problem on the 2.0.X branch. Not sure if that was the right place > to > do it, but it's done. Yep, that's right. We don't need any more branches :) > I created this issue when I worked on some tickets for the 2.0.10 release. At

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Piero Sartini
> Piero: it seems that we agreed on the fact that the change should add > a deprecation: can you open a JIRA issue for this? > Eventually you can provide the patch, so your name will appear in the > SVN log :-) I created a JIRA entry with attached patch: https://issues.apache.org/struts/browse/WW-

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread James Holmes
I fixed the problem on the 2.0.X branch. Not sure if that was the right place to do it, but it's done. I created this issue when I worked on some tickets for the 2.0.10 release. At the time I overlooked the fact that it was a protected method and I was changing the API. My bad. Everything should

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/17, Piero Sartini <[EMAIL PROTECTED]>: > Am Montag 17 September 2007 09:28:15 schrieb Antonio Petrelli: > > > Anyway, since 2.0.10 fixes a security issue: Would it be good to have a > > > method in Component.java that is compatible with 2.0.9? Maybe tagged > > > as @Deprecated? > > > > Good

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/17, Ted Husted <[EMAIL PROTECTED]>: > > Without looking at the code, it sounds like we might be able to add a > backwardly-compatible signature, and deprecate the former. If that can > be done, we could re-tag .10 and try again. Anyone up for the patch? I am -1 to retagging, since the JAR

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Ted Husted
On 9/17/07, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > I am -1 to retagging, since the JAR already went out to the public, and it > will be a mess for the support. As Wendy (Smoak) said, what happens when > someone asks support for 2.0.10? "Which 2.0.10 have you got?" It would be just as easy t

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Ted Husted
Without looking at the code, it sounds like we might be able to add a backwardly-compatible signature, and deprecate the former. If that can be done, we could re-tag .10 and try again. Anyone up for the patch? -Ted. On 9/16/07, Piero Sartini <[EMAIL PROTECTED]> wrote: > After looking at the code

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Piero Sartini
Am Montag 17 September 2007 09:28:15 schrieb Antonio Petrelli: > > Anyway, since 2.0.10 fixes a security issue: Would it be good to have a > > method in Component.java that is compatible with 2.0.9? Maybe tagged > > as @Deprecated? > > Good question: it depends on how the method is used: in the co

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/14, James Holmes <[EMAIL PROTECTED]>: > [X] Alpha +1 to Alpha with the following note: The "org.apache.struts2.components.Component.determineActionURL" protected method has changed, with no deprecation of the old signature. This problem was noted by Piero Sartini. Antonio P.S.: I don't kn

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/17, Piero Sartini <[EMAIL PROTECTED]>: > > After looking at the code the problem is within Component.java. > > The determineActionURL method has 2 new parameters which were not present > in > 2.0.9 and are passed to UrlHelper.java: > boolean forceAddSchemeHostAndPort, boolean escapeAmp It

Re: [VOTE] Struts 2.0.10 Quality

2007-09-16 Thread Piero Sartini
After looking at the code the problem is within Component.java. The determineActionURL method has 2 new parameters which were not present in 2.0.9 and are passed to UrlHelper.java: boolean forceAddSchemeHostAndPort, boolean escapeAmp It should be safe to call with forceAddSchemeHostAndPort=fals

Re: [VOTE] Struts 2.0.10 Quality

2007-09-16 Thread Piero Sartini
tabletags are broken with 2.0.10. org.apache.struts2.components.UIBean seems to be missing the UIBean.determineActionURL() method. Don't know if this is an issue. Are these components supposed to be stable in 2.0.x? Stacktrace: java.lang.NoSuchMethodError: com.googlecode.tabletags.components

Re: [VOTE] Struts 2.0.10 Quality

2007-09-16 Thread Philip Luppens
[X] General Availability (GA) Cheers, Phil On 9/14/07, James Holmes <[EMAIL PROTECTED]> wrote: > The Struts 2.0.10 test build is now available. > > Release notes: > > * http://struts.apache.org/2.x/docs/release-notes-2010.html > > Distribution: > > * http://people.apache.org/builds/strut

Re: [VOTE] Struts 2.0.10 Quality

2007-09-16 Thread Pedro Herrera
>> not only >> states an opinion, but means that the voter is agreeing to help do the >> work. >> >> - >> To unsubscribe, e-mail: [EMAIL PROTECTED] >> For additional commands, e-mail: [EMAI

Re: [VOTE] Struts 2.0.10 Quality

2007-09-16 Thread mraible
nion, but means that the voter is agreeing to help do the > work. > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --

Re: [VOTE] Struts 2.0.10 Quality

2007-09-15 Thread Pedro Herrera
eing to help do the > work. > > - > To unsubscribe, e-mail: [EMAIL PROTECTED] > For additional commands, e-mail: [EMAIL PROTECTED] > > > --

Re: [VOTE] Struts 2.0.10 Quality

2007-09-14 Thread Antonio Petrelli
2007/9/14, Ted Husted <[EMAIL PROTECTED]>: > ( one chmod o+r * later) > > OK, try it now. Ok thank you Ted! - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: [VOTE] Struts 2.0.10 Quality

2007-09-14 Thread Ted Husted
( one chmod o+r * later) OK, try it now. On 9/14/07, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > I cannot download the distribution: > http://people.apache.org/builds/struts/2.0.10/struts-2.0.10-all.zip > It gives me a 403 :-O ---

Re: [VOTE] Struts 2.0.10 Quality

2007-09-14 Thread Antonio Petrelli
2007/9/14, James Holmes <[EMAIL PROTECTED]>: > Distribution: > > * http://people.apache.org/builds/struts/2.0.10/ I cannot download the distribution: http://people.apache.org/builds/struts/2.0.10/struts-2.0.10-all.zip It gives me a 403 :-O Antonio

[VOTE] Struts 2.0.10 Quality

2007-09-14 Thread James Holmes
The Struts 2.0.10 test build is now available. Release notes: * http://struts.apache.org/2.x/docs/release-notes-2010.html Distribution: * http://people.apache.org/builds/struts/2.0.10/ Maven 2 staging repository: * http://people.apache.org/builds/struts/2.0.10/m2-staging-repositor