Re: file upload name filtering

2025-02-17 Thread Lukasz Lenart
> >> uses the > > > > > > >> file name, unsanitized, and potentially other malicious type > > > > > > >> injection via > > > > > > >> specially crafted file names. > > > > > > >>

Re: file upload name filtering

2025-02-15 Thread Lukasz Lenart
> > > > > >>> On Wed, Feb 12, 2025, 10:05 AM Burton > > > > > >>> Rhodes wrote: > > > > > >>> > > > > > >>> I agree with Greg. > > > > > >>> > > > > > >>> IMHO, characte

Re: file upload name filtering

2025-02-15 Thread Lukasz Lenart
th Greg. > > > > >>> > > > > >>> IMHO, character validation should be left to the developer which > > > > >>> depends > > > > >>> on their OS and file names supported therein. But if there needs to > > > > &g

Re: file upload name filtering

2025-02-14 Thread Kusal Kithul-Godage
n their OS and file names supported therein. But if there needs to be > > > >>> protection against a buffer overflow attack (I assume that is the > > > >>> problem you are trying to solve?), then the length restriction should > > > >>> suffice. Or is there

Re: file upload name filtering

2025-02-13 Thread Lukasz Lenart
a buffer overflow attack (I assume that is the > > >>> problem you are trying to solve?), then the length restriction should > > >>> suffice. Or is there another risk I'm not aware of that could threaten > > >>> a system by just having a few malicio

Re: file upload name filtering

2025-02-13 Thread Lukasz Lenart
> >>> a system by just having a few malicious characters in a file name? > >>> > >>> > >>> Thanks, > >>> Burton > >>> > >>> > >>> -- Original Message -- > >>> From "Greg Huber&q

Re: file upload name filtering

2025-02-13 Thread Greg Huber
ving a few malicious characters in a file name? Thanks, Burton -- Original Message -- From "Greg Huber" to...@struts.apache.org Date 2/11/2025 2:51:36 AM Subject Re: file upload name filtering Filename length is a possible good way to go, with an override of the length and th

Re: file upload name filtering

2025-02-12 Thread Burton Rhodes
>> >> Thanks, >> Burton >> >> >> -- Original Message -- >> From "Greg Huber" >> To dev@struts.apache.org >> Date 2/11/2025 2:51:36 AM >> Subject Re: file upload name filtering >> >>> Filename length is

Re: file upload name filtering

2025-02-12 Thread Brian Andle
ther risk I'm not aware of that could threaten > a system by just having a few malicious characters in a file name? > > > Thanks, > Burton > > > -- Original Message -- > From "Greg Huber" > To dev@struts.apache.org > Date 2/11/2025 2:51:36 AM &

Re: file upload name filtering

2025-02-12 Thread Burton Rhodes
should suffice. Or is there another risk I'm not aware of that could threaten a system by just having a few malicious characters in a file name? Thanks, Burton -- Original Message -- From "Greg Huber" To dev@struts.apache.org Date 2/11/2025 2:51:36 AM Subject Re: f

Re: file upload name filtering

2025-02-11 Thread Greg Huber
Filename length is a possible good way to go, with an override of the length and then truncate or block option. On 11/02/2025 06:21, Lukasz Lenart wrote: Hm... looks like I must re-think this approach, thanks all for reporting this issue!

Re: file upload name filtering

2025-02-10 Thread Lukasz Lenart
; -- Original Message -- > From "Lukasz Lenart" > To "Struts Developers List" > Date 2/9/2025 11:50:30 AM > Subject Re: file upload name filtering > > >Could you create a JIRA ticket to address this? > > > >niedz., 9 lut 2025 o 10:51

Re: file upload name filtering

2025-02-10 Thread Burton Rhodes
ng EXCLUDED_FILE_PATTERN = "^(.*[<>&\"'|;/?*:]+.*|.*\\.\\..*)$"; Thanks, Burton -- Original Message -- From "Lukasz Lenart" To "Struts Developers List" Date 2/9/2025 11:50:30 AM Subject Re: file upload name filtering Could you create a JIRA

Re: file upload name filtering

2025-02-09 Thread Lukasz Lenart
Could you create a JIRA ticket to address this? niedz., 9 lut 2025 o 10:51 Greg Huber napisał(a): > > ..v6 to escape and warn would be good, and should reduce downstream > complaints as they might not notice it😉. > > arthu€r.jpg > > long filenames to try and find the offending char > > af517d82-8

Re: file upload name filtering

2025-02-09 Thread Greg Huber
..v6 to escape and warn would be good, and should reduce downstream complaints as they might not notice it😉. arthu€r.jpg long filenames to try and find the offending char af517d82-8583-11eb-a3d0-06b4694bee2a_2Fmedia-manager_2F1738545771934-House_20&_20Home_20-_20HI-RES.png On 09/02/2025 09:27

Re: file upload name filtering

2025-02-09 Thread Lukasz Lenart
niedz., 9 lut 2025 o 10:20 Greg Huber napisał(a): > > Still using v6 at the moment, but I think v7 (dev box) is the same? The same in functionality, but harder to refactor some things. I made a few changes in the logic used in v7 and it's hard to port them back into v6. Anyway, I will take a look

Re: file upload name filtering

2025-02-09 Thread Greg Huber
Still using v6 at the moment, but I think v7 (dev box) is the same? On 09/02/2025 09:14, Lukasz Lenart wrote: niedz., 9 lut 2025 o 10:10 Greg Huber napisał(a): I have now had a few uploads blocked mainly due to sentence punctuation in the image name ie apostrophe and ampersand symbols. It woul

Re: file upload name filtering

2025-02-09 Thread Lukasz Lenart
niedz., 9 lut 2025 o 10:10 Greg Huber napisał(a): > > I have now had a few uploads blocked mainly due to sentence punctuation > in the image name ie apostrophe and ampersand symbols. > > It would be better here to just escape the string and warn rather than > just block it, requiring the user to r

Re: file upload name filtering

2025-02-09 Thread Greg Huber
I have now had a few uploads blocked mainly due to sentence punctuation in the image name ie apostrophe and ampersand symbols. It would be better here to just escape the string and warn rather than just block it, requiring the user to remove the characters is a waste of time as this can easily

Re: file upload name filtering

2025-02-09 Thread Lukasz Lenart
This is rather a hardening to avoid potential feature security vulnerabilities. In ParametersInterceptor we do not allow some certain names of the parameters and the same should be used for uploading and any other "user input". Maybe it would be good to create one the same mechanism which can be s

file upload name filtering

2025-02-07 Thread Greg Huber
What is this actually escaping?  Stuff that can mess with the system? Not had any uploads bounce so far. On 05/02/2025 04:20, Kusal Kithul-Godage wrote: I've just tested this with the Confluence Data Center application. The file name filtering is actually causing a user experience regression f

[GitHub] [struts-site] lukaszlenart merged pull request #191: WW-5266 Update file upload docs

2023-03-21 Thread via GitHub
lukaszlenart merged PR #191: URL: https://github.com/apache/struts-site/pull/191 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@struts.

[GitHub] [struts-site] kusalk opened a new pull request, #191: WW-5266 Update file upload docs

2023-03-21 Thread via GitHub
kusalk opened a new pull request, #191: URL: https://github.com/apache/struts-site/pull/191 WW-5266 -- -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-

[GitHub] [struts-site] lukaszlenart merged pull request #188: [WW-5285] Cleans up file upload dependencies

2023-03-09 Thread via GitHub
lukaszlenart merged PR #188: URL: https://github.com/apache/struts-site/pull/188 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@struts.

[GitHub] [struts-site] lukaszlenart opened a new pull request, #188: [WW-5285] Cleans up file upload dependencies

2023-03-08 Thread via GitHub
lukaszlenart opened a new pull request, #188: URL: https://github.com/apache/struts-site/pull/188 Refs [WW-5285](https://issues.apache.org/jira/browse/WW-5285) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL ab

[GitHub] [struts] lukaszlenart closed pull request #650: [WW-5273] Supports file upload using Servlet API 3.1

2023-02-27 Thread via GitHub
lukaszlenart closed pull request #650: [WW-5273] Supports file upload using Servlet API 3.1 URL: https://github.com/apache/struts/pull/650 -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the

[GitHub] [struts] lukaszlenart opened a new pull request, #650: [WW-5273] Supports file upload using Servlet API 3.1

2022-12-29 Thread GitBox
lukaszlenart opened a new pull request, #650: URL: https://github.com/apache/struts/pull/650 Also documents update is needed Closes [WW-5273](https://issues.apache.org/jira/browse/WW-5273) -- This is an automated message from the Apache Git Service. To respond to the message, please log

[GitHub] [struts] lukaszlenart merged pull request #441: WW-5088: Integration test for empty file upload.

2020-10-14 Thread GitBox
lukaszlenart merged pull request #441: URL: https://github.com/apache/struts/pull/441 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [struts] pys-arhs opened a new pull request #441: WW-5088: Integration test for empty file upload.

2020-10-14 Thread GitBox
pys-arhs opened a new pull request #441: URL: https://github.com/apache/struts/pull/441 Add integration test to detect regressions if commons-fileupload behavior changes in the future. DiskFileItemFactory#setSizeThreshold should be set to -1 because org.apache.commons.io.output.Thre

[GitHub] [struts] lukaszlenart merged pull request #440: WW-5088: Fix empty file upload with commons-fileupload:1.4.

2020-10-13 Thread GitBox
lukaszlenart merged pull request #440: URL: https://github.com/apache/struts/pull/440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [struts] pys-arhs opened a new pull request #440: WW-5088: Fix empty file upload with commons-fileupload:1.4.

2020-10-13 Thread GitBox
pys-arhs opened a new pull request #440: URL: https://github.com/apache/struts/pull/440 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go

[GitHub] [struts] lukaszlenart merged pull request #437: Empty file upload, storeLocation null gives wrong error message.

2020-09-09 Thread GitBox
lukaszlenart merged pull request #437: URL: https://github.com/apache/struts/pull/437 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [struts] gregh3269 opened a new pull request #437: Empty file upload, storeLocation null gives wrong error message.

2020-09-09 Thread GitBox
gregh3269 opened a new pull request #437: URL: https://github.com/apache/struts/pull/437 See WW-5088 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL

[GitHub] [struts] lukaszlenart merged pull request #435: [WW-5088] Empty file upload, storeLocation null gives wrong error message.

2020-09-07 Thread GitBox
lukaszlenart merged pull request #435: URL: https://github.com/apache/struts/pull/435 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

[GitHub] [struts] gregh3269 opened a new pull request #435: Empty file upload, storeLocation null gives wrong error message.

2020-09-04 Thread GitBox
gregh3269 opened a new pull request #435: URL: https://github.com/apache/struts/pull/435 On an empty file upload the storeLocation is null, so adds a file new StrutsUploadedFile(null) List fileList = new ArrayList<>(items.size()); for (FileItem fileItem : items) {

Re: File Upload of File CSV doesn't work

2020-07-27 Thread Lukasz Lenart
pon., 27 lip 2020 o 13:03 beppe coniglio napisał(a): > > Hi, > I create a new Project following guide lines in > https://cwiki.apache.org/confluence/display/WW/File+Upload but when I try to > upload csv file I obtain "Content-Type not allowed: > application/vnd.ms-e

File Upload of File CSV doesn't work

2020-07-27 Thread beppe coniglio
Hi, I create a new Project following guide lines in https://cwiki.apache.org/confluence/display/WW/File+Upload but when I try to upload csv file I obtain "Content-Type not allowed: application/vnd.ms-excel" I download also a project by https://www.journaldev.com/2192/struts-2-f

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Lukasz Lenart
; >> >> obj = Array.get(value, 0); >> >> >> } else { >> >> >> obj = value; >> >> >> } >> >> >> if (obj instanceof UploadedFile) { >> >>

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Greg Huber
> } > >> >> if (obj instanceof UploadedFile) { > >> >> UploadedFile file = (UploadedFile) obj; > >> >> if (file.getContent() instanceof File) { > >> >>

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Lukasz Lenart
obj; >> >> if (file.getContent() instanceof File) { >> >> return file.getContent(); >> >> } >> >> return new File(file.getAbsolutePath()); >> >> } >> >

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Greg Huber
gt; if (file.getContent() instanceof File) { > >> return file.getContent(); > >> } > >> return new File(file.getAbsolutePath()); > >> } > >> > >> This works for both my aja

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Lukasz Lenart
getContent(); >>> } >>> return new File(file.getAbsolutePath()); >>> } >>> >>> This works for both my ajax and normal upload. >>> >>> On 23 November 2016 at 12:56, Lukasz Lenart wrote: >&g

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Lukasz Lenart
file.getAbsolutePath()); >> } >> >> This works for both my ajax and normal upload. >> >> On 23 November 2016 at 12:56, Lukasz Lenart wrote: >> >>> Could someone tag that PR with :+1:? >>> >>> 2016-11-22 20:41 GMT+01:00 Luka

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Lukasz Lenart
t; This works for both my ajax and normal upload. > > On 23 November 2016 at 12:56, Lukasz Lenart wrote: > >> Could someone tag that PR with :+1:? >> >> 2016-11-22 20:41 GMT+01:00 Lukasz Lenart : >> > All is good :) I have refactored the file upload logic a bit, cl

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Greg Huber
> 2016-11-22 20:41 GMT+01:00 Lukasz Lenart : > > All is good :) I have refactored the file upload logic a bit, cleaned > > up and fixed some issues with wrong message keys. Also I added > > dedicated converter to keep support for java.io.File so there is no > > need for mig

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-24 Thread Greg Huber
java.lang.NullPointerException: null On 23 November 2016 at 12:56, Lukasz Lenart wrote: > Could someone tag that PR with :+1:? > > 2016-11-22 20:41 GMT+01:00 Lukasz Lenart : > > All is good :) I have refactored the file upload logic a bit, cleaned > > up and fixed some issues with wrong messa

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Lukasz Lenart
The missing classes are here https://github.com/apache/struts/pull/114 - for now ignore the plugin, first the change must go in 2016-11-23 15:08 GMT+01:00 Greg Huber : > I don't use git, so i have no idea what your are saying PR wise. > > From the source: > > import org.apache.struts2.dispatcher.m

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Greg Huber
I don't use git, so i have no idea what your are saying PR wise. >From the source: import org.apache.struts2.dispatcher.multipart.AbstractMultiPartRequest public class GaeMultiPartRequest extends AbstractMultiPartRequest ## so i need the class org.apache.struts2.dispatcher.multipart.AbstractMu

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Lukasz Lenart
Yes, first the PR must be merged than the plugin can be used :) I have done that locally and everything is fine. The most important things is that the PR doesn't break backward compatibility :) 2016-11-23 14:52 GMT+01:00 Greg Huber : > I have downloaded the plugin to get the source to copy to my s

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Greg Huber
I have downloaded the plugin to get the source to copy to my server and these are the ones that are missing, and it won't compile.? On 23 November 2016 at 13:48, Lukasz Lenart wrote: > 2016-11-23 14:32 GMT+01:00 Greg Huber : > > where do all these come from? > > > > import org.apache.struts2.dis

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Lukasz Lenart
2016-11-23 14:32 GMT+01:00 Greg Huber : > where do all these come from? > > import org.apache.struts2.dispatcher.multipart.UploadedFile; > import org.apache.struts2.dispatcher.multipart.AbstractMultiPartRequest; These are new things added in that PR, where that abstract class is just a helper to r

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Greg Huber
uld someone tag that PR with :+1:? > > 2016-11-22 20:41 GMT+01:00 Lukasz Lenart : > > All is good :) I have refactored the file upload logic a bit, cleaned > > up and fixed some issues with wrong message keys. Also I added > > dedicated converter to keep support for java.io.File

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-23 Thread Lukasz Lenart
Could someone tag that PR with :+1:? 2016-11-22 20:41 GMT+01:00 Lukasz Lenart : > All is good :) I have refactored the file upload logic a bit, cleaned > up and fixed some issues with wrong message keys. Also I added > dedicated converter to keep support for java.io.File so there is no &

[GitHub] struts pull request #97: WW-4636 File upload error message always in default...

2016-11-22 Thread victorsosa
Github user victorsosa closed the pull request at: https://github.com/apache/struts/pull/97 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is e

[GitHub] struts issue #97: WW-4636 File upload error message always in default langua...

2016-11-22 Thread victorsosa
Github user victorsosa commented on the issue: https://github.com/apache/struts/pull/97 done --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feat

[GitHub] struts issue #97: WW-4636 File upload error message always in default langua...

2016-11-22 Thread aleksandr-m
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/97 @victorsosa, @lukaszlenart Please close this one. WW-4636 is fixed in https://github.com/apache/struts/pull/113. --- If your project is set up for it, you can reply to this email and have your re

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-22 Thread Lukasz Lenart
All is good :) I have refactored the file upload logic a bit, cleaned up and fixed some issues with wrong message keys. Also I added dedicated converter to keep support for java.io.File so there is no need for migration :) I've also developed a small GAE plugin which is using the ment

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-22 Thread Lukasz Lenart
Done, thanks Aaron :) Now I must test this solution with Google AppEngine ;-) 2016-11-22 7:49 GMT+01:00 Lukasz Lenart : > 2016-11-21 20:12 GMT+01:00 Aaron Johnson : >> Is it possible to have a converter from UploadedFile to File? The >> UploadedFile has a getContent() method that returns the File

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-21 Thread Lukasz Lenart
2016-11-21 20:12 GMT+01:00 Aaron Johnson : > Is it possible to have a converter from UploadedFile to File? The > UploadedFile has a getContent() method that returns the File object. Hm... it would be possible to add a converter, that should work :) Regards -- Łukasz + 48 606 323 122 http://www.

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-21 Thread Aaron Johnson
provide a config > switch and deprecation warning. > > > > Regards, > Christoph > > > > > From: Lukasz Lenart > > To: Struts Developers List , > > Date: 21.11.2016 10:58 > > Subject: Re: [jira] [Updated] (WW-4717) Refactor file upload suppor

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-21 Thread Christoph Nenning
Surly there will be users complaining. We should at least provide a config switch and deprecation warning. Regards, Christoph > From: Lukasz Lenart > To: Struts Developers List , > Date: 21.11.2016 10:58 > Subject: Re: [jira] [Updated] (WW-4717) Refactor file upload suppor

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-21 Thread Lukasz Lenart
PR is here https://github.com/apache/struts/pull/114 2016-11-21 10:58 GMT+01:00 Lukasz Lenart : > I would like to refactor file upload logic to use a virtual > representation of a file but this requires changes in users' > applications as well, instead of using java.io.File the

Re: [jira] [Updated] (WW-4717) Refactor file upload support to allow create virtual representation of java.io.File

2016-11-21 Thread Lukasz Lenart
I would like to refactor file upload logic to use a virtual representation of a file but this requires changes in users' applications as well, instead of using java.io.File they will have to switch to UploadedFile Struts class. Not sure if it is worth doing :\ Regards -- Łukasz + 48 60

[GitHub] struts pull request #113: WW-4636 - File upload error message always in defa...

2016-11-07 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/113 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts issue #113: WW-4636 - File upload error message always in default lan...

2016-10-17 Thread aleksandr-m
Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/113 Yep, we can close #97. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishe

[GitHub] struts issue #113: WW-4636 - File upload error message always in default lan...

2016-10-17 Thread cnenning
Github user cnenning commented on the issue: https://github.com/apache/struts/pull/113 :+1: That means #97 can be closed? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this featur

[GitHub] struts issue #113: WW-4636 - File upload error message always in default lan...

2016-10-16 Thread lukaszlenart
Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/113 Looks good to me, if no objections I'm going to merge it. Thanks, great work! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts pull request #113: WW-4636 - File upload error message always in defa...

2016-10-15 Thread aleksandr-m
GitHub user aleksandr-m opened a pull request: https://github.com/apache/struts/pull/113 WW-4636 - File upload error message always in default language Please review. You can merge this pull request into a Git repository by running: $ git pull https://github.com/aleksandr-m

[GitHub] struts pull request: WW-4636 File upload error message always in d...

2016-05-25 Thread victorsosa
Github user victorsosa commented on the pull request: https://github.com/apache/struts/pull/97#issuecomment-221640016 @aleksandr-m It is set to English in here: https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequ

[GitHub] struts pull request: WW-4636 File upload error message always in d...

2016-05-25 Thread aleksandr-m
Github user aleksandr-m commented on the pull request: https://github.com/apache/struts/pull/97#issuecomment-221628543 First of all, there is [some chance](https://github.com/apache/struts/blob/master/core/src/main/java/org/apache/struts2/dispatcher/multipart/JakartaMultiPartRequest.ja

[GitHub] struts pull request: WW-4636 File upload error message always in d...

2016-05-25 Thread victorsosa
GitHub user victorsosa opened a pull request: https://github.com/apache/struts/pull/97 WW-4636 File upload error message always in default language File upload error message always in default English language. Content negotiation is a mechanism defined in the HTTP

[GitHub] struts pull request: WW-4456 Got NPE when File Upload Limitation e...

2016-01-20 Thread asfgit
Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/80 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabl

[GitHub] struts pull request: WW-4456 Got NPE when File Upload Limitation e...

2016-01-19 Thread victorsosa
GitHub user victorsosa opened a pull request: https://github.com/apache/struts/pull/80 WW-4456 Got NPE when File Upload Limitation exceeds in portal env HI Lukasz, This is a proposal to fix WW-4456 - Got NPE when File Upload Limitation exceeds in portal env

Re: [jira] [Created] (WW-4456) Got NPE when File Upload Limitation exceeds in portal env.

2015-02-03 Thread Lukasz Lenart
Zhou Shern (JIRA) : > Zhou Shern created WW-4456: > -- > > Summary: Got NPE when File Upload Limitation exceeds in portal > env. > Key: WW-4456 > URL: https://issues.apache.org/jira/browse/WW-4456 &

Re: File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Dave Newton
Woohoo, I get it now... I saw the PrepareOperations before but digging w/o an IDE is a pain. Sweet--thanks again. Dave On Thu, Jun 21, 2012 at 4:11 PM, Łukasz Lenart wrote: > 2012/6/21 Dave Newton : > > Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll > track > > it down

Re: File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Łukasz Lenart
2012/6/21 Dave Newton : > Ah, okay--cool :) I don't see it in the ng filter dispatcher, but I'll track > it down later when I have a chance. Is there an elevator pitch for how the > ng filter ends up calling it? Take a look on the finally section of doFilter(), there is a call to Prepare.cleanupRe

Re: File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Dave Newton
On Thu, Jun 21, 2012 at 3:51 PM, Łukasz Lenart wrote: > I've changed a bit the whole cleanup idea, right now it's delegated to > given implementation of MultiPartRequest, to the method cleanUp(). > So a filter calls Dispatcher.cleanUpRequest(request) which delegate to > MultiPartRequest.cleanUp()

Re: File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Łukasz Lenart
Hi Dave, I've changed a bit the whole cleanup idea, right now it's delegated to given implementation of MultiPartRequest, to the method cleanUp(). So a filter calls Dispatcher.cleanUpRequest(request) which delegate to MultiPartRequest.cleanUp() It works with old and with the new filters. Regard

Re: File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Martin Cooper
On Thu, Jun 21, 2012 at 12:05 PM, Dave Newton wrote: > Anyone? I am just guessing, but perhaps this? http://y.ahoo.it/Qzl2h -- Martin Cooper > So far it appears as though the patch only fixed the old filter and not > those of the ng variety? > > Also, I'm wondering if we'd like to un-"ng" thi

Re: File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Dave Newton
Anyone? So far it appears as though the patch only fixed the old filter and not those of the ng variety? Also, I'm wondering if we'd like to un-"ng" this, or barring that, at least re-package to something named better and put a subclass in ng and deprecate. Dave On Thu, Jun 21, 2012 at 6:14 AM

File upload interceptor/filter dispatcher temp file cleanup

2012-06-21 Thread Dave Newton
Where are uploaded files currently cleaned up? The patch for WW-3490 [1] moved temp file deletion out of the interceptor into the dispatcher, but if the ng dispatcher is being used, when/how are the files deleted? I've dug a little bit and haven't seen it yet; at this point it's quicker to ask. T

Re: Struts2: file upload not working - Help plzzzzzz

2009-04-09 Thread Musachy Barroso
Try putting a breakpoint in the FileUploadInterceptor and see what is going on. musachy On Thu, Apr 9, 2009 at 9:37 AM, TRSP wrote: > > I'm trying to do upload a file using struts2 file tag. Followed all the > mentioned as given in > http://struts.apache.org/2.0.11

Struts2: file upload not working - Help plzzzzzz

2009-04-09 Thread TRSP
I'm trying to do upload a file using struts2 file tag. Followed all the mentioned as given in http://struts.apache.org/2.0.11/docs/file-upload-interceptor.html. but still am not able to retreive the file contents in my action class. Below is the code snippet which i

Re: [s2] upgrade commons file upload dependency

2007-07-25 Thread Paul Benedict
Nope. It was done for 1.4 and supposedly there is a 1.2.1 version coming out soon, but that shouldn't hold you up in the mean time. Paul James Holmes wrote: Anyone opposed to upgrading the Commons FileUpload dependency on the trunk to FileUpload 1.2? James --

[s2] upgrade commons file upload dependency

2007-07-24 Thread James Holmes
Anyone opposed to upgrading the Commons FileUpload dependency on the trunk to FileUpload 1.2? James - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Null pointer exception in action class - file upload form file problem URGENT!!! HELP

2007-06-26 Thread Laurie Harper
Please post questions about using Struts to the Struts Users list only. The Struts Dev list is for discussing the development and enhancement of Struts itself. http://struts.apache.org/mail.html vbharath19 wrote: Hi, I have a jsp from which i upload a file. this field is of Formfile type. j

Null pointer exception in action class - file upload form file problem URGENT!!! HELP

2007-06-26 Thread vbharath19
(ActionServlet.java:119 6) at org.apache.struts.action.ActionServlet.doPost(ActionServlet.java:432) -- View this message in context: http://www.nabble.com/Null-pointer-exception-in-action-class---file-upload-form-file-problem-URGENT%21%21%21-HELP-tf3983269.html#a11308643 Sent from the Struts

Re: upload fail occasionally [also Re: File upload fails first time, then works after page reload]

2007-04-11 Thread Eric Rank
foundational point in the framework, but what would happen if the request hits the wrapping part of the code outside when the Dispatcher instance is not null? My file upload problems are fixed, but what other problems would this cause? === Existing code for FilterDispatcher ==

Re: file upload issue

2007-01-05 Thread liukaipeng
encounter this issue either. liukaipeng 2007-01-06 发件人: cujsh 发送时间: 2007-01-05 02:53:07 收件人: dev@struts.apache.org 抄送: 主题: file upload issue All multipart request parameters coming back null on file upload inconsistantly. Using struts2.0.1, tiles plugin 2.01. No exceptions thrown. One

file upload issue

2007-01-04 Thread cujsh
All multipart request parameters coming back null on file upload inconsistantly. Using struts2.0.1, tiles plugin 2.01. No exceptions thrown. One file upload works perfectly and the next attempt may or may not fail. - Posted via

[jira] Closed: (STR-290) file upload problem: MultipartIterator: invalid multipart request data, doesn't start with boundary

2006-04-25 Thread Don Brown (JIRA)
[ http://issues.apache.org/struts/browse/STR-290?page=all ] Don Brown closed STR-290: - Resolution: Fixed > file upload problem: MultipartIterator: invalid multipart request data, > doesn't start wi

[jira] Reopened: (STR-290) file upload problem: MultipartIterator: invalid multipart request data, doesn't start with boundary

2006-04-25 Thread Don Brown (JIRA)
[ http://issues.apache.org/struts/browse/STR-290?page=all ] Don Brown reopened STR-290: --- Assign To: (was: Struts Developer Mailing List) > file upload problem: MultipartIterator: invalid multipart request data, > doesn't start wi

[jira] Closed: (STR-289) File Upload doesn't work with Opera

2006-04-25 Thread Don Brown (JIRA)
[ http://issues.apache.org/struts/browse/STR-289?page=all ] Don Brown closed STR-289: - Resolution: Fixed > File Upload doesn't work with Opera > --- > > Key: STR-289 > URL: http://issu

[jira] Reopened: (STR-289) File Upload doesn't work with Opera

2006-04-25 Thread Don Brown (JIRA)
[ http://issues.apache.org/struts/browse/STR-289?page=all ] Don Brown reopened STR-289: --- Assign To: (was: Mike Schachter) > File Upload doesn't work with Opera > --- > > Key: STR-289 >

[jira] Closed: (STR-328) File Upload mangles files

2006-04-25 Thread Don Brown (JIRA)
[ http://issues.apache.org/struts/browse/STR-328?page=all ] Don Brown closed STR-328: - Resolution: Fixed > File Upload mangles files > - > > Key: STR-328 > URL: http://issues.apache.org/struts

[jira] Reopened: (STR-328) File Upload mangles files

2006-04-25 Thread Don Brown (JIRA)
[ http://issues.apache.org/struts/browse/STR-328?page=all ] Don Brown reopened STR-328: --- Assign To: (was: Mike Schachter) > File Upload mangles files > - > > Key: STR-328 > URL: http://is

svn commit: r393642 - in /incubator/webwork2: thirdparty/ thirdparty/jasperreports/ thirdparty/jfreechart/ thirdparty/pell-file-upload/ uber/

2006-04-12 Thread plightbo
nged) incubator/webwork2/thirdparty/jfreechart/ (props changed) incubator/webwork2/thirdparty/pell-file-upload/ (props changed) incubator/webwork2/uber/ (props changed) Propchange: incubator/webwork2/thirdp

DO NOT REPLY [Bug 36687] - Struts not populating form values when maxFileSize exceeded during file upload

2006-03-16 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 36687] - Struts not populating form values when maxFileSize exceeded during file upload

2006-03-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

DO NOT REPLY [Bug 36687] - Struts not populating form values when maxFileSize exceeded during file upload

2006-03-15 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUG· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED AND· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

  1   2   >