Re: [tiles2] Classpath Configuration

2006-10-16 Thread Antonio Petrelli
David H. DeWolf ha scritto: Doh! That's the one I was thinking about. . . Not sure what your status is on it, but I may be able to provide a patch for it sometime today. . . Really? That's great! I removed the assignment to me for the moment, so maybe someone else can apply your patch. Thank

Re: [tiles2] Classpath Configuration

2006-10-16 Thread David H. DeWolf
Doh! That's the one I was thinking about. . . Not sure what your status is on it, but I may be able to provide a patch for it sometime today. . . David Otherwise, I can adapt to whatever you Antonio Petrelli wrote: David H. DeWolf ha scritto: Great! Thanks . . . Once you commit, I'll refac

Re: [tiles2] Classpath Configuration

2006-10-16 Thread Antonio Petrelli
David H. DeWolf ha scritto: Great! Thanks . . . Once you commit, I'll refactor the classpath loading support that I've been working on to leverage your changes and upload a patch for your review. Uh wait please! I think you need also this fixed: http://issues.apache.org/struts/browse/SB-44

Re: [tiles2] Classpath Configuration

2006-10-16 Thread David H. DeWolf
Great! Thanks . . . Once you commit, I'll refactor the classpath loading support that I've been working on to leverage your changes and upload a patch for your review. David Antonio Petrelli wrote: Greg Reddin ha scritto: I looked briefly at the patch and I have no opposition to it. I or

Re: [tiles2] Classpath Configuration

2006-10-16 Thread Antonio Petrelli
Greg Reddin ha scritto: I looked briefly at the patch and I have no opposition to it. I originally didn't like the fact that it excluded Locale as a first class citizen when determining which definition to return. I'm still not real excited about that part. I think locale-based definitions

Re: [tiles2] Classpath Configuration

2006-10-13 Thread Greg Reddin
On Oct 13, 2006, at 1:53 AM, Antonio Petrelli wrote: You know Greg, some ideas come at night! I think that the particular case of David CAN be resolved using a different TilesContext, at least a TilesContext that returns a different URL when calling to getResource. To accomplish it, Tile

Re: [tiles2] Classpath Configuration

2006-10-12 Thread Antonio Petrelli
Greg Reddin ha scritto: On Oct 11, 2006, at 1:12 PM, David H. DeWolf wrote: I'd like to implement the ability to load tiles definitions from the classpath in addition to from the servlet/portlet context. I'm curious about implementation choices: 1) Add the support to the current ServletTil

Re: [tiles2] Classpath Configuration

2006-10-12 Thread Greg Reddin
On Oct 12, 2006, at 3:42 AM, Antonio Petrelli wrote: I don't know if it's useful, but I submitted a patch (I don't know if it applies correctly though) some time ago to enable an easier extension to Tiles defiinitions factory: https://issues.apache.org/struts/browse/SB-28 You're right, I

Re: [tiles2] Classpath Configuration

2006-10-12 Thread David H. DeWolf
Antonio Petrelli wrote: I don't know if it's useful, but I submitted a patch (I don't know if it applies correctly though) some time ago to enable an easier extension to Tiles defiinitions factory: https://issues.apache.org/struts/browse/SB-28 You can check how it is used you can check the C

Re: [tiles2] Classpath Configuration

2006-10-12 Thread Antonio Petrelli
Antonio Petrelli ha scritto: You can check how it is used you can check the CVS repository of Dimensions, the instructions are in: http://sourceforge.net/cvs/?group_id=64023 Err let's use ENGLISH instead of BANANA-REPUBLIC-ISH: You can check how it is used by checking out the HEAD of CVS r

Re: [tiles2] Classpath Configuration

2006-10-12 Thread Antonio Petrelli
Greg Reddin ha scritto: On Oct 11, 2006, at 1:12 PM, David H. DeWolf wrote: I'd like to implement the ability to load tiles definitions from the classpath in addition to from the servlet/portlet context. I'm curious about implementation choices: The primary interfaces for creating Tiles defi

Re: [tiles2] Classpath Configuration

2006-10-11 Thread Greg Reddin
On Oct 11, 2006, at 2:44 PM, David H. DeWolf wrote: So are you suggesting that we: 2) Update the UrlDefinitionsFactory to load the resource itself. 3) Create a new ClasspathDefinitionsFactory Some variation of one of the above. Ideally, we'd like to do it without changing any code :-) M

Re: [tiles2] Classpath Configuration

2006-10-11 Thread David H. DeWolf
I get what you're saying in theory, and it sounds like a great idea, however, it's not what I'm seeing. Currently: 1) DefinitionsFactory defines a method addSource(Object). 2) UrlDefinitionsFactory (the only implementation) expects the object to be an instance of type URL. 3) addSource is c

Re: [tiles2] Classpath Configuration

2006-10-11 Thread Greg Reddin
On Oct 11, 2006, at 1:12 PM, David H. DeWolf wrote: I'd like to implement the ability to load tiles definitions from the classpath in addition to from the servlet/portlet context. I'm curious about implementation choices: 1) Add the support to the current ServletTilesContext and Portlet