Re: Feedback

2016-12-11 Thread Christoph Nenning
> Hi, > I got nothing to say other than good things regarding Apache Struts > 2 and I wanted just to send you this feedback and I have started to > write a couple of blogs as a contribution to your great work. I'm > also developing a Rapid Application Development framework on top of > it as a w

Re: feedback on patches

2008-02-15 Thread Blake Byrnes
BTW - the Json Plugin Result has some of this built in without a dependency to beanlib. On Fri, Feb 15, 2008 at 10:21 AM, Blake Byrnes <[EMAIL PROTECTED]> wrote: > Ok. I think the other nice thing in those stream handlers would be to > handle hibernate objects on the way out. Right now, they ju

Re: feedback on patches

2008-02-15 Thread Blake Byrnes
Ok. I think the other nice thing in those stream handlers would be to handle hibernate objects on the way out. Right now, they just send back the uninitialized junk that hibernate creates. In my project, I used Beanlib to run them through a cleaner, but for a slightly different purpose. To real

Re: feedback on patches

2008-02-15 Thread Wes Wannemacher
On 2/15/08, Blake Byrnes <[EMAIL PROTECTED]> wrote: [snip] > > Just another potential approach. I don't understand the reasoning behind > the request specs that got posted in the JIRA ticket. > I am not sure about the lengthy discussion either (which was the main reason behind not applying my p

Re: feedback on patches

2008-02-15 Thread Blake Byrnes
optimize the > solution then that can be done as another step. > > Al. > > - Original Message - > From: "Matt Raible" <[EMAIL PROTECTED]> > To: "Struts Developers List" > Sent: Thursday, February 14, 2008 4:54 PM > Subject: Re: fe

Re: feedback on patches

2008-02-14 Thread Al Sutton
ther step. Al. - Original Message - From: "Matt Raible" <[EMAIL PROTECTED]> To: "Struts Developers List" Sent: Thursday, February 14, 2008 4:54 PM Subject: Re: feedback on patches Although I am not sure about how this will affect performance (since this reader may

Re: feedback on patches

2008-02-14 Thread Wes Wannemacher
The reader that causes the problem is only accessed (currently) when JSON or XStream data is posted. I would imagine that buffering/no-buffering isn't going to make that much difference. Plus, I tested my fix with the struts2-rest-showcase (or whatever it's called), which isn't a big app, but I ver

Re: feedback on patches

2008-02-14 Thread Matt Raible
Although I am not sure about how this will affect performance (since this reader may not be buffered), this patch resolves the issue. It seems that you get the IllegalStateException if getReader() is called after a call to getInputStream(). So, I call getInputStream() again and create an InputStre

Re: Feedback on ParameterMappingDispatchAction (ID=38343)

2006-02-07 Thread Michael Jouravlev
On 2/7/06, Paul Benedict <[EMAIL PROTECTED]> wrote: > I'd like to hear some feedback on an enhancement of MappingDispatchAction > (ParameterMappingDispatchAction) which I have contributed. It merges the > flexibility of choosing the dispatch through the request plus the static > configuration