Re: First commit is a FAILURE! - Second commit is a SUCCESS!

2008-02-10 Thread Martin Cooper
On Feb 10, 2008 10:10 AM, Wes Wannemacher <[EMAIL PROTECTED]> wrote: > I just updated the unit test and bamboo is happy again. I ended up > looking for the TLD file using getResource(), which is a lot cleaner > anyways. I noticed a few things in the process, first you really have to > persuade ecl

Re: First commit is a FAILURE! - Second commit is a SUCCESS!

2008-02-10 Thread Wes Wannemacher
I just updated the unit test and bamboo is happy again. I ended up looking for the TLD file using getResource(), which is a lot cleaner anyways. I noticed a few things in the process, first you really have to persuade eclipse to quit using tabs, and second, I can't assign the JIRA to myself (or clo

Re: First commit is a FAILURE!

2008-02-10 Thread Dave Newton
--- Antonio Petrelli <[EMAIL PROTECTED]> wrote: > Making mistakes, IMHO, is part of the development process: I must be a really, really good developer then. Dave - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional comman

Re: First commit is a FAILURE!

2008-02-10 Thread Antonio Petrelli
2008/2/9, Wes Wannemacher <[EMAIL PROTECTED]>: >...I apologize for that :( > > Again sorry! Wes Don't be too bad with yourself. We all make mistakes, but, luckily, in our case we have Subversion that helps us returning to the working versions :-) Making mistakes, IMHO, is part of the development p

Re: First commit is a FAILURE!

2008-02-10 Thread Ted Husted
Bamboo is also know to generate false negatives. If it passed locally under J5, try making an innocuous commit so it builds again. I don't remember discussed using J6 code for tests or otherwise, and so if we have a J6 issue, we should address that directly. HTH, Ted. On Feb 9, 2008 5:17 PM, Wes

Re: First commit is a FAILURE!

2008-02-09 Thread Wes Wannemacher
On Sat, 2008-02-09 at 14:40 -0800, Martin Cooper wrote: > My guess is that it has nothing to do with the JDK version, but has to do > with the state of the classpath while the tests are being run. Your test > code does not handle the case in which your target URL is not found in the > classpath,

Re: First commit is a FAILURE!

2008-02-09 Thread Martin Cooper
On Feb 9, 2008 2:17 PM, Wes Wannemacher <[EMAIL PROTECTED]> wrote: > I tried to commit a fix for WW-2477, which would be my first. I didn't > realize that Bamboo is running/building with java 6. Shortly after > committing, the Bamboo builds failed on the unit test I committed with > the fix. I apo