Re: Localized bean

2017-03-24 Thread Lukasz Lenart
The got merged so the example is in as well :) 2017-03-22 7:45 GMT+01:00 Lukasz Lenart : > I have an example app ready but to get it merged into struts-examples, > this PR must get merged first [1] > > [1] https://github.com/apache/struts/pull/123 > > > Regards > -- > Łukasz > + 48 606 323 122 htt

Re: Localized bean

2017-03-21 Thread Lukasz Lenart
I have an example app ready but to get it merged into struts-examples, this PR must get merged first [1] [1] https://github.com/apache/struts/pull/123 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscri

Re: Localized bean

2017-03-17 Thread Lukasz Lenart
Looks good, thanks :) 2017-03-17 12:05 GMT+01:00 Greg Huber : > Would this be enough information? > > https://issues.apache.org/jira/browse/WW-4762 > > Cheers Greg > > On 17 March 2017 at 07:16, Lukasz Lenart wrote: > >> 2017-03-15 9:50 GMT+01:00 Greg Huber : >> >>you can always implement your ow

Re: Localized bean

2017-03-17 Thread Greg Huber
Would this be enough information? https://issues.apache.org/jira/browse/WW-4762 Cheers Greg On 17 March 2017 at 07:16, Lukasz Lenart wrote: > 2017-03-15 9:50 GMT+01:00 Greg Huber : > >>you can always implement your own > >>LocalizedTextProvider and search in default bundles first and then > >>

Re: Localized bean

2017-03-17 Thread Lukasz Lenart
2017-03-15 9:50 GMT+01:00 Greg Huber : >>you can always implement your own >>LocalizedTextProvider and search in default bundles first and then >>fallback to searching class hierarchy. > > There seems alot going on in DefaultLocalizedTextProvider so I would rather > stay with the default and do the

Re: Localized bean

2017-03-15 Thread Greg Huber
>you can always implement your own >LocalizedTextProvider and search in default bundles first and then >fallback to searching class hierarchy. There seems alot going on in DefaultLocalizedTextProvider so I would rather stay with the default and do the local modification. >Something like getDefau

Re: Localized bean

2017-03-15 Thread Łukasz Lenart
Something like getDefaultText()? but you can always implement your own LocalizedTextProvider and search in default bundles first and then fallback to searching class hierarchy. Maybe I should prepare a small demo? Regards -- Łukasz 2017-03-15 9:08 GMT+01:00 Greg Huber : >>Hm... I think definin

Re: Localized bean

2017-03-15 Thread Greg Huber
>Hm... I think defining struts.custom.i18n.resources should resolve your problem >struts.custom.i18n.resources=ApplicationResources I already have this, but since I came from a struts 1, I am not motivated to use the class package logic as there would be too much duplication and maintenance of all

Re: Localized bean

2017-03-14 Thread Lukasz Lenart
2017-03-14 16:13 GMT+01:00 Greg Huber : > I replace: > > // search up class hierarchy > String msg = findMessage(aClass, aTextName, indexedTextName, > locale, args, null, valueStack); > > with: > > GetDefaultMessageReturnArg result = null; > if (indexedTextName == null) { >

Re: Localized bean

2017-03-14 Thread Greg Huber
I replace: // search up class hierarchy String msg = findMessage(aClass, aTextName, indexedTextName, locale, args, null, valueStack); with: GetDefaultMessageReturnArg result = null; if (indexedTextName == null) { // Use a null for the defaultMessage to ensure

Re: Localized bean

2017-03-14 Thread Lukasz Lenart
2017-03-14 15:24 GMT+01:00 Greg Huber : > Initial tests look good. > > LocalizedTextUtil.java is now the only bespoke mod I do (to check the > default ApplicationResources.properties first and then do the package nifty > thing). > > I have looked in > > Struts-JDK7-pull-request/core/src/main/java/c

Re: Localized bean

2017-03-14 Thread Greg Huber
Initial tests look good. LocalizedTextUtil.java is now the only bespoke mod I do (to check the default ApplicationResources.properties first and then do the package nifty thing). I have looked in Struts-JDK7-pull-request/core/src/main/java/com/opensymphony/xwork2/util but seems not to be there

Re: Localized bean

2017-03-14 Thread Lukasz Lenart
2017-03-14 15:03 GMT+01:00 Greg Huber : > So I would only need to replace the struts2-core.x.x.jar? Yes, you are right :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@s

Re: Localized bean

2017-03-14 Thread Greg Huber
So I would only need to replace the struts2-core.x.x.jar? On 14 March 2017 at 10:14, Lukasz Lenart wrote: > 2017-03-14 10:32 GMT+01:00 Greg Huber : > > I remember there was a snapshot build from the trunk that I used to use > to > > monitor progress, is that still being built here? > > Yeah but

Re: Localized bean

2017-03-14 Thread Lukasz Lenart
2017-03-14 10:32 GMT+01:00 Greg Huber : > I remember there was a snapshot build from the trunk that I used to use to > monitor progress, is that still being built here? Yeah but only for the master branch, we don't publish SNAPSHOT artifacts for PRs - to not override SNAPSHOTS based on the master

Re: Localized bean

2017-03-14 Thread Greg Huber
I remember there was a snapshot build from the trunk that I used to use to monitor progress, is that still being built here? On 14 March 2017 at 09:30, Lukasz Lenart wrote: > Hi, > > If you have time please take a look on this [1], it isn't the final > stage but at least it allows to have differ