Re: SMI on steroids

2016-02-15 Thread Greg Huber
A configurable default regex would be useful, so can override it in the struts.xmleg [a-zA-Z]* >> ^[A-Za-z0-9]{1,25}$ etc. Also, not too many changes needed! Cheers Greg. On 14 February 2016 at 14:23, Lukasz Lenart wrote: > 2016-02-11 12:02 GMT+01:00 Greg Huber : > > Can there be

Re: SMI on steroids

2016-02-14 Thread Lukasz Lenart
2016-02-11 12:02 GMT+01:00 Greg Huber : > Can there be two levels on the SMI? > > If DMI is on and SMI is in relaxed-strict mode (false) we can leave the > > {1} and prefix{0}suffix in so it works. > > although it would be better to have some kind of regex ie > regex:([A-Z-a-z]*) for safety plus a

Re: SMI on steroids Feature Request

2016-02-12 Thread Rene Gielen
ot a manager..so this is not my > call > Good Luck Greg! > Martin > __ > > > > >> Date: Thu, 11 Feb 2016 11:02:41 + >> Subject: Re: SMI on steroids >> From: gregh3...@gmail.com >> To: dev@struts.apache.org >&

RE: SMI on steroids Feature Request

2016-02-12 Thread Martin Gainty
call Good Luck Greg! Martin __ > Date: Thu, 11 Feb 2016 11:02:41 + > Subject: Re: SMI on steroids > From: gregh3...@gmail.com

Re: SMI on steroids

2016-02-11 Thread Greg Huber
Can there be two levels on the SMI? If DMI is on and SMI is in relaxed-strict mode (false) we can leave the {1} and prefix{0}suffix in so it works. although it would be better to have some kind of regex ie regex:([A-Z-a-z]*) for safety plus a max length! Then if SMI is in strict mode (true) rem

Re: SMI on steroids

2016-02-05 Thread Greg Huber
Date: Fri, 5 Feb 2016 15:14:03 + > > Subject: Re: SMI on steroids > > From: gregh3...@gmail.com > > To: dev@struts.apache.org > > > > To pass globally: > > > > regex:prefix(.*)suffix > > Greg: > > I thought RegEx is enabled only when SMI is disabl

RE: SMI on steroids

2016-02-05 Thread Martin Gainty
> Date: Fri, 5 Feb 2016 15:14:03 + > Subject: Re: SMI on steroids > From: gregh3...@gmail.com > To: dev@struts.apache.org > > To pass globally: > > regex:prefix(.*)suffix Greg: I thought RegEx is enabled only when SMI is disabled? SMI works in the following w

Re: SMI on steroids

2016-02-05 Thread Greg Huber
To pass globally: regex:prefix(.*)suffix On 5 February 2016 at 14:25, Christoph Nenning < christoph.nenn...@lex-com.net> wrote: > > Hi, > > > > There is a huge discussion about how SMI should work in case of using > > wildcard mapping [1]. Basically when action is defined as follow: > > > > > >

Re: SMI on steroids

2016-02-05 Thread Greg Huber
You can use global and action allowed methods: MyMethod,etc MyMethod,etc For SMI to work on method="{1}" there is no option as it adds a (.*) so must be removed. For method="prefix{1}suffix" it adds a prefix(.*)suffix and if this is removed all methods would require a definition in either the

Re: SMI on steroids

2016-02-05 Thread Christoph Nenning
> Hi, > > There is a huge discussion about how SMI should work in case of using > wildcard mapping [1]. Basically when action is defined as follow: > > > view.jsp > input.jsp > > > SMI will allow access any method in PersonAction class because {1} is > translated into RegEx (.*) - as y

Re: SMI on steroids

2016-02-05 Thread Lukasz Lenart
2016-02-05 10:20 GMT+01:00 Greg Huber : > my lastest comment.. > > The entry that we don't want is {1} style > > PatternAllowedMethod{allowedMethodPattern=(.*), original='\{1\}'\} > > which is don't check anything, effectively disabling SMI. > > run{1}This style could be left in, as they are pretty

Re: SMI on steroids

2016-02-05 Thread Greg Huber
​my lastest comment.. The entry that we don't want is {1} style PatternAllowedMethod{allowedMethodPattern=(.*), original='\{1\}'\} which is don't check anything, effectively disabling SMI. run{1}This style could be left in, as they are pretty restrictive, or is there a regex for the pattern tha