Re: Struts 2.5.11 test build is ready

2017-07-06 Thread Lukasz Lenart
Ok, all the things are done :) So I'm going to drop 2.5.11 and prepare 2.5.12 ASAP - I assume there no more issue and we can officially release on the next Monday. 2017-07-05 15:49 GMT+02:00 Lukasz Lenart : > 2.5.11 is in a test phase and I would like to either resolve the issue > with locale or m

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Lukasz Lenart
2.5.11 is in a test phase and I would like to either resolve the issue with locale or mark it as invalid. Then we can decided what to do. 2017-07-05 15:46 GMT+02:00 Yasser Zamani : > I started with WW-4810 but could not re-produce. I tested > `?request_locale=` , `?request_locale=''` and `?request

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Yasser Zamani
I started with WW-4810 but could not re-produce. I tested `?request_locale=` , `?request_locale=''` and `?request_locale=""`. All works here with Struts 2.5.11. Same for `ff` , `fff` and ``. Sorry if it's a bad question; Couldn't we do them in 2.5.11, or 2.5.11 is released and available pub

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Yasser Zamani
I started with WW-4810 but could not re-produce. I tested `?request_locale=` , `?request_locale=''` and `?request_locale=""`. All works here with Struts 2.5.11. Same for `ff` , `fff` and ``. Sorry if it's a bad question; Couldn't we do them in 2.5.11, or 2.5.11 is released and available pub

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Christoph Nenning
> > Struts 2.5.11 successfully passed Our JMeter functional integration test > > scenarios :) > > Great! There are two issues I want to address and release 2.5.12, what > do you think? > > https://issues.apache.org/jira/projects/WW/versions/12341037 > > +1 Regards, Christoph This Email wa

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Lukasz Lenart
2017-07-01 17:42 GMT+02:00 Yasser Zamani : > Struts 2.5.11 successfully passed Our JMeter functional integration test > scenarios :) Great! There are two issues I want to address and release 2.5.12, what do you think? https://issues.apache.org/jira/projects/WW/versions/12341037 Regards -- Łuka

Re: Struts 2.5.11 test build is ready

2017-07-01 Thread Yasser Zamani
Struts 2.5.11 successfully passed Our JMeter functional integration test scenarios :) On 6/22/2017 6:06 PM, Lukasz Lenart wrote: > Hi, > > Please take a time and test the bits - any help is appreciated. Please > report any problems back. I'll call for vote in a week if no problems > will be spott

Re: Struts 2.5.11 test build is ready

2017-06-27 Thread Lukasz Lenart
2017-06-27 10:25 GMT+02:00 i...@flyingfischer.ch : > provider.findText() seems to need in any case three arguments. > > provider.findDefaultText(key, locale) works perfectly without bundle. Ach... you are right, this is what "global-only" implementation does, it only uses "findDefaultText" methods

Re: Struts 2.5.11 test build is ready

2017-06-27 Thread i...@flyingfischer.ch
Am 27.06.2017 um 10:05 schrieb Lukasz Lenart: > 2017-06-27 8:59 GMT+02:00 i...@flyingfischer.ch : >> For the time being, it really can't be shorter than this?: >> >> final LocaleProviderFactory factory = >> ActionContext.getContext().getInstance(LocaleProviderFactory.class); >> fina

Re: Struts 2.5.11 test build is ready

2017-06-27 Thread Lukasz Lenart
2017-06-27 8:59 GMT+02:00 i...@flyingfischer.ch : > For the time being, it really can't be shorter than this?: > > final LocaleProviderFactory factory = > ActionContext.getContext().getInstance(LocaleProviderFactory.class); > final Locale locale = factory.createLocaleProvider().getL

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread i...@flyingfischer.ch
Am 27.06.2017 um 08:42 schrieb Lukasz Lenart: > 2017-06-27 8:38 GMT+02:00 i...@flyingfischer.ch : >> Thanks! This works fine. And you are perfectly right: >> >> StringEscapeUtils.unescapeHtml4(value.replaceAll("''", "'")); >> >> Is not needed anymore. It seemed, if I am not mistaken, to be necessar

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread Lukasz Lenart
2017-06-27 8:38 GMT+02:00 i...@flyingfischer.ch : > Thanks! This works fine. And you are perfectly right: > > StringEscapeUtils.unescapeHtml4(value.replaceAll("''", "'")); > > Is not needed anymore. It seemed, if I am not mistaken, to be necessary > with: > > LocalizedTextUtil.findDefaultText(key,

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread i...@flyingfischer.ch
> It must be a bean create by the framework, e.g. an action, then the > LocalizedTextProvider gets injected. If you want to use it in some > other context you can use this approach: > > LocalizedTextProvider provider = > ActionContext.getContext().getInstance(LocalizedTextProvider.class) > LocaleP

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread Lukasz Lenart
2017-06-26 18:28 GMT+02:00 i...@flyingfischer.ch : > Thanks for the inputs. I cant't get this to work. Sorry, this is rather > a topic for user list. I'll wait to see some examples coming around. For > the moment being I'll use, not very sophisticated my utility class > below. This works fine. Thou

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread i...@flyingfischer.ch
Am 26.06.2017 um 08:57 schrieb Lukasz Lenart: > 2017-06-25 8:07 GMT+02:00 i...@flyingfischer.ch : >> I get stuck with the refactored LocalizedTextUtil: >> >> We had a change in 2.5.2 which disallowed the use of getText(String key) >> in classes that cannot extend ActionSupport. >> >> I did work aro

Re: Struts 2.5.11 test build is ready

2017-06-25 Thread Lukasz Lenart
2017-06-25 8:07 GMT+02:00 i...@flyingfischer.ch : > I get stuck with the refactored LocalizedTextUtil: > > We had a change in 2.5.2 which disallowed the use of getText(String key) > in classes that cannot extend ActionSupport. > > I did work around with a custom utility class that did the job, buil

Re: Struts 2.5.11 test build is ready

2017-06-25 Thread i...@flyingfischer.ch
Thanks! Seems to do the job! Markus Am 25.06.2017 um 11:21 schrieb Greg Huber: > If you know the location of the messages you can just use : > > ResourceBundle.getBundle("ApplicationResources", locale); > > Which would be faster than using the LocalizedTextUtil which searches the > hierarchy etc

Re: Struts 2.5.11 test build is ready

2017-06-25 Thread Greg Huber
If you know the location of the messages you can just use : ResourceBundle.getBundle("ApplicationResources", locale); Which would be faster than using the LocalizedTextUtil which searches the hierarchy etc. On 25 June 2017 at 07:07, i...@flyingfischer.ch wrote: > I get stuck with the refactor

Re: Struts 2.5.11 test build is ready

2017-06-24 Thread i...@flyingfischer.ch
I get stuck with the refactored LocalizedTextUtil: We had a change in 2.5.2 which disallowed the use of getText(String key) in classes that cannot extend ActionSupport. I did work around with a custom utility class that did the job, built mainly around: final String value = LocalizedTextUtil.fin

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Christoph Nenning
Hi, it's working great in my apps! But I had to adjust some things: - explicitly upgrade versions of logging library and apis (log4j to 2.8.2 and slf4j to 1.7.24) - we have some custom code dealing with TextProvider, that needed to be adapted after refactoring in struts regards, Christoph

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Greg Huber
OK, great, switched to 3.6 and seems to work now. Cheers Greg. On 23 June 2017 at 09:15, Lukasz Lenart wrote: > Just notice that the Struts 2.5.11 is using Commons-Lang 3.6, maybe > this is the issue. > > 2017-06-23 10:04 GMT+02:00 Greg Huber : > > Getting a really strange message testing this

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Greg Huber
*javax.servlet.ServletException: java.lang.NoSuchMethodError: org.apache.commons.lang3.reflect.MethodUtils.getMethodsListWithAnnotation(Ljava/lang/Class;Ljava/lang/Class;ZZ)Ljava/util/List;* org.apache.jasper.runtime.PageContextImpl.doHandlePageException(PageContextImpl.java:909) org.apa

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Lukasz Lenart
Just notice that the Struts 2.5.11 is using Commons-Lang 3.6, maybe this is the issue. 2017-06-23 10:04 GMT+02:00 Greg Huber : > Getting a really strange message testing this : > > >1. > > org.apache.commons.lang3.reflect.MethodUtils.getMethodsListWithAnnotation(Ljava/lang/Class;Ljava/lang

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Lukasz Lenart
Greg can you post the whole stack trace? 2017-06-23 10:04 GMT+02:00 Greg Huber : > Getting a really strange message testing this : > > >1. > > org.apache.commons.lang3.reflect.MethodUtils.getMethodsListWithAnnotation(Ljava/lang/Class;Ljava/lang/Class;ZZ)Ljava/util/List; >2. java.lang.N

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Greg Huber
Getting a really strange message testing this : 1. org.apache.commons.lang3.reflect.MethodUtils.getMethodsListWithAnnotation(Ljava/lang/Class;Ljava/lang/Class;ZZ)Ljava/util/List; 2. java.lang.NoSuchMethodError: org.apache.commons.lang3.reflect.MethodUtils.getMethodsListWithAnnotatio