Re: Struts 2.5.11 test build is ready

2017-07-06 Thread Lukasz Lenart
h locale or mark it as invalid. Then we can decided what to do. > > 2017-07-05 15:46 GMT+02:00 Yasser Zamani : >> I started with WW-4810 but could not re-produce. I tested >> `?request_locale=` , `?request_locale=''` and `?request_locale=""`. All >> works h

Re: Struts 2.5.11 not serving iclass icons

2017-07-06 Thread Lukasz Lenart
2017-07-06 9:18 GMT+02:00 [email protected] : > Thanks again for insisting so much on looking into this. I think I got > the (painful simple) root reason: > > While further debuggin on the empty locale story, I did reset to > 2.5.10.1 and then back again 2.5.11 and I also did clean the Tomcat >

Re: Struts 2.5.11 not serving iclass icons

2017-07-06 Thread [email protected]
Thanks again for insisting so much on looking into this. I think I got the (painful simple) root reason: While further debuggin on the empty locale story, I did reset to 2.5.10.1 and then back again 2.5.11 and I also did clean the Tomcat working directory... ...now setting up a test page like bel

Re: Struts 2.5.11 not serving iclass icons

2017-07-05 Thread Lukasz Lenart
Argh... forgot to add a CSS stylesheet and now everything works as expected, my setup below: <%@ page contentType="text/html; charset=UTF-8" %> <%@ taglib prefix="s" uri="/struts-tags" %> Action Chaining https://maxcdn.bootstrapcdn.com/bootstrap/3.3.7/css/bootstrap.min.css"; rel="stylesh

Re: Struts 2.5.11 not serving iclass icons

2017-07-05 Thread Lukasz Lenart
I was able confirm this somehow ... but I need your exact setup, what version of Bootstrap do you use? Do you use FontAwesome directly? There is no issue when I used a pure reference to FontAwesome (with their CDN) but it doesn't work when using Bootstrap one. Regards -- Łukasz + 48 606 323 122

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Lukasz Lenart
#x27;'` and `?request_locale=""`. All > works here with Struts 2.5.11. Same for `ff` , `fff` and ``. > > Sorry if it's a bad question; Couldn't we do them in 2.5.11, or 2.5.11 > is released and available publicly and not modifiable? > > On 7/5/2017 3:27 PM, Luk

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Yasser Zamani
I started with WW-4810 but could not re-produce. I tested `?request_locale=` , `?request_locale=''` and `?request_locale=""`. All works here with Struts 2.5.11. Same for `ff` , `fff` and ``. Sorry if it's a bad question; Couldn't we do them in 2.5.11, or 2.5

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Yasser Zamani
I started with WW-4810 but could not re-produce. I tested `?request_locale=` , `?request_locale=''` and `?request_locale=""`. All works here with Struts 2.5.11. Same for `ff` , `fff` and ``. Sorry if it's a bad question; Couldn't we do them in 2.5.11, or 2.5

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Christoph Nenning
> > Struts 2.5.11 successfully passed Our JMeter functional integration test > > scenarios :) > > Great! There are two issues I want to address and release 2.5.12, what > do you think? > > https://issues.apache.org/jira/projects/WW/versions/12341037 > > +1

Re: Struts 2.5.11 not serving iclass icons

2017-07-05 Thread [email protected]
Am 05.07.2017 um 13:23 schrieb Lukasz Lenart: > This is very strange ... I don't understand where is the problem :\ Do > you serve those CSSs files via the Strust filter as a static content? > The CSS file seems to get through. The Layout is as should. The CSS file is packed in a subdirectory of W

Re: Struts 2.5.11 not serving iclass icons

2017-07-05 Thread Lukasz Lenart
This is very strange ... I don't understand where is the problem :\ Do you serve those CSSs files via the Strust filter as a static content? 2017-06-26 12:04 GMT+02:00 [email protected] : > Am 26.06.2017 um 11:55 schrieb Lukasz Lenart: >> 2017-06-26 11:50 GMT+02:00 [email protected] : >>>

Re: Struts 2.5.11 test build is ready

2017-07-05 Thread Lukasz Lenart
2017-07-01 17:42 GMT+02:00 Yasser Zamani : > Struts 2.5.11 successfully passed Our JMeter functional integration test > scenarios :) Great! There are two issues I want to address and release 2.5.12, what do you think? https://issues.apache.org/jira/projects/WW/versions/12341037 R

Re: Struts 2.5.11 test build is ready

2017-07-01 Thread Yasser Zamani
Struts 2.5.11 successfully passed Our JMeter functional integration test scenarios :) On 6/22/2017 6:06 PM, Lukasz Lenart wrote: > Hi, > > Please take a time and test the bits - any help is appreciated. Please > report any problems back. I'll call for vote in a week if no p

Re: Struts 2.5.11 test build is ready

2017-06-27 Thread Lukasz Lenart
2017-06-27 10:25 GMT+02:00 [email protected] : > provider.findText() seems to need in any case three arguments. > > provider.findDefaultText(key, locale) works perfectly without bundle. Ach... you are right, this is what "global-only" implementation does, it only uses "findDefaultText" methods

Re: Struts 2.5.11 test build is ready

2017-06-27 Thread [email protected]
Am 27.06.2017 um 10:05 schrieb Lukasz Lenart: > 2017-06-27 8:59 GMT+02:00 [email protected] : >> For the time being, it really can't be shorter than this?: >> >> final LocaleProviderFactory factory = >> ActionContext.getContext().getInstance(LocaleProviderFactory.class); >> fina

Re: Struts 2.5.11 test build is ready

2017-06-27 Thread Lukasz Lenart
2017-06-27 8:59 GMT+02:00 [email protected] : > For the time being, it really can't be shorter than this?: > > final LocaleProviderFactory factory = > ActionContext.getContext().getInstance(LocaleProviderFactory.class); > final Locale locale = factory.createLocaleProvider().getL

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread [email protected]
Am 27.06.2017 um 08:42 schrieb Lukasz Lenart: > 2017-06-27 8:38 GMT+02:00 [email protected] : >> Thanks! This works fine. And you are perfectly right: >> >> StringEscapeUtils.unescapeHtml4(value.replaceAll("''", "'")); >> >> Is not needed anymore. It seemed, if I am not mistaken, to be necessar

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread Lukasz Lenart
2017-06-27 8:38 GMT+02:00 [email protected] : > Thanks! This works fine. And you are perfectly right: > > StringEscapeUtils.unescapeHtml4(value.replaceAll("''", "'")); > > Is not needed anymore. It seemed, if I am not mistaken, to be necessary > with: > > LocalizedTextUtil.findDefaultText(key,

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread [email protected]
> It must be a bean create by the framework, e.g. an action, then the > LocalizedTextProvider gets injected. If you want to use it in some > other context you can use this approach: > > LocalizedTextProvider provider = > ActionContext.getContext().getInstance(LocalizedTextProvider.class) > LocaleP

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale [resolved]

2017-06-26 Thread Lukasz Lenart
2017-06-27 8:16 GMT+02:00 [email protected] : > private String opacity = "0.9"; > > This works with Right, this does not depend on Number Conversion :) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To uns

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread Lukasz Lenart
2017-06-26 18:28 GMT+02:00 [email protected] : > Thanks for the inputs. I cant't get this to work. Sorry, this is rather > a topic for user list. I'll wait to see some examples coming around. For > the moment being I'll use, not very sophisticated my utility class > below. This works fine. Thou

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale [resolved]

2017-06-26 Thread [email protected]
Am 27.06.2017 um 08:12 schrieb Lukasz Lenart: > 2017-06-26 21:27 GMT+02:00 [email protected] : >> Now EL brings replaces >> >> >> >> in locale en with 0.9 and in all other locales with 0,9 (note the COMMA). > Oh... thanks a lot for diggin this, can you use instead of > ? > > > Regards I did s

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale [resolved]

2017-06-26 Thread Lukasz Lenart
2017-06-26 21:27 GMT+02:00 [email protected] : > Now EL brings replaces > > > > in locale en with 0.9 and in all other locales with 0,9 (note the COMMA). Oh... thanks a lot for diggin this, can you use instead of ? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale [resolved]

2017-06-26 Thread [email protected]
> Very strange: values do get replaced: > > > notif({ > msg: "Ungültige Angaben!", > type: "info", > position: "center", > opacity: 0,9, > timeout: 5000, > multiline: true, > autohide: true, > clickable: false > }); > > > But JS box will still not show up, when not on default locale... > > ...an

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale

2017-06-26 Thread [email protected]
> I did some more tests: > > Test 1: in action hardcoded messages: > > jsmsg = new JSMessage("Show up!"); > > On default locale: message shows up. > Any other locale: No show up > > => Problem persists > > Test 2: in JSP hardcoded message > > > notif({ >msg: "Show up!", >

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale

2017-06-26 Thread [email protected]
> At the moment testing locally and not online: > > Browser send en-US,en;q=0.5 on default > OS linux on german locale > changing locale in application by ?request_locale=it > in struts.properties: struts.custom.i18n.resources=global-messages > > properties files: > > global-messages_de.properties

Re: Struts 2.5.11 test build is ready

2017-06-26 Thread [email protected]
Am 26.06.2017 um 08:57 schrieb Lukasz Lenart: > 2017-06-25 8:07 GMT+02:00 [email protected] : >> I get stuck with the refactored LocalizedTextUtil: >> >> We had a change in 2.5.2 which disallowed the use of getText(String key) >> in classes that cannot extend ActionSupport. >> >> I did work aro

Re: Struts 2.5.11 not serving iclass icons

2017-06-26 Thread [email protected]
Am 26.06.2017 um 11:55 schrieb Lukasz Lenart: > 2017-06-26 11:50 GMT+02:00 [email protected] : >> Yes, the import statement is already there. It is a combined css file >> (fonts and other CSS statements). Works perfect, also for 2.5.11. But >> the webfonts seem to be treated differently, but on

Re: Struts 2.5.11 not serving iclass icons

2017-06-26 Thread Lukasz Lenart
2017-06-26 11:50 GMT+02:00 [email protected] : > Yes, the import statement is already there. It is a combined css file > (fonts and other CSS statements). Works perfect, also for 2.5.11. But > the webfonts seem to be treated differently, but only if used as class="fa fa-envelope-o">. > > I wor

Re: Struts 2.5.11 not serving iclass icons [resolved]

2017-06-26 Thread Lukasz Lenart
2017-06-26 11:28 GMT+02:00 [email protected] : > Tomcat serves the JSP as Unicode/UTF-8. The css is served as ISO. So this means something is wrong with Tomcat configuration, right? Or you still see the issue? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ ---

Re: Struts 2.5.11 not serving iclass icons

2017-06-26 Thread [email protected]
Am 26.06.2017 um 11:01 schrieb Lukasz Lenart: > 2017-06-26 10:23 GMT+02:00 [email protected] : >> Using FontAwesome > Same here > >> I am on thin ice: I fear the images do display as kind of textual >> representation of private use unicode code points, which they should >> not. I'll try to dig

Re: Struts 2.5.11 not serving iclass icons [resolved]

2017-06-26 Thread [email protected]
Am 26.06.2017 um 11:17 schrieb Lukasz Lenart: > 2017-06-26 10:50 GMT+02:00 [email protected] : >> Using >> >>  instead of >> >> resolves the issue. But I still suspect a change in coding / treating >> unicode in Struts. >> >> The CSS starts with @charset "UTF-8"; > Can you check how does it

Re: Struts 2.5.11 not serving iclass icons [resolved]

2017-06-26 Thread Lukasz Lenart
2017-06-26 10:50 GMT+02:00 [email protected] : > Using > >  instead of > > resolves the issue. But I still suspect a change in coding / treating > unicode in Struts. > > The CSS starts with @charset "UTF-8"; Can you check how does it serve by a server? Regards -- Łukasz + 48 606 323 122

Re: Struts 2.5.11 not serving iclass icons

2017-06-26 Thread Lukasz Lenart
2017-06-26 10:23 GMT+02:00 [email protected] : > Using FontAwesome Same here > I am on thin ice: I fear the images do display as kind of textual > representation of private use unicode code points, which they should > not. I'll try to dig deeper... It isn't UTF tricks, it's a normal font def

Re: Struts 2.5.11 not serving iclass icons [resolved]

2017-06-26 Thread [email protected]
Am 26.06.2017 um 10:23 schrieb [email protected]: > Am 26.06.2017 um 09:04 schrieb Lukasz Lenart: >> 2017-06-25 15:26 GMT+02:00 [email protected] : >>> I detected a strange issue. The problem is not present in 2.5.10.1 but >>> only in 2.5.11: >>> >>> In jsp: >>> >>> This will not show up a

Re: Struts 2.5.11 not serving iclass icons

2017-06-26 Thread [email protected]
Am 26.06.2017 um 09:04 schrieb Lukasz Lenart: > 2017-06-25 15:26 GMT+02:00 [email protected] : >> I detected a strange issue. The problem is not present in 2.5.10.1 but >> only in 2.5.11: >> >> In jsp: >> >> This will not show up as icon, but as kind of scrambled text. Using >> struts2-tiles-p

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale

2017-06-26 Thread [email protected]
> 2017-06-25 16:14 GMT+02:00 [email protected] : >> Another issue, since 2.5.11: >> >> Javascript boxed messages display, if the language is the default >> language (en). As soon as switching the application to another locale >> (e.g. de), js-box messages do not display anymore... >> >> ...this

Re: Struts 2.5.11: js based messages not showing up, when chanching default locale

2017-06-26 Thread Lukasz Lenart
2017-06-25 16:14 GMT+02:00 [email protected] : > Another issue, since 2.5.11: > > Javascript boxed messages display, if the language is the default > language (en). As soon as switching the application to another locale > (e.g. de), js-box messages do not display anymore... > > ...this IS NOT r

Re: Struts 2.5.11 not serving iclass icons

2017-06-26 Thread Lukasz Lenart
2017-06-25 15:26 GMT+02:00 [email protected] : > I detected a strange issue. The problem is not present in 2.5.10.1 but > only in 2.5.11: > > In jsp: > > This will not show up as icon, but as kind of scrambled text. Using > struts2-tiles-plugin. > > Hard to imagine to be struts related, but co

Re: Struts 2.5.11 test build is ready

2017-06-25 Thread Lukasz Lenart
2017-06-25 8:07 GMT+02:00 [email protected] : > I get stuck with the refactored LocalizedTextUtil: > > We had a change in 2.5.2 which disallowed the use of getText(String key) > in classes that cannot extend ActionSupport. > > I did work around with a custom utility class that did the job, buil

Struts 2.5.11: js based messages not showing up, when chanching default locale

2017-06-25 Thread [email protected]
Another issue, since 2.5.11: Javascript boxed messages display, if the language is the default language (en). As soon as switching the application to another locale (e.g. de), js-box messages do not display anymore... ...this IS NOT related to retrieving the values from the corresponding language

Struts 2.5.11 not serving iclass icons

2017-06-25 Thread [email protected]
I detected a strange issue. The problem is not present in 2.5.10.1 but only in 2.5.11: In jsp: This will not show up as icon, but as kind of scrambled text. Using struts2-tiles-plugin. Hard to imagine to be struts related, but could this still be possibly related to any of the recent changes?

Re: Struts 2.5.11 test build is ready

2017-06-25 Thread [email protected]
I had to adjust some things: >>> - explicitly upgrade versions of logging library and apis (log4j to 2.8.2 >>> and slf4j to 1.7.24) >>> - we have some custom code dealing with TextProvider, that needed to be >>> adapted after refactoring in struts >>> >&

Re: Struts 2.5.11 test build is ready

2017-06-25 Thread Greg Huber
eeded to be > > adapted after refactoring in struts > > > > > > > > regards, > > Christoph > > > > > > > >> From: Lukasz Lenart > >> To: Struts Developers List , > >> Date: 22.06.2017 15:36 > >> Subject: Struts

Re: Struts 2.5.11 test build is ready

2017-06-24 Thread [email protected]
t; >> From: Lukasz Lenart >> To: Struts Developers List , >> Date: 22.06.2017 15:36 >> Subject: Struts 2.5.11 test build is ready >> >> Hi, >> >> Please take a time and test the bits - any help is appreciated. Please >> report any pr

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Christoph Nenning
stoph > From: Lukasz Lenart > To: Struts Developers List , > Date: 22.06.2017 15:36 > Subject: Struts 2.5.11 test build is ready > > Hi, > > Please take a time and test the bits - any help is appreciated. Please > report any problems back. I'll call for vo

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Greg Huber
OK, great, switched to 3.6 and seems to work now. Cheers Greg. On 23 June 2017 at 09:15, Lukasz Lenart wrote: > Just notice that the Struts 2.5.11 is using Commons-Lang 3.6, maybe > this is the issue. > > 2017-06-23 10:04 GMT+02:00 Greg Huber : > > Getting a really strange me

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Greg Huber
Lukasz Lenart wrote: > > > >> Hi, > >> > >> Please take a time and test the bits - any help is appreciated. Please > >> report any problems back. I'll call for vote in a week if no problems > >> will be spotted. > >> > >> Staging Mav

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Lukasz Lenart
Just notice that the Struts 2.5.11 is using Commons-Lang 3.6, maybe this is the issue. 2017-06-23 10:04 GMT+02:00 Greg Huber : > Getting a really strange message testing this : > > >1. > > org.apache.commons.lang3.reflect.MethodUtils.getMethodsListWithAnnotation(Ljav

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Lukasz Lenart
> Hi, >> >> Please take a time and test the bits - any help is appreciated. Please >> report any problems back. I'll call for vote in a week if no problems >> will be spotted. >> >> Staging Maven repo >> https://repository.apache.org/content/

Re: Struts 2.5.11 test build is ready

2017-06-23 Thread Greg Huber
> Standalone artifacts > https://dist.apache.org/repos/dist/dev/struts/2.5.11/ > > Release notes > https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.11 > > > Thanks in advance > -- > Łukasz > + 48 606 323 122 http://www.lenart.org.pl/ > >

Struts 2.5.11 test build is ready

2017-06-22 Thread Lukasz Lenart
t/dev/struts/2.5.11/ Release notes https://cwiki.apache.org/confluence/display/WW/Version+Notes+2.5.11 Thanks in advance -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: [email protected]

Re: Struts 2.5.11 & 2.3.33

2017-06-22 Thread Lukasz Lenart
All issues related to 2.5 are resolved, I'm going to push a test package :) 2017-06-20 13:24 GMT+02:00 Yasser Zamani : > Fortunately I recognized the problem which causes that jasper report > issue. Please give it up to me and I'll come with a PR in coming a few > hours. > > On 6/19/2017 5:38 PM,

Re: Struts 2.5.11 & 2.3.33

2017-06-20 Thread Yasser Zamani
Fortunately I recognized the problem which causes that jasper report issue. Please give it up to me and I'll come with a PR in coming a few hours. On 6/19/2017 5:38 PM, Lukasz Lenart wrote: > Nice, please take a look on that issue with Jasper Reports, I think > it's not an issue as there is a fl

Re: Struts 2.5.11 & 2.3.33

2017-06-19 Thread Lukasz Lenart
Nice, please take a look on that issue with Jasper Reports, I think it's not an issue as there is a flag to switch back but maybe I'm missing something. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2017-06-19 15:05 GMT+02:00 Yasser Zamani : > Great! :) > > May I help you? I thin

Re: Struts 2.5.11 & 2.3.33

2017-06-19 Thread Yasser Zamani
Great! :) May I help you? I think I can pick that jasper report issue to work because I have experience whit jasper report a few years ago. However, also I am able to resolve others as you wish. On 6/18/2017 1:46 PM, Lukasz Lenart wrote: > There are only 4 issues left for 2.5 and we are good t

Struts 2.5.11 & 2.3.33

2017-06-18 Thread Lukasz Lenart
There are only 4 issues left for 2.5 and we are good to go. 2.3.33 can be released as well. https://issues.apache.org/jira/projects/WW/versions/12338701#release-report-tab-body Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/

Struts 2.5.11

2017-03-26 Thread Lukasz Lenart
Hi, I think it's time to prepare another test build, my intention is to get some preview of upcoming changes yet I don't assume it will be the final release. Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To un