Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-22 Thread Lukasz Lenart
2013/3/22 Christian Grobmeier : > Sorry for that. I will do it in future. Thanks for the hint! No problem :-) Cheers -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-22 Thread Christian Grobmeier
On Fri, Mar 22, 2013 at 8:55 AM, Lukasz Lenart wrote: > 2013/3/20 Christian Grobmeier : >> worked like a charm, thanks! > > I forget to mention about one thing, please add issue id in front of > commit message, thus will allow Jenkins to comment connected issue > after build and allow to check wha

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-22 Thread Lukasz Lenart
2013/3/20 Christian Grobmeier : > worked like a charm, thanks! I forget to mention about one thing, please add issue id in front of commit message, thus will allow Jenkins to comment connected issue after build and allow to check what was the reason for change, eg.: "WW-3778 Adds missing version

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-20 Thread Christian Grobmeier
worked like a charm, thanks! On Wed, Mar 20, 2013 at 9:38 AM, Lukasz Lenart wrote: > 2013/3/20 Christian Grobmeier : >> Ups, seems i can't update the issue (lack of permissions). If you can >> fix me, then I can fix the issue ;-) > > Try now > > > Regards > -- > Łukasz > + 48 606 323 122 http://w

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-20 Thread Lukasz Lenart
2013/3/20 Christian Grobmeier : > Ups, seems i can't update the issue (lack of permissions). If you can > fix me, then I can fix the issue ;-) Try now Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscri

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-20 Thread Christian Grobmeier
On Wed, Mar 20, 2013 at 9:29 AM, Lukasz Lenart wrote: > 2013/3/20 Christian Grobmeier : >> thanks! I just committed it, feel free to nag ;-) >> What is the process, can i go ahead and simply close this issue? >> https://issues.apache.org/jira/browse/WW-3778 >> Or is any other action to be taken? >

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-20 Thread Lukasz Lenart
2013/3/20 Christian Grobmeier : > thanks! I just committed it, feel free to nag ;-) > What is the process, can i go ahead and simply close this issue? > https://issues.apache.org/jira/browse/WW-3778 > Or is any other action to be taken? No, just mark it Fixed, they will be Closed with new release.

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-20 Thread Christian Grobmeier
On Tue, Mar 19, 2013 at 3:47 PM, Lukasz Lenart wrote: > 2013/3/18 Christian Grobmeier : >> One problem I face is now that it seems as view-success.jsp is not >> rendered. When I read the output of this file its always "". I have no >> idea why it's like that at the moment. >> I looked into StrutsJ

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-19 Thread Lukasz Lenart
2013/3/18 Christian Grobmeier : > I debugged a good while and figured out how it can be done, basically. > > The trick is, you give it a special config: > > @Override > protected String getConfigPath() { > return "struts-convention.xml"; > } > > This config above contains more or le

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-18 Thread Christian Grobmeier
rmation seulement et n'aura >> pas n'importe quel effet légalement obligatoire. Étant donné que les email >> peuvent facilement être sujets à la manipulation, nous ne pouvons accepter >> aucune responsabilité pour le contenu fourni. >> >> > From: lukaszlen

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-18 Thread Christian Grobmeier
From: lukaszlen...@apache.org >> Date: Sun, 17 Mar 2013 20:21:39 +0100 >> Subject: Re: Support for Convention-Plugin through the Junit-Plugin >> To: dev@struts.apache.org >> >> 2013/3/17 Christian Grobmeier : >> > hm, ok. I have seen the plugin should automatically b

RE: Support for Convention-Plugin through the Junit-Plugin

2013-03-17 Thread Martin Gainty
esponsabilité pour le contenu fourni. > From: lukaszlen...@apache.org > Date: Sun, 17 Mar 2013 20:21:39 +0100 > Subject: Re: Support for Convention-Plugin through the Junit-Plugin > To: dev@struts.apache.org > > 2013/3/17 Christian Grobmeier : > > hm, ok. I have s

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-17 Thread Lukasz Lenart
2013/3/17 Christian Grobmeier : > hm, ok. I have seen the plugin should automatically bring in these two > providers. > But when I call configurationManager.getContainerProviders() they are > not in. My guess is this is the problem. I will look a bit further > into it, more pointers are welcome :-)

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-17 Thread Christian Grobmeier
On Sun, Mar 17, 2013 at 1:50 PM, Lukasz Lenart wrote: > 2013/3/17 Christian Grobmeier : >> It says, it would be good to have the convention plugin supported by >> the junit plugin. I thought this should be the case already and did >> some testing on my local box: >> >> - added the convention plugi

Re: Support for Convention-Plugin through the Junit-Plugin

2013-03-17 Thread Lukasz Lenart
2013/3/17 Christian Grobmeier : > It says, it would be good to have the convention plugin supported by > the junit plugin. I thought this should be the case already and did > some testing on my local box: > > - added the convention plugin to my pom > - created content/hello-world.jsp in resources >

Support for Convention-Plugin through the Junit-Plugin

2013-03-17 Thread Christian Grobmeier
hi, today i did some improvements on the Junit plugin and saw this issue: https://issues.apache.org/jira/browse/WW-3778 It says, it would be good to have the convention plugin supported by the junit plugin. I thought this should be the case already and did some testing on my local box: - added t