Re: Building Struts

2005-02-20 Thread Martin Cooper
On Sat, 19 Feb 2005 15:04:34 -0500, James Mitchell <[EMAIL PROTECTED]> wrote: > That seems like quite a hack I'd be interested to hear why you feel this way. It's actually pretty much the exact scenario for which svn:externals were created, and, I think, somewhat more in line with the expected usa

DO NOT REPLY [Bug 33664] New: - ClassCastException: org.apache.struts.taglib.logic.IterateTei

2005-02-20 Thread bugzilla
DO NOT REPLY TO THIS EMAIL, BUT PLEASE POST YOUR BUGĀ· RELATED COMMENTS THROUGH THE WEB INTERFACE AVAILABLE AT . ANY REPLY MADE TO THIS MESSAGE WILL NOT BE COLLECTED ANDĀ· INSERTED IN THE BUG DATABASE. http://issues.apache.org/bugzilla/show_bu

Chain Conditionals (was Change Action, ActionForm to use ActionContext?)

2005-02-20 Thread Don Brown
Ah, we finally stumble onto the very slipperly slope that is conditional support for commons-chain. As we put more and more code into chain, we will inevitably have commands that only need to execute under certain conditions. There are three possibilities: 1. Bury conditional logic inside th

Re: Change Action, ActionForm to use ActionContext?

2005-02-20 Thread Don Brown
Well, I suppose interceptors could be viewed as a simplified, specific implementation of AOP, but I would hardly equate the two. If I had to draw a venn diagram, I'd have AOP and commons-chain (CoR) as two big circles overlaping at a place called interceptors. With commons-chain, you could cr

please unsubscribe me...

2005-02-20 Thread Shilpa Nalgonda
- To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: Chain Conditionals (was Change Action, ActionForm to use ActionContext?)

2005-02-20 Thread Dakota Jack
I find this discussion a bit confusing. Is this about the supplanting of implementation code of RequestProcessor with a chain? Is this about adding condition support in commons-chain to commons-chain or to Struts? I will assume the latter. Accordingly, I will assume that "chain" means "struts-c

Re: Chain Conditionals (was Change Action, ActionForm to use ActionContext?)

2005-02-20 Thread Dakota Jack
The point of the following, of course, in case someone has not looked at the code is: commands\AbstractAuthorizeAction.java(37): public abstract class AbstractAuthorizeAction implements Command { commands\AbstractCreateAction.java(37): public abstract class AbstractCreateAction implements Command

Re: Change Action, ActionForm to use ActionContext?

2005-02-20 Thread Shey Rab Pawo
Thanks, you are right on SAIF, of course. The Filter commands, I assume you would agree, are not really AOP either. Anyway, I was off on that suggestion. On Sun, 20 Feb 2005 10:39:03 -0800, Don Brown <[EMAIL PROTECTED]> wrote: > Well, I suppose interceptors could be viewed as a simplified, spec

svn commit: r154604 - in struts/flow/trunk/src/java/org/apache/struts/flow: core/ sugar/

2005-02-20 Thread mrdon
Author: mrdon Date: Sun Feb 20 18:13:38 2005 New Revision: 154604 URL: http://svn.apache.org/viewcvs?view=rev&rev=154604 Log: * Adding new sugar package to hold all JVM function extensions * Adding List and File function extensions * Adding a system to support runtime registration of function

svn commit: r154607 - struts/flow/trunk/src/java/org/apache/struts/flow/sugar/SugarWrapFactory.java

2005-02-20 Thread mrdon
Author: mrdon Date: Sun Feb 20 18:16:21 2005 New Revision: 154607 URL: http://svn.apache.org/viewcvs?view=rev&rev=154607 Log: * Fixed build error that snuck through Modified: struts/flow/trunk/src/java/org/apache/struts/flow/sugar/SugarWrapFactory.java Modified: struts/flow/trunk/src/jav

svn commit: r154615 - struts/flow/trunk/src/java/org/apache/struts/flow/core/JavaScriptInterpreter.java

2005-02-20 Thread mrdon
Author: mrdon Date: Sun Feb 20 18:48:51 2005 New Revision: 154615 URL: http://svn.apache.org/viewcvs?view=rev&rev=154615 Log: Removing most deprecations Modified: struts/flow/trunk/src/java/org/apache/struts/flow/core/JavaScriptInterpreter.java Modified: struts/flow/trunk/src/java/org/apa

Re: Building Struts

2005-02-20 Thread James Mitchell
Well, maybe not a 'hack' in the true sense of the word ;), but it will be weird having to commit and 'svn up' any change made in build/ to see it locally in the svn:external-ized build/ locations. I know that won't have to happen very often once we are stable again, but it will cause a lot of conf

Re: Chain Conditionals (was Change Action, ActionForm to use ActionContext?)

2005-02-20 Thread Dakota Jack
Whenever there are conditional choices between classes, as with those implementing Comparator, shouldn't we favor polymophism as an OOP solution rather than some procedural solution? Last word unless requested otherwise on this: just trying to be helpful. The five options below are all procedural

svn commit: r154644 - in struts/flow/trunk: ./ src/java/org/apache/struts/flow/sugar/ src/test/ src/test/org/ src/test/org/apache/ src/test/org/apache/struts/ src/test/org/apache/struts/flow/ src/test/org/apache/struts/flow/sugar/

2005-02-20 Thread mrdon
Author: mrdon Date: Sun Feb 20 22:52:04 2005 New Revision: 154644 URL: http://svn.apache.org/viewcvs?view=rev&rev=154644 Log: * Adding a very simple Javascript junit implementation * Adding tests for the List and Map wrappers * Adding tests for File and List extension functions * Fixing errors