Re: [VOTE] Retain the "!" idiom but disable it by default

2006-08-26 Thread tm jee
I'd prefer it to be turn off by default. I normally use an extra action alias instead of "foo!bar". As for cancel action, I'd normally use and have an action alias "purchaseCancel" which could be using the same action class but with a different method defined in the struts xml file. instead

Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]

2006-08-26 Thread Paul Benedict
Wendy Smoak wrote: OK, then the only other thing I'd suggest is to work this into one of the example apps, and update the relevant part of the website documentation, before closing the issue. Sure; I have one half-baked already and will finish that up. When do you think it is appropriate then

Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]

2006-08-26 Thread Ted Husted
On 8/26/06, Wendy Smoak <[EMAIL PROTECTED]> wrote: OK, then the only other thing I'd suggest is to work this into one of the example apps, and update the relevant part of the website documentation, before closing the issue. I'd suggest adding something to the new cookbook application that demon

Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]

2006-08-26 Thread Wendy Smoak
On 8/26/06, Paul Benedict <[EMAIL PROTECTED]> wrote: Sure; I have one half-baked already and will finish that up. As Ted mentioned, a module in the Cookbook app would be great... does that work with what you have? When do you think it is appropriate then to commit the code to struts-core?

SVN access question

2006-08-26 Thread Paul Benedict
I tried to connect via HTTPS and got this message. (I omitted some parts.) Is it normal? Error validating server certificate for https://svn.apache.org:443: - Unknown certificate issuer Fingerprint: 19:51: Distinguished name: http://..., Scottsdale, Arizona, US Paul

Re: SVN access question

2006-08-26 Thread Wendy Smoak
On 8/26/06, Paul Benedict <[EMAIL PROTECTED]> wrote: I tried to connect via HTTPS and got this message. (I omitted some parts.) Is it normal? Error validating server certificate for https://svn.apache.org:443: - Unknown certificate issuer Fingerprint: 19:51: Distinguished name: ht

Patch all or individual commits?

2006-08-26 Thread Paul Benedict
I hope everyone doesn't mind putting up with my newbie committer questions. They will hopefully come to the end soon :-) I committed one file and that turned out fine. So now my question is: when you have X files you want to check-in, do we have any policy here on the expected way of doing it?

Re: Patch all or individual commits?

2006-08-26 Thread Martin Cooper
On 8/26/06, Paul Benedict <[EMAIL PROTECTED]> wrote: I hope everyone doesn't mind putting up with my newbie committer questions. They will hopefully come to the end soon :-) I committed one file and that turned out fine. So now my question is: when you have X files you want to check-in, do we h

Re: Patch all or individual commits?

2006-08-26 Thread Wendy Smoak
On 8/26/06, Paul Benedict <[EMAIL PROTECTED]> wrote: I hope everyone doesn't mind putting up with my newbie committer questions. They will hopefully come to the end soon :-) I committed one file and that turned out fine. So now my question is: when you have X files you want to check-in, do we h

Re: Patch all or individual commits?

2006-08-26 Thread Paul Benedict
Wendy Smoak wrote: Also, remember to refer to the issue number in the commit message so it will automatically show up on the 'Subversion Commits' tab in JIRA Do you have an example commit message? If there's a special format, please let me know. PS: When this is all done, I should probably c

Re: [Fwd: [jira] Updated: (STR-2864) Add actionId attribute to action mapping]

2006-08-26 Thread Paul Benedict
To employ uniqueness checking of an actionId, I added to addActionConfig. That method currently overwrites any actionConfigs that are duplicate -- the last one is the winner. Should I take the same approach for duplicate ids? Or should I throw an exception on duplication? I'd like some guidance

Re: Patch all or individual commits?

2006-08-26 Thread Wendy Smoak
On 8/26/06, Paul Benedict <[EMAIL PROTECTED]> wrote: Wendy Smoak wrote: > Also, remember to refer to the issue number in the commit message so > it will automatically show up on the 'Subversion Commits' tab in JIRA Do you have an example commit message? If there's a special format, please let m

Duplicate action ids - how to handle?

2006-08-26 Thread Paul Benedict
I will add this to the comments of STR-2864 when finished. Please answer the following question if you have opinion about this: To employ uniqueness checking of an actionId, I added to ModuleConfigImpl.addActionConfig. That method currently overwrites any action configs that are duplicate -- t