Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/17, Piero Sartini <[EMAIL PROTECTED]>: > > After looking at the code the problem is within Component.java. > > The determineActionURL method has 2 new parameters which were not present > in > 2.0.9 and are passed to UrlHelper.java: > boolean forceAddSchemeHostAndPort, boolean escapeAmp It

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/14, James Holmes <[EMAIL PROTECTED]>: > [X] Alpha +1 to Alpha with the following note: The "org.apache.struts2.components.Component.determineActionURL" protected method has changed, with no deprecation of the old signature. This problem was noted by Piero Sartini. Antonio P.S.: I don't kn

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Piero Sartini
Am Montag 17 September 2007 09:28:15 schrieb Antonio Petrelli: > > Anyway, since 2.0.10 fixes a security issue: Would it be good to have a > > method in Component.java that is compatible with 2.0.9? Maybe tagged > > as @Deprecated? > > Good question: it depends on how the method is used: in the co

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Ted Husted
Without looking at the code, it sounds like we might be able to add a backwardly-compatible signature, and deprecate the former. If that can be done, we could re-tag .10 and try again. Anyone up for the patch? -Ted. On 9/16/07, Piero Sartini <[EMAIL PROTECTED]> wrote: > After looking at the code

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Ted Husted
On 9/17/07, Antonio Petrelli <[EMAIL PROTECTED]> wrote: > I am -1 to retagging, since the JAR already went out to the public, and it > will be a mess for the support. As Wendy (Smoak) said, what happens when > someone asks support for 2.0.10? "Which 2.0.10 have you got?" It would be just as easy t

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/17, Ted Husted <[EMAIL PROTECTED]>: > > Without looking at the code, it sounds like we might be able to add a > backwardly-compatible signature, and deprecate the former. If that can > be done, we could re-tag .10 and try again. Anyone up for the patch? I am -1 to retagging, since the JAR

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Antonio Petrelli
2007/9/17, Piero Sartini <[EMAIL PROTECTED]>: > Am Montag 17 September 2007 09:28:15 schrieb Antonio Petrelli: > > > Anyway, since 2.0.10 fixes a security issue: Would it be good to have a > > > method in Component.java that is compatible with 2.0.9? Maybe tagged > > > as @Deprecated? > > > > Good

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread James Holmes
I fixed the problem on the 2.0.X branch. Not sure if that was the right place to do it, but it's done. I created this issue when I worked on some tickets for the 2.0.10 release. At the time I overlooked the fact that it was a protected method and I was changing the API. My bad. Everything should

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Piero Sartini
> Piero: it seems that we agreed on the fact that the change should add > a deprecation: can you open a JIRA issue for this? > Eventually you can provide the patch, so your name will appear in the > SVN log :-) I created a JIRA entry with attached patch: https://issues.apache.org/struts/browse/WW-

s:include tag

2007-09-17 Thread Sairam01
I'm unable to include a jsp dynamically. The include tag doesn't evaluate VALUE the expression. someName is a attribute on my action code. Should this work..? -- View this message in context: http://www.nabble.com/s%3Ainclude-tag-tf4469750.html#a12744368 Sent from the Struts - Dev mailing li

Re: [VOTE] Struts 2.0.10 Quality

2007-09-17 Thread Ted Husted
On 9/17/07, James Holmes <[EMAIL PROTECTED]> wrote: > I fixed the problem on the 2.0.X branch. Not sure if that was the right place > to > do it, but it's done. Yep, that's right. We don't need any more branches :) > I created this issue when I worked on some tickets for the 2.0.10 release. At

Re: [OT] Re: Should I announce SmartURLs or wait?

2007-09-17 Thread Ted Husted
I was just wondering if it would make any sense to at least add SmartURL-type ActionName and ActionNames annotations to the 2.0.x core, so as to finish what we started with the validation and result annotations. We probably don't need to get into exception and interceptor annotations for 2.0, but A

Re: write access to the wiki

2007-09-17 Thread Ted Husted
Thanks for following up, Wes. You should be all set now. Thanks for volunteering! On 9/12/07, Wes Wannemacher <[EMAIL PROTECTED]> wrote: > Hello, > > I would like to help update some of the wiki docs. I submitted the CLA a > while back. I believe my email address ([EMAIL PROTECTED]) is my confluen

Help with the @Inject Annotation

2007-09-17 Thread Chris Pratt
I'm attempting to understand the @Inject Annotation and how it can be used. I'm trying to create a tag library that needs to look up action data, so following the pattern from the FormTag I added this methods to my tag class: private boolean enableDynamicMethodInvocation = true; private Confi