Re: Increasing distribution size [was: Re: Fileupload depende...]

2008-01-20 Thread Al Sutton
My view; If the s:file tag is available from the core jars we need to ship the dependencies to support it. If we put on the website the S2 core does something then it should do it out of the box, it shouldn't be a "Oh, it does half the stuff, but hey, we couldn't be bothered to roll in the dep

Re: Struts 2.1.1 Release Planning

2008-01-20 Thread Al Sutton
Thanks for the pointer, but I've already created patches. I think Ted wants someone to help merge them in which is why I'm looking for some docs (that is unless Ted says "Sure... throw me some more patches" :)). Al. - Original Message - From: "Martin Cooper" <[EMAIL PROTECTED]> To:

Re: [S2.1] Does struts2-core include Dojo code?

2008-01-20 Thread Al Sutton
And from looking in the pom.xml I would say it definitely doesn't. Al. - Original Message - From: "Don Brown" <[EMAIL PROTECTED]> To: "Struts Developers List" Sent: Friday, January 18, 2008 12:27 PM Subject: Re: [S2.1] Does struts2-core include Dojo code? It shouldn't... Don On 1

Jar clash in the maven build

2008-01-20 Thread Al Sutton
Just to make things more interesting we have entered jar hell :(. Maven is picking up struts-annotations which has a freemarker-2.3.4 dependency and inserting it into the classpath before the S2.1 specified 2.3.11 dependency thus giving a compile and run classpath of; m2\repository\f

More Jar clashes in core

2008-01-20 Thread Al Sutton
We've got velocity 1.4 & velocity 1.5 from these two places; A couple down the chain dependencies are using velocity We're using org.apache.velocity and we've also got Struts-1.2.9 directly included as a dependency from velocity-tools-1.3 using struts and we're using org.apache.struts.

[S2] - FilterDispatcher and ActionContextCleanup (WW-2240 FileUploadInterceptor causes null pointer exception)

2008-01-20 Thread Nils-Helge Garli Hegvik
Hi! I've been debugging WW-2240 (had to install WebLogic 10 to reproduce it) and have seen some strange behavior (at least I think so) in the ActionContext initialization and cleanup performed by the FilterDispatcher. The problem is that the cleanup of the ActionContext (ActionContext.setConte

Re: Struts 2.1.1 Release Planning

2008-01-20 Thread Wes Wannemacher
On Fri, 2008-01-18 at 14:50 +, Al Sutton wrote: > Thanks for the pointer, but I've already created patches. > > I think Ted wants someone to help merge them in which is why I'm looking for > some docs (that is unless Ted says "Sure... throw me some more patches" :)). > > Al. > I wouldn't

Re: Jar clash in the maven build

2008-01-20 Thread James Mitchell
Well, that's not exactly what will happen. Core pulls in freemarker 2.3.11, but labels annotations as optional, which means it will not include 2.3.4 (through transitive dependence). But regardless, you are right, they need to be the same. On Jan 20, 2008 5:03 AM, Al Sutton <[EMAIL PROTECTED]>

Re: Jar clash in the maven build

2008-01-20 Thread Wendy Smoak
On Jan 20, 2008 3:03 AM, Al Sutton <[EMAIL PROTECTED]> wrote: > Just to make things more interesting we have entered jar hell :(. > > Maven is picking up struts-annotations which has a freemarker-2.3.4 > dependency and inserting it into the classpath before the S2.1 specified > 2.3.11 dependency th

Re: More Jar clashes in core

2008-01-20 Thread James Mitchell
I wouldn't worry about what other projects have. What ultimately happens (like OO) is the top most dependency declaration wins. This means you can override anything that a dependent project thinks it needs. Dependency management can be a nightmare if projects that are outside of your control do

Re: Jar clash in the maven build

2008-01-20 Thread Al Sutton
Thanks Wendy, I've tried to raise a MEV, but when I click new all I get is the search bar. Does the JIRA for Maven require users to have a login :(. - Original Message - From: "Wendy Smoak" <[EMAIL PROTECTED]> To: "Struts Developers List" Sent: Sunday, January 20, 2008 4:54 PM Subje

Re: More Jar clashes in core

2008-01-20 Thread Al Sutton
I think you've missed the point. Because the groupIds are different both sets of jars are included by maven during compiling and testing, because maven thinks both jars are for different packages. I can confirm this is the case by running maven in debug mode and analyzing the output. Now,

Re: More Jar clashes in core

2008-01-20 Thread James Mitchell
Sorry if something I said pissed you off. Those should be brought to the same version: org.freemarker freemarker 2.3.11 On Jan 20, 2008 2:37 PM, Al Sutton <[EMAIL PROTECTED]> wrote: > I think you've missed the point. > > Because the groupId