Need verification of complex patch

2008-06-18 Thread Kristian.Rosenvold
I have a patch for http://jira.opensymphony.com/browse/XW-604 and another issue that i am experiencing. The patch somewhat changes the behaviour of the exception flow and I would like a small review: Problem I am fixing: DefaultActionInvocation.invoke() invokes entire interceptor chain and calls

Re: Need verification of complex patch

2008-06-18 Thread Rainer Hermanns
Kristin, could you please attach this as unified patch to the related Jira issue? I'll look into this during the week and apply the patch, if everything is working properly. It would be very helpful, if you have a unit test available, that verifies the correct behaviour. thanks, Rainer > I have

SV: Need verification of complex patch

2008-06-18 Thread Kristian.Rosenvold
I will submit a patch and a testcase once I find out why this fix breaks the "Infinte Recursion Detection" block in ActionChainResult line 206. Everything else seems ok. I simply get a white screen with no response if I infinitely chain to the same action. I am a bit at loss on this one. Anyone h

Re: [S2] trunk build broken since last fix (again)

2008-06-18 Thread Rainer Hermanns
Don, I have a "workaround" fix for the failing build, that I justed commited, but this needs to be reviewed again... o fixing build by commenting "old" constructor in StrutsSpringObjectFactory o adding missing param to struts-plugin.xml in portlet-plugin cheers, Rainer > On Wed, Jun 18, 2008 a