Re: svn commit: r802949 - /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java

2009-08-11 Thread Mathias Bogaert
Small naming comment; isn't clearTemplateCache a better name instead of clearTemplatesCache? Mathias On Tue, Aug 11, 2009 at 12:40 AM, wrote: > Author: musachy > Date: Mon Aug 10 22:40:51 2009 > New Revision: 802949 > > URL: http://svn.apache.org/viewvc?rev=802949&view=rev > Log: > WW-3189 add a

Seeking reflections on our tag library (as a framework)

2009-08-11 Thread Don Brown
At Atlassian, every application seems to have picked a different web framework and template engine to use. As we are finally starting to do some common UI work, I'm wondering if the Struts 2 tag library framework is worth basing our tag library on. Assume it wouldn't be too hard to extract mostly

Re: Seeking reflections on our tag library (as a framework)

2009-08-11 Thread Wes Wannemacher
Don, As you know, there are many aspects to the taglib that make it interesting. One big thing that you mention is the use of the tobago plugin to generate the TLDs and marking parameters as attributes with an annotation. I'm guessing this was done at some point to make the taglib more manageable,

Re: Seeking reflections on our tag library (as a framework)

2009-08-11 Thread Obinna
I've worked with the struts tags a bunch in extending them for application specific purposes (injecting authorization controls to disable components), developing custom themes, and in developing an ajax framework extending these tags and though I am very happy with the tag library in general, there

Re: svn commit: r802949 - /struts/struts2/trunk/core/src/main/java/org/apache/struts2/components/template/FreemarkerTemplateEngine.java

2009-08-11 Thread Musachy Barroso
yes it is, feel free to change it. musachy On Tue, Aug 11, 2009 at 2:34 AM, Mathias Bogaert wrote: > Small naming comment; isn't clearTemplateCache a better name instead > of clearTemplatesCache? > > Mathias > > On Tue, Aug 11, 2009 at 12:40 AM, wrote: >> Author: musachy >> Date: Mon Aug 10 22:4

Re: Let's kill xwork (was Re: 2.1.8 release?)

2009-08-11 Thread Brian Pontarelli
On Aug 10, 2009, at 11:52 PM, Don Brown wrote: On Tue, Aug 11, 2009 at 3:38 PM, Paul Benedict wrote: On Tue, Aug 11, 2009 at 12:22 AM, Don Brown wrote: By forking XWork, we can a) bring core Struts 2 code into the project where it belongs and b) still leave it available for other users

bug On struts1: MessageResources.getMessage locale , whether has the problem?

2009-08-11 Thread 3844370
On struts1: MessageResources.getMessage(Locale locale, String key, Object[] args) , don't use client's locale to format ! for example: my webApp has a myResources_en_US.properties : test =your money is {0, number, currency} client's locale is en_US, server's locale is zh_CN my

Re: Seeking reflections on our tag library (as a framework)

2009-08-11 Thread Musachy Barroso
Like Eric said, one of the things that I dislike about the current tags is the inheritance of the attributes. Out tags for the tld generation have ways to hack around that problem, but it still smells. About the java templates, I would have liked a DOM-like approach better, but it is personal pref

Re: Let's kill xwork (was Re: 2.1.8 release?)

2009-08-11 Thread Musachy Barroso
On Tue, Aug 11, 2009 at 9:55 AM, Brian Pontarelli wrote: > Maybe its time to branch Struts core, drop in xwork, refactor the heck out > of it, and call it struts 3. Code name the release "Phoenix". :) "Do you smell that? It's napalm, son. Nothing else on the world smells like that . I love the sme