Re: svn commit: r1096838 - in /struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher: ServletActionRedirectResult.java ServletRedirectResult.java

2011-04-27 Thread Rene Gielen
Johannes, could you review your IDE settings? Seems like it tries to reformat every code entity you commit, which both causes a bad signal / noise ratio for the actual change and some new coding style that I'm not sure we want to introduce in general (such as opening block brackets on a new line).

Re: svn commit: r1096838 - in /struts/struts2/trunk/core/src/main/java/org/apache/struts2/dispatcher: ServletActionRedirectResult.java ServletRedirectResult.java

2011-04-27 Thread Johannes Geppert
Done. I have disabled the Source Code Formating in my Eclipse Save Actions. Johannes - -- web: http://www.jgeppert.com twitter: http://twitter.com/jogep -- View this message in context: http://struts.1045723.n5.nabble.com/Re-svn-commit-r1096838-in-struts-struts2-trunk-core-src-

Re: JSON Content Type

2011-04-27 Thread Johannes Geppert
I figured out that the json plugin returns as Content Type correctly application/json. So I change the JSON Content Handler in the Rest Plugin to set the Content Type also to application/json. Johannes - -- web: http://www.jgeppert.com twitter: http://twitter.com/jogep -- View th

Minor patch (dead code in plaintextresult)

2011-04-27 Thread Christian Grobmeier
HI, In PlainTextResult had a bit dead code. Attached is a small patch which fixes that. It working now, but it could be more optimal: no need to create inputstreams if the getResourceAsStream returns null. But this should be the exception anyway. Cheers, Christian ### Eclipse Workspace Patch 1.0

Re: Minor patch (dead code in plaintextresult)

2011-04-27 Thread Maurizio Cucchiara
Hi Christian, could you file an issue on JIRA with the attached patch? After that I'm pretty sure that someone will take care of applying your patch (there doesn't seem to be any reason to object) On 27 April 2011 16:53, Christian Grobmeier wrote: > > HI, > > In PlainTextResult had a bit dead cod

Re: Minor patch (dead code in plaintextresult)

2011-04-27 Thread Maurizio Cucchiara
I forgot to send the address https://issues.apache.org/jira/browse/WW On 27 April 2011 17:18, Maurizio Cucchiara wrote: > Hi Christian, > could you file an issue on JIRA with the attached patch? > After that I'm pretty sure that someone will take care of applying > your patch (there doesn't seem

Error in REST Showcase

2011-04-27 Thread Johannes Geppert
I get following Error when I try out the Detail View in the REST Showcase: http://localhost:8080/struts2-rest-showcase/orders/3 org.apache.struts2.rest.DefaultHttpHeaders cannot be cast to java.lang.String RequestURI=/struts2-rest-showcase/orders/3 Caused by: java.lang.ClassCastException: org.a

Re: [VOTE] Release Struts 2.2.3

2011-04-27 Thread Rene Gielen
I would have wanted to spend a little more time on testing it, but from what I can say it looks good, and Matt's performance issue seems to be non-blocking - nevertheless we should keep an eye on it. Hopefully more PMC members find some time to test the build the next couple of days? +1 GA (bindi

Re: [VOTE] Release Struts 2.2.3

2011-04-27 Thread Dave Newton
I lost my internet at home temporarily--I may try to kick of a build tonight at work. Dave On Wed, Apr 27, 2011 at 4:29 PM, Rene Gielen wrote: > I would have wanted to spend a little more time on testing it, but from > what I can say it looks good, and Matt's performance issue seems to be > non-