Re: processing of multipart request

On Tue, Nov 20, 2012 at 6:30 PM, Fastupload wrote: > Lukasz, > > can you do me a favour to give me a reference about creation of struts > JIRA ticket and how to commit patch? > I strongly recommend that you read the Struts web site. In particular, look through the "Development" section in the na

Removing setId in ContextBean & others

Hi, while fixing a comment in org.apache.struts2.components.Set, I came across a TODO: TODO: set required=true when 'id' is dropped after 2.1 ContextBean does provide setId, but delegate to setVar with the TODO "remove after 2.1". Well, 2.1 is history :-) Does anybody mind if I would remove se

Re: Removing setId in ContextBean & others

That sounds like a better candidate for 2.5 or 3.0, since it would be a breaking change. (*Chris*) On Wed, Nov 21, 2012 at 10:11 AM, Christian Grobmeier wrote: > Hi, > > while fixing a comment in org.apache.struts2.components.Set, I came > across a TODO: > > TODO: set required=true when 'id' i

Re: Removing setId in ContextBean & others

Makes sense. >From the development process, should I commit to a branch then? Like for example: http://svn.apache.org/viewvc/struts/struts2/branches/STRUTS_3_X/ or, if we agree, to a 2.5 branch? Thanks On Wed, Nov 21, 2012 at 7:15 PM, Chris Pratt wrote: > That sounds like a better candidate fo

Jenkins build is still unstable: Struts2-JDK7 » Portlet Webapp #3

See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Build failed in Jenkins: Struts2-JDK7 » Struts 2 GXP Plugin #3

See -- projectStarted org.apache.struts:struts2-gxp-plugin:2.3.8-SNAPSHOT [INFO] Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/mave

Jenkins build is still unstable: Struts2-JDK7 » Struts 2 Sitegraph Plugin #3

See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Build failed in Jenkins: Struts2-JDK5 » Struts 2 Core #2

See Changes: [grobmeier] fixed typo [grobmeier] Example should not use deprecated attributes. Added example showing evaluation of tag body -- projectStarted org.apache

Build failed in Jenkins: Struts2-JDK5 #2

See Changes: [grobmeier] fixed typo [grobmeier] Example should not use deprecated attributes. Added example showing evaluation of tag body -- [...truncated 9758 lines...] mojoSucceeded org.apache.mav

Re: Fwd: Build failed in Jenkins: Struts2-JDK7 #3

Your javadoc changes did not break the build, as much as they didn't fix it. The build was never successful so far: https://builds.apache.org/job/Struts2-JDK7/ - René Christian Grobmeier schrieb: >Oh dear... can anybody advise? >I really just updated the javadoc of a class. Not sure why GxPI

Re: Fwd: Build failed in Jenkins: Struts2-JDK7 #3

Looks pretty easy - public static GxpInstance getInstance(Class gxpClass) in GxpInstance.java clashes with - public static Gxp getInstance(Class gxpClass) In Gxp (which GxpInstance derives). GxpInstance needs to probably override getInstance(...). I don't know enough about the GXP plugin to say

Re: Fwd: Build failed in Jenkins: Struts2-JDK7 #3

On Wed, Nov 21, 2012 at 8:20 PM, Rene Gielen wrote: > Your javadoc changes did not break the build, as much as they didn't fix it. > The build was never successful so far: > https://builds.apache.org/job/Struts2-JDK7/ Ah. Makes me feel much more comfortable. Thx! Cheers Christian > - René > >

Re: Removing setId in ContextBean & others

2012/11/21 Christian Grobmeier : > Makes sense. > > From the development process, should I commit to a branch then? > > Like for example: > http://svn.apache.org/viewvc/struts/struts2/branches/STRUTS_3_X/ > or, if we agree, to a 2.5 branch? I think we must prepare some plan :-) Regards -- Łukas

Re: The Master Plan

2011/12/9 Łukasz Lenart : > Cleaned up! > > I identified around 55 issues to be solved for 2.3.x branch (should be > double checked) and 191 affecting 2.5 (aka S3). > > Right now, I would like to wait till 2.3.1 Vote finish before we will > start talking / thinking about 2.5. In mean time we can st

Re: The Master Plan

And we must decide if we like to start with S2.5 or S3. :-) Do we need a Vote? Johannes # web: http://www.jgeppert.com twitter: http://twitter.com/jogep 2012/11/21 Lukasz Lenart > 2011/12/9 Łukasz Lenart : > > Cleaned up! > > > > I identifie

Jenkins build is unstable: Struts2-JDK5 » Struts 2 Core #3

See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Build failed in Jenkins: Struts2-JDK5 » Struts 2 GXP Plugin #3

See -- projectStarted org.apache.struts:struts2-gxp-plugin:2.3.8-SNAPSHOT Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-plugin/maven-metad

Build failed in Jenkins: Struts2-JDK5 » Struts 2 Embedded JSP Plugin #3

See -- projectStarted org.apache.struts:struts2-embeddedjsp-plugin:2.3.8-SNAPSHOT Downloading: http://repo1.maven.org/maven2/org/apache/maven/plugins/maven-idea-pl

Re: Fwd: Build failed in Jenkins: Struts2-JDK7 #3

2012/11/21 Christian Grobmeier : > On Wed, Nov 21, 2012 at 8:20 PM, Rene Gielen wrote: >> Your javadoc changes did not break the build, as much as they didn't fix it. >> The build was never successful so far: >> https://builds.apache.org/job/Struts2-JDK7/ > > Ah. Makes me feel much more comfortab

Re: Fwd: Build failed in Jenkins: Struts2-JDK7 #3

2012/11/21 Lukasz Lenart : > I removed dev@struts.a.o from these builds, only committer will get > the error message. Right now I'm working on that Just one failing test left to run properly on JDK7: Tests in error: testWebFlow(org.apache.struts2.sitegraph.SiteGraphTest) Regards -- Łukasz +

Fwd: Build failed in Jenkins: Struts2-JDK5 » Struts 2 GXP Plugin #4

Hi, There are two problems to build Struts 2 on JDK5, first is the GXP which was build on JDK6 and classes aren't compliant and the second is the embeddedjsp plugin which uses classes introduced with Java 1.6 My idea to solve these problems is to move them out to sandbox - where they can still be

Re: The Master Plan

2012/11/21 Johannes Geppert : > And we must decide if we like to start with S2.5 or S3. :-) > > Do we need a Vote? I think with should name it S3, see Paul's explanation http://markmail.org/message/jtlqh6xfwix5cjbn And I don't think we need a Vote to start working on something new :-) Regards -

Re: The Master Plan

2012/11/21 Lukasz Lenart : > I would like to follow the idea to start development of 2.5 in trunk. I was wrong, the plan for Struts 3 is to use Git repo :-) Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To uns

Re: The Master Plan

Don't all master plans need to end with an evil laugh? On Nov 22, 2012 1:06 AM, "Lukasz Lenart" wrote: > 2012/11/21 Lukasz Lenart : > > I would like to follow the idea to start development of 2.5 in trunk. > > I was wrong, the plan for Struts 3 is to use Git repo :-) > > > Regards > -- > Łukasz >

Re: The Master Plan

2012/11/22 Paul Benedict : > Don't all master plans need to end with an evil laugh? Right :D :D :D Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For ad

Re: The Master Plan

Just to close this discussion: The new version of Struts should be called Struts 3, does anyone disagree ? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.or