Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Lukasz Lenart
2015-09-01 12:41 GMT+02:00 Greg Huber : > The same way interceptors are configured, something like: > > publish* > > public String publish() {..} > public String publishNow() {..} but maybe instead of such simple definition it'd be better to allow specify very strict regex, ie: regex:publish(([A-

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Greg Huber
Probably a good idea to be strict, but I have lots of methods, only use DMI, so it may get to be a very long element. Maybe I could prefix all my required methods with something, ie with allowedPublish() allowedPublishNow() etc and use : regex:allowed(([A-Z]?)([a-z]+)?) I previously added a sa

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Greg Huber
Maybe public methods and by package name? mypackage.com regex:(([A-Z]?)([a-z]+)?) On 2 September 2015 at 08:09, Lukasz Lenart wrote: > 2015-09-01 12:41 GMT+02:00 Greg Huber : > > The same way interceptors are configured, something like: > > > > publish* > > > > public String publish() {..} > >

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Christoph Nenning
In my apps I would not need to use any patterns. Just a list of methods, different for each action, would be enough for me. What do you think about a config switch to enable/disable patterns for strict-dmi-method-names ? Reagards, Christoph > From: Lukasz Lenart > To: Struts Developers

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Lukasz Lenart
2015-09-02 9:55 GMT+02:00 Greg Huber : > Probably a good idea to be strict, but I have lots of methods, only use > DMI, so it may get to be a very long element. > > Maybe I could prefix all my required methods with something, ie with > allowedPublish() allowedPublishNow() etc > > and use : > > rege

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Lukasz Lenart
2015-09-02 10:01 GMT+02:00 Greg Huber : > Maybe public methods and by package name? > > mypackage.com > regex:(([A-Z]?)([a-z]+)?) It will complicate few other things as evaluation of allowed methods happens on mapping, very early in processing Regards -- Ɓukasz + 48 606 323 122 http://www.lenar

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Lukasz Lenart
2015-09-02 10:18 GMT+02:00 Christoph Nenning : > In my apps I would not need to use any patterns. Just a list of methods, > different for each action, would be enough for me. per or per > What do you think about a config switch to enable/disable patterns for > strict-dmi-method-names ? Origi

Re: [GitHub] struts pull request: WW-4540: Strict DMI

2015-09-02 Thread Christoph Nenning
> > In my apps I would not need to use any patterns. Just a list of methods, > > different for each action, would be enough for me. > > per or per > That is great! Still looking forward to annotations, at least for actions :) > > What do you think about a config switch to enable/disabl