Build failed in Jenkins: Struts-JDK6-support-2.3 #968

See Changes: [cnenning] WW-4599: backport JSONActionRedirectResult to struts 2.3 [cnenning] made methods non static and private, javadoc updates [cnenning] increased visibilty of methods and constants for better extensibility

Jenkins build is back to normal : Struts-JDK6-support-2.3 #969

See - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

Re: Upgrade to tiles 3 jcl-over-slf4j

> Should jcl-over-slf4j be in the tiles-core pom? > I see that it is currently the case but I do not need it. > > slf4j-jcl is used to delegate all SLF4J logging to Commons Logging. > > ​and then log4j-jcl to delegate all to Commons Logging to log4j 2 SLF4J can be forwarded to log4j 2 direct

Build failed in Jenkins: Struts-JDK8-master #86

See Changes: [cnenning] turned @AllowedMethods into String[] -- [...truncated 90616 lines...] [INFO] skip non existing resourceDirectory

Re: Upgrade to tiles 3 jcl-over-slf4j

Well, I currently log with commons, but to get struts logging working I have had to upgrade to v2 and use the log4j2.xml file. Also a good idea to bypass the commons for slf4j and go directly. Cheers Greg On 29 January 2016 at 15:07, Christoph Nenning < christoph.nenn...@lex-com.net> wrote: >

RE: Upgrade to tiles 3 jcl-over-slf4j

Hi Greg- can you confirm these dependencies for log4j? org.apache.logging.log4j log4j-api 2.5 org.apache.logging.log4j log4j-core 2.5 junit junit 4.9 test Thanks! Martin ___

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/85#discussion_r51284673 --- Diff: apps/showcase/src/main/java/org/apache/struts2/showcase/tiles/TilesAnnotationsAction.java --- @@ -0,0 +1,21 @@ +package org.apache.struts2.

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/85#discussion_r51284785 --- Diff: apps/showcase/src/main/java/org/apache/struts2/showcase/tiles/TilesAnnotationsAction.java --- @@ -0,0 +1,21 @@ +package org.apache.struts2.

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/85#discussion_r51285002 --- Diff: plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java --- @@ -111,6 +133,31 @@ public void doExecute(String location, Act

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/85#discussion_r51284943 --- Diff: plugins/tiles/src/main/java/org/apache/struts2/views/tiles/TilesResult.java --- @@ -99,6 +109,18 @@ public TilesResult(String location) {

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/85#discussion_r51285068 --- Diff: plugins/tiles/src/test/java/org/apache/struts2/tiles/StrutsTilesAnnotationProcessorTest.java --- @@ -0,0 +1,148 @@ +package org.apache.stru

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/85#discussion_r51285182 --- Diff: plugins/tiles/src/test/java/org/apache/struts2/tiles/TilesTestActionSingleAnnotation.java --- @@ -0,0 +1,49 @@ +package org.apache.struts2.

[GitHub] struts pull request: WW-4594: Configure TilesDefs by annotating Ac...

Github user lukaszlenart commented on the pull request: https://github.com/apache/struts/pull/85#issuecomment-176859924 Left some minor comment, this looks solid, great job! --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well.

Re: Upgrade to tiles 3 jcl-over-slf4j

Why not log4j2? Cheers, Paul On Fri, Jan 29, 2016 at 10:48 AM, Martin Gainty wrote: > Hi Greg- > > can you confirm these dependencies for log4j? > > > org.apache.logging.log4j > log4j-api 2.5 > > org.apache.logging.log4j > log4j-core 2.5 > junit > junit

Re: Upgrade to tiles 3 jcl-over-slf4j

Yes, if you are logging directly to log4j2 but if other jars use slf4j you need to delegate the logging (create a log4j2.xml if upgrading from v1, note the format is also different!) org.slf4j slf4j-api 1.7.14 org.apache.logging.log4j

Re: Upgrade to tiles 3 jcl-over-slf4j

I plan to, but not really motivated at the moment as its quite a job converting all my poorly formatted logging to use the new format. Cheers Greg btw does any body know how to get velocity to log correctly to log4j 2? On 29 January 2016 at 17:12, Paul Benedict wrote: > Why not log4j2? > > Ch

Re: Upgrade to tiles 3 jcl-over-slf4j

I could be wrong, but I thought log4j2 provides the equivalent bridging functionality to other logging frameworks. Cheers, Paul On Fri, Jan 29, 2016 at 11:14 AM, Greg Huber wrote: > Yes, if you are logging directly to log4j2 but if other jars use slf4j you > need to delegate the logging (create

Re: Upgrade to tiles 3 jcl-over-slf4j

There is! org.apache.logging.log4j log4j-slf4j-impl 2.5 On 29 January 2016 at 17:18, Paul Benedict wrote: > I could be wrong, but I thought log4j2 provides the equivalent bridging > functionality to other logging frameworks. > > Cheers, > Paul > > On Fri,