Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/114
Looks good to me ð
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes s
found it here :
https://github.com/lukaszlenart/struts/tree/WW-4717
Followed the instructions for the filter and listener updates to web.xml
and I get:
2016-11-24 10:01:03,825 WARN
org.apache.struts2.conversion.UploadedFileConverter
UploadedFileConverter:convertValue - Converting java.io.Fi
Seems to be this line in UploadedFileConverter:
if (value.getClass().isArray() && Array.getLength(value) == 1) {
where value ==
org.apache.struts2.dispatcher.multipart.StrutsUploadedFile@62e25d8
and is not an array.
this works:
Object obj = null;
if (value.getClass().isArray() && A
How is that possible? I meant, parameters should always be passed as
arrays, that's how HttpServletRequest works. Do you use custom
implementation of MultiPartRequest? Could you share your upload logic,
action and JSP/JavaScript?
That's why JakartaMultiPartRequest (and other implementations as wel
Hm... this can be an internal conversion of collection containing
uploaded files. Does your ajax upload allow upload multiple files at
once?
2016-11-24 14:18 GMT+01:00 Lukasz Lenart :
> How is that possible? I meant, parameters should always be passed as
> arrays, that's how HttpServletRequest wor
Greg
Pushed changes based on your suggestions and added a unit test to
cover the logic, thanks :)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
2016-11-24 14:26 GMT+01:00 Lukasz Lenart :
> Hm... this can be an internal conversion of collection containing
> uploaded files. Does yo
Sorry, forgot to add this is not on the app engine! Was only testing the
plugin functionality ie the filter and the listener. I assume the array
comes from when running the webapp on the app engine?
On 24 November 2016 at 13:26, Lukasz Lenart wrote:
> Hm... this can be an internal conversion
That shouldn't matter but I think how can I test this behaviour.
2016-11-24 15:03 GMT+01:00 Greg Huber :
> Sorry, forgot to add this is not on the app engine! Was only testing the
> plugin functionality ie the filter and the listener. I assume the array
> comes from when running the webapp on th
For every file it calls the UploadedFileConverter, this is the same for
the ajax uploader and a form with multiple upload files.
On 24 November 2016 at 14:08, Lukasz Lenart wrote:
> That shouldn't matter but I think how can I test this behaviour.
>
> 2016-11-24 15:03 GMT+01:00 Greg Huber :
>
Am 23.11.16 um 12:56 schrieb Lukasz Lenart:
> I prefer to go in small steps:
>
> - Struts 2.6 - Servlets 2.5, JSP 2.1, Java 7
> - Struts 3 - Servlets 3.0, JSP 2.2, Java 7
> - Struts 4 - ..., Java 8
>
> and as from Struts 3 switch to full Semantic Versioning http://semver.org/
+1 to all these pro
Cool, I think we are good to go with this refactoring, the rest can be
resolved during a test build period.
Thanks a lot Greg for your help :)
Regards
--
Łukasz
+ 48 606 323 122 http://www.lenart.org.pl/
2016-11-24 15:29 GMT+01:00 Greg Huber :
> For every file it calls the UploadedFileCon
11 matches
Mail list logo
