Re: Documentation

2017-02-03 Thread Lukasz Lenart
Can you review this section? http://struts.apache.org/submitting-patches.html#contributing-with-github Is it clear how to prepare a repo, add fork and create branch/PR? Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ 2017-02-02 20:32 GMT+01:00 Aleksandr Mashchenko : > Maybe this c

Re: Documentation

2017-02-03 Thread Greg Huber
How would one resync the github fork with the struts orignal version? On 3 February 2017 at 14:22, Lukasz Lenart wrote: > Can you review this section? > http://struts.apache.org/submitting-patches.html#contributing-with-github > > Is it clear how to prepare a repo, add fork and create branch/P

Re: Documentation

2017-02-03 Thread Lukasz Lenart
2017-02-03 16:06 GMT+01:00 Greg Huber : > How would one resync the github fork with the struts orignal version? You don't have to :) You are always starting off the master from origin Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ -

Re: Documentation

2017-02-03 Thread Stefaan Dutry
Personaly i can understand everything in there. However i tend to do things differently myself. How i usualy work: * I use clone with https way 1. Fork the repository to my own account 2. clone the repository localy, making my fork 'origin' (git clone ) 3. add the original repository as a remote

non-existing link on migration guide page

2017-02-03 Thread Stefaan Dutry
the following page holds an unexisting link to Version Notes 2.5.9 http://struts.apache.org/docs/migration-guide.html Link to Version Notes 2.5.10 has not been added yet http://struts.apache.org/docs/version-notes-2510.html Regards, Stefaan Dutry (sdutry)

Re: non-existing link on migration guide page

2017-02-03 Thread Lukasz Lenart
2017-02-03 20:46 GMT+01:00 Stefaan Dutry : > the following page holds an unexisting link to Version Notes 2.5.9 > http://struts.apache.org/docs/migration-guide.html > > Link to Version Notes 2.5.10 has not been added yet > http://struts.apache.org/docs/version-notes-2510.html Fixed, thanks :) Re

Re: Documentation

2017-02-03 Thread Lukasz Lenart
2017-02-03 20:19 GMT+01:00 Stefaan Dutry : > Personaly i can understand everything in there. Cool, thanks :) > However i tend to do things differently myself. > > How i usualy work: > * I use clone with https way Why? > 1. Fork the repository to my own account > 2. clone the repository localy,

Re: Documentation

2017-02-03 Thread Stefaan Dutry
I would like to start by saying that i didn't claim my way was better. -) why https way No need to set up ssh keys. (so basicaly just lazyness from my part) -) How do you update your fork with changes from origin to avoid a merge commit? Thanks for pointing this out. This is something i did