GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/151
WW-4818 change default Multipart validation regex to comply with RFC1341
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4818
A
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129280692
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUES
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129281026
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUES
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129281083
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUEST_POST
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129281192
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUES
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129282110
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUEST_POST
Github user lukaszlenart commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129282870
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUES
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129283402
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String REQUEST_POST
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/151
@lukaszlenart
I added 2 simple tests.
- one containing all the special allowed characters
- another one containing a single not-allowed character
Please feel free to tell me what o
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/151
Looks good ð LGTM :)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wi
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/151
@lukaszlenart
Am i allowed to merge this or is there more work/checks that needs to
happen first?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
So, it appears to be working so far. Thank you so much!! I do still get this
warning in my log files, do you know the best way to suppress it?
WARN [com.opensymphony.xwork2.ognl.SecurityMemberAccess]
(http-localhost/127.0.0.1:8080-2) Package of target
[org.apache.struts2.dispatcher.StrutsReq
You're welcome! Happy to hear that it works there :)
That warning means you still have some more. Please find them by
searching 'request.isUserInRole in your JSPs then replace them with
'#request["MYUtils"].isUserInRole
test='#request["MYUtils"].isUserInRole("UserAdmin")' and
test="#request['M
13 matches
Mail list logo
