Re: Gitbox

> Hi, > > There is a new git service available at Apache - > https://gitbox.apache.org/ which allows to have bi-directional sync > between GitHub and Apache Git which means we can directly merge PRs on > GitHub :D > > I will request moving our repos to this new service. > > > Regards > -- > Łu

Build failed in Jenkins: Struts-Extras-struts2-secure-jakarta-multipart-parser-plugin-JDK6-master #12

See Changes: [Lukasz Lenart] Updates info about Struts 2.3.8 -- Started by an SCM change [EnvInject] - Loading node e

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user yasserzamani commented on the issue: https://github.com/apache/struts/pull/153 To keep `backward-compatible` if is very important, I think we may have following: ```java protected Object injectInternalBeans(Object obj) { if (obj != null) {

Re: Would we need to achieve better place in trends ranking?

2017-07-18 12:03 GMT+02:00 Yasser Zamani : > Are we, volunteers, allowed to help/contribute with such structural > changes? I hope yes. If so, I have passion in `support for > actors/asynchronous request handling`. Could you please register an > issue with a few directive details? then we can pick

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 I'm not sure if this is a good idea ... basically we need a `@PostConstruct` mechanism in Struts DI - this can be easily achieved by switching to Guice 3 and using CDI annotations. --- If your

[GitHub] struts pull request #148: WW-4808: Multiple suffixes

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/148 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 Hm... give me few minutes, maybe I will be able add support for it ;-) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your pro

[GitHub] struts pull request #154: WW-4831 properly convert nulls in arrays

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/154 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts issue #44: WW-4520 - Add prefix for CSS classes.

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/44 Hm... I wonder how hard it will be to make this configurable so we can keep backward compatibility and allow enable a custom prefix on demand. --- If your project is set up for it, you can reply

[GitHub] struts pull request #155: WW-4827: post init

GitHub user lukaszlenart opened a pull request: https://github.com/apache/struts/pull/155 WW-4827: post init Resolves [WW-4827](https://issues.apache.org/jira/browse/WW-4827) You can merge this pull request into a Git repository by running: $ git pull https://github.com/lukaszl

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 I have opened #155 - what do you think? @aleksandr-m can you test it locally as I do not have the exact setup. --- If your project is set up for it, you can reply to this email and have your re

[GitHub] struts pull request #156: WW-4834 Improve RegEx used to validate URLs

GitHub user sdutry opened a pull request: https://github.com/apache/struts/pull/156 WW-4834 Improve RegEx used to validate URLs changed the regex according to https://github.com/apache/struts/commit/8df5a897f61f3ef45c36fdd9275e9ae4516c#commitcomment-23414493 Can anyone

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 Nope, #155 doesn't seem have any effect. Add following files to project, run under *nix, execute some action which lead to the JSP, `localizedTextProvider` should not be `null` in system

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 hm... but this example works for both branches - `master` and this: ``` DateConverter.convertToString() localizedTextProvider=com.opensymphony.xwork2.util.StrutsLocalizedTextProvider@342e

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 (on OSX) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if t

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 One more question: JDK version? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 Ubuntu, oracle jdk8. If following code prints `setContainer` before other setters (especially before `setInterceptorFactory`) it will work. On Ubuntu using oracle jdk8 `setContainer` is

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 See these screenshots master  this branch

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 It isn't about `XWorkConverter` per se. In #155 the injection of `ConversionPropertiesProcessor` still happens and `TypeConverterCreator` is injected next and `ObjectFactory#buildBean` is called

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 ... but where the `ObjectFactory#buildBean` is called? It should only be called when building non-internal beans and when all the internal beans were already instantiated. Can you post a call tr

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 I have changed code a bit, can you try to test it on your side? --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project do

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/153 With the new code in #155 the custom type converter isn't initialized at all. :( Call trace of previous code in #155 ``` --- If your project is set up for it, you can reply to this

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 > With the new code in #155 the custom type converter isn't initialized at all. :( w00t! --- If your project is set up for it, you can reply to this email and have your reply appear on

[GitHub] struts pull request #156: WW-4834 Improve RegEx used to validate URLs

Github user asfgit closed the pull request at: https://github.com/apache/struts/pull/156 --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enab

[GitHub] struts issue #153: WW-4827 Not fully initialized ObjectFactory tries to crea...

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/153 Would it be possible to share an application that replicates this behaviour? Sorry for bothering you but I want to understand what's going on :) --- If your project is set up for it, you can re