[GitHub] [struts] lukaszlenart merged pull request #434: Refactoring Nonce Propagation in Struts Tags for CSP

2020-09-21 Thread GitBox
lukaszlenart merged pull request #434: URL: https://github.com/apache/struts/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-21 Thread Yasser Zamani
I think we have to search hierarchy all provided we want to support overridden text (even if you define some convention about location). So the only solution I can imagine is caching if applicable. Do you get 2075 on each page render or just first? Lukasz said we have caching and you wouldn't get

[GitHub] [struts] lukaszlenart merged pull request #434: Refactoring Nonce Propagation in Struts Tags for CSP

2020-09-21 Thread GitBox
lukaszlenart merged pull request #434: URL: https://github.com/apache/struts/pull/434 This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go t

Re: Modification to speed up s:text from StrutsLocalizedTextProvider

2020-09-21 Thread Greg Huber
The overriding would be the main issue, but only if you override the properties. It is 2000+ on each page render, list with 10 entries. Think caches the bundle/locations, not what class/bundle, so it calls findResourceBundle(..) with the key. If you put a trace on your own AbstractLocalizedT