Re: looking at roller upgrade again

2023-04-09 Thread Greg Huber
I guess what we want. ### In the FormButton populateComponentHtmlId(Form form) it evaluates the action based on the text rather than the "actual" action. If the action is determined from the mapping it renders correctly. See "// determine actual action" in code below entryEdit renders

Re: looking at roller upgrade again

2023-04-09 Thread Lukasz Lenart
niedz., 9 kwi 2023 o 10:07 Greg Huber napisał(a): > > > > name="entryEdit!saveDraft"/> > > I guess what we want. Great, thanks for reporting this issue :) https://issues.apache.org/jira/browse/WW-5302 Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ --

[GitHub] [struts] lukaszlenart opened a new pull request, #678: [WW-5302] Evaluates the name attribute before assigning it to the id attribute

2023-04-09 Thread via GitHub
lukaszlenart opened a new pull request, #678: URL: https://github.com/apache/struts/pull/678 Closes [WW-5302](https://issues.apache.org/jira/browse/WW-5302) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: looking at roller upgrade again

2023-04-09 Thread Lukasz Lenart
PR is ready https://github.com/apache/struts/pull/678 - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] [struts] lukaszlenart opened a new pull request, #679: [WW-5280] Cleans up NoParameters interfaces

2023-04-09 Thread via GitHub
lukaszlenart opened a new pull request, #679: URL: https://github.com/apache/struts/pull/679 Closes [WW-5280](https://issues.apache.org/jira/browse/WW-5280) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: looking at roller upgrade again

2023-04-09 Thread Greg Huber
Testing the branch it is still the same? myConfig id="myConfigmainAction__save" > What we want is: id="myConfig_myConfig_save" > ## It needs this from previous email // determine actual action ActionMapping mapping = new ActionMapping(); mapping.setName(findString(action)

[GitHub] [struts] lukaszlenart opened a new pull request, #680: [WW-5304] Drops deprecated methods and fields in ActionContext

2023-04-09 Thread via GitHub
lukaszlenart opened a new pull request, #680: URL: https://github.com/apache/struts/pull/680 Closes [WW-5304](https://issues.apache.org/jira/browse/WW-5304) -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above

Re: looking at roller upgrade again

2023-04-09 Thread Lukasz Lenart
niedz., 9 kwi 2023 o 12:20 Greg Huber napisał(a): > Testing the branch it is still the same? Please try now Regards -- Łukasz + 48 606 323 122 http://www.lenart.org.pl/ - To unsubscribe, e-mail: dev-unsubscr...@struts.apache.