Re: looking at roller upgrade again

2023-04-19 Thread Greg Huber
@Greg Huber is the current approach ok? https://github.com/apache/struts/pull/678 This works but not really related to this formatting issue. As there is nothing wrong with Struts, it never formatted it correctly in the first place, which can be seen from the test clickById : clickById("entry

Re: looking at roller upgrade again

2023-04-19 Thread Lukasz Lenart
śr., 19 kwi 2023 o 09:19 Greg Huber napisał(a): > clickById("entry_%{#mainAction}!publish") > > This patch fixes the format by calculating the action first: > > https://github.com/apache/struts/commit/d7cf72c92eb84437eb9794b56c2525b389cf7900 This is really a hack to satisfy Roller requirements, b

Re: looking at roller upgrade again

2023-04-19 Thread Greg Huber
hack to satisfy Roller requirements Well I don't think its a hack, to have the variable name as part of the id does not seem correct to me eg     entryEdit     ie the name would be : entry___tmp__saveDraft vs entry_entryEdit_saveDraft calculate ID based on action AND method at the sa

action="%{tmp}" on other tags

2023-04-19 Thread Greg Huber
The form tag does this : On 19/04/2023 08:25, Lukasz Lenart wrote: śr., 19 kwi 2023 o 09:19 Greg Huber napisał(a): clickById("entry_%{#mainAction}!publish") This patch fixes the format by calculating the action first: https://github.com/apache/struts/commit/d7cf72c92eb84437eb9794b56c25