[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

Github user lukaszlenart commented on the issue: https://github.com/apache/struts-extras/pull/1 Done, I will prepare a release --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature

[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

Github user lukaszlenart commented on the issue: https://github.com/apache/struts-extras/pull/1 `request` exist but it isn't supported, I mean you must implement a dedicated `ScopeStrategy`. The simplest way will be remove bean definition and provide instruction how to setup bean in

[GitHub] struts-extras issue #1: Changed scope="prototype" to scope="default"

Github user carstenosu commented on the issue: https://github.com/apache/struts-extras/pull/1 I realized this is going to break the plugin for everybody running Struts 2.5.x. Perhaps scope="request" would be a better solution since that scope is available to both 2.3 and 2.5. ---

[GitHub] struts-extras pull request #1: Changed scope="prototype" to scope="default"

GitHub user carstenosu opened a pull request: https://github.com/apache/struts-extras/pull/1 Changed scope="prototype" to scope="default" Prototype scope is from Struts 2.5 but doesn't exist in Struts 2.3.x. Default is the equivalent scope in 2.3.x. This resulted in the list of

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user yasserzamani commented on the issue: https://github.com/apache/struts/pull/124 I also wait for ASF LEGAL part's answer but after some study, it seems I was not allowed to do such work 😞 If so, I think I have to write my own utils at where @aleksandr-m mentioned;

[GitHub] struts pull request #124: WW-4744: AnnotationUtils supports non-public metho...

Github user yasserzamani commented on a diff in the pull request: https://github.com/apache/struts/pull/124#discussion_r107110525 --- Diff: core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java --- @@ -150,25 +166,32 @@ public static void addAllInterfaces(Class

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user yasserzamani commented on the issue: https://github.com/apache/struts/pull/124 > We must rather ask ASF legal body, you can post an issue in JIRA (see above) Thank you. As I could not find similar issue, I created [Merge others codes having same license but

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/124 We must rather ask ASF legal body, you can post an issue in JIRA (see above) --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user yasserzamani commented on the issue: https://github.com/apache/struts/pull/124 > Yasser explain why he did that Thank you for your review. `AnnotationUtils` is not a new class but to avoid reinventing the wheel, I copied and merged some codes from Spring

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user aleksandr-m commented on the issue: https://github.com/apache/struts/pull/124 Do we need custom annotation utility at all? Can't we just use existing libraries e.g. Apache Commons

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/124 > That's the class that has been copied from spring I meant, coping classes is ok if the license allows that (Spring uses AL 2.0) but my questions was about adding authors to some other

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user cnenning commented on the issue: https://github.com/apache/struts/pull/124 > Should I ask legal [1] about that? What do you think? That's the class that has been copied from spring. Yes, I think it's better to ask how to handle this. --- If your project is set

Re: [GitHub] struts pull request #124: WW-4744: AnnotationUtils supports non-public metho...

2017-03-21 7:04 GMT+01:00 lukaszlenart : > Github user lukaszlenart commented on a diff in the pull request: > > https://github.com/apache/struts/pull/124#discussion_r107079345 > > --- Diff: > core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java --- >

[GitHub] struts issue #124: WW-4744: AnnotationUtils supports non-public methods

Github user lukaszlenart commented on the issue: https://github.com/apache/struts/pull/124 Looks good, just have some doubts about putting `@author` tag --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project

[GitHub] struts pull request #124: WW-4744: AnnotationUtils supports non-public metho...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/124#discussion_r107079461 --- Diff: core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java --- @@ -150,25 +166,32 @@ public static void addAllInterfaces(Class

[GitHub] struts pull request #124: WW-4744: AnnotationUtils supports non-public metho...

Github user lukaszlenart commented on a diff in the pull request: https://github.com/apache/struts/pull/124#discussion_r107079345 --- Diff: core/src/main/java/com/opensymphony/xwork2/util/AnnotationUtils.java --- @@ -37,13 +40,25 @@ * @author Rainer Hermanns * @author