[GitHub] struts issue #132: WW-4780 : upgraded version of log4j2 to 2.8.2

[lukaszlenart]

Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/132
  
Small changes like this you can directly push to the `master` branch, 
opening PR and merging it, is time-consuming :)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request #132: WW-4780 : upgraded version of log4j2 to 2.8.2

[asfgit]

Github user asfgit closed the pull request at:

https://github.com/apache/struts/pull/132


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request #132: WW-4780 : upgraded version of log4j2 to 2.8.2

[sdutry]

GitHub user sdutry opened a pull request:

https://github.com/apache/struts/pull/132

WW-4780 : upgraded version of log4j2 to 2.8.2



You can merge this pull request into a Git repository by running:

$ git pull https://github.com/sdutry/struts WW-4780

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/132.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #132


commit 11cccb68a90edb73ce183c4bb735cb458bfe9ec5
Author: Stefaan Dutry 
Date:   2017-04-20T20:06:20Z

upgraded version of log4j2 to 2.8.2




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #130: WW-3952: Credit card validator

[cnenning]

Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/130
  
If patterns change users have another reason to upgrade to latest struts 
😆 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #130: WW-3952: Credit card validator

[lukaszlenart]

Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/130
  
Good question... I have used those random card numbers in tests and looks 
ok (but we will see) 
https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #130: WW-3952: Credit card validator

[cnenning]

Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/130
  
How often do credit card companies change their number-patterns in a way 
that the regex needs to be updated? 'guess it is rare enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #130: WW-3952: Credit card validator

[lukaszlenart]

Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/130
  
> I hope the regex is stable 

What do you mean by that? I have used this 
http://www.regular-expressions.info/creditcard.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #131: WW-4210: Type conversion class

[cnenning]

Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/131
  
👍 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #130: WW-3952: Credit card validator

[cnenning]

Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/130
  
I hope the regex is stable 😉 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request #129: Support 2 3

[gmcdonald]

Github user gmcdonald closed the pull request at:

https://github.com/apache/struts/pull/129


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts issue #130: WW-3952: Credit card validator

[lukaszlenart]

Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/130
  
This is ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org

[GitHub] struts pull request #131: WW-4210: Type conversion class

[lukaszlenart]

GitHub user lukaszlenart opened a pull request:

https://github.com/apache/struts/pull/131

WW-4210: Type conversion class

This PR extends existing `TypeConversion` annotation to allow define 
converters as a class instead of a raw string.

Implements [WW-4210](https://issues.apache.org/jira/browse/WW-4210)

You can merge this pull request into a Git repository by running:

$ git pull https://github.com/lukaszlenart/struts type-conversion-class

Alternatively you can review and apply these changes as the patch at:

https://github.com/apache/struts/pull/131.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

This closes #131


commit 47552bdb0673a88b0cd76cebc40f65477edd58d0
Author: Lukasz Lenart 
Date:   2017-04-20T06:28:46Z

WW-4210 Extends annotation to allow use class instead of string

commit 3e76564d3ce8d5b4a3938efd3a76c521eb045f38
Author: Lukasz Lenart 
Date:   2017-04-20T06:29:24Z

WW-4210 Supports defining converter as a class in the annotation

commit ec2412492503cdd0e90abf7f2cf2c3e50c8fa70c
Author: Lukasz Lenart 
Date:   2017-04-20T06:29:53Z

WW-4210 Updates tests to use the class definition instead of string




---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org