Re: Google code donation? (was Re: svn commit: r903559 - in /struts/sandbox/trunk/struts2-gxp-plugin: ./ src/ src/main/ src/main/java/ src/main/java/org/ src/main/java/org/apache/ src/main/java/org/

2010-04-12 Thread Ben McCann
I just sent Martin the signed agreement. Hopefully we can get the code checked into the repository now. -Ben McCann On Sat, Apr 10, 2010 at 4:24 PM, Martin Cooper wrote: > This has been dragging on for a very long time now. The most recent > final "couple weeks" has turne

Updating the Struts 2 Guice plugin

2010-12-02 Thread Ben McCann
Hi, We just updated the Struts 2 Guice plugin so that it will be compatible with Guice 3. However, the main class of the plugin, Struts2Factory, is being created via xwo

Re: Updating the Struts 2 Guice plugin

2010-12-02 Thread Ben McCann
> Mobile: +6287885901958 > Blog & Profile: http://frans.thamura.info > > We grow because we share the same belief. > > > On Fri, Dec 3, 2010 at 7:33 AM, Ben McCann wrote: > > > Hi, > > > > We just updated the Struts 2 Guice plugin so that it will be compatibl

Re: Updating the Struts 2 Guice plugin

2010-12-02 Thread Ben McCann
on example > > but cannot find in atinject > > can help? > > we want to replace spring also in s2 :) > > so the market will be more colourfull > > spring is to strong now, and spring dont have market team here, so that is > better promote guice ;) > > F > &

Re: Do Struts developers use FindBugs?

2011-01-24 Thread Ben McCann
I'm only on the fringes of Struts development, but I've used Findbugs fairly regularly at Google. Bill Pugh was visiting us and pushed heavily for it's adoption, so he might have some helpful details for you. Good luck, Ben On Mon, Jan 24, 2011 at 1:15 PM, Wes Wan

GXP Plugin

2011-01-31 Thread Ben McCann
Hi, I was wondering if someone would be able to check-in the rest of the code for the GXP plugin that I contributed. Only half of it got checked in because of some mix-up with lost paperwork or something along those lines. I got a software grant form signed off on by one of our VPs at which point

Re: GXP Plugin

2011-01-31 Thread Ben McCann
ing the gxp plugin, then that > already has the dependency mentioned in the ticket, at least in trunk. > > John > > > On 1/31/11 1:52 PM, "Ben McCann" wrote: > > Hi, > I was wondering if someone would be able to check-in the rest of the code > for the GXP

Re: GXP Plugin

2011-01-31 Thread Ben McCann
ndards. > > But you’re right that two files are missing: struts-plugin.xml and > InjectedObjectContainer.java > > I have checked these in under WW-3475. Please check the new contents of > trunk, and let me know if this fixes it. > > John > > > > On 1/31/11 2:04

Re: GXP Plugin

2011-02-02 Thread Ben McCann
Ah, I wasn't aware of the change that obviated the need for InjectedObjectContainer. That's a good change. That class was pretty hacky and ugly. The build link didn't work so I changed it to https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-assembly/. I don't see t

Re: GXP Plugin

2011-02-02 Thread Ben McCann
M, Maurizio Cucchiara < maurizio.cucchi...@gmail.com> wrote: > Sorry for the wrong link, my bad. I'm pretty sure that I copied it. > Is that [1] what are you looking for? > > [1] > https://hudson.apache.org/hudson/job/Struts2/lastBuild/org.apache.struts$struts2-gxp-plug

Re: GXP Plugin

2011-02-08 Thread Ben McCann
Thanks Lakasz On Thu, Feb 3, 2011 at 12:51 AM, Lukasz Lenart wrote: > Hi, > > I've removed that nasty class and also added missing entries into > assembly module. Right now Gxp plugin should be included in -all.zip > package as well. > > > Regards > -- > Łukasz > + 48 606 323 122 <+48606323122>

Re: GXP Plugin

2011-02-08 Thread Ben McCann
I meant Lukasz. Sorry to typo your name :o) On Tue, Feb 8, 2011 at 2:25 PM, Ben McCann wrote: > Thanks Lakasz > > > On Thu, Feb 3, 2011 at 12:51 AM, Lukasz Lenart < > lukasz.len...@googlemail.com> wrote: > >> Hi, >> >> I've removed that

Re: getting the container (or Configuration/ConfigurationManager) in a non-container-instantiated object

2011-02-10 Thread Ben McCann
If I'm understanding correctly, I had the same problem writing the Guice plugin. Our solution was probably a bit ugly, but it was the only way I could find of making it work, so maybe it will help you: http://code.google.com/p/google-guice/source/browse/trunk/extensions/struts2/src/com/google/inje

Re: getting the container (or Configuration/ConfigurationManager) in a non-container-instantiated object

2011-02-10 Thread Ben McCann
Actually, after taking a closer look, that file's not going to help you at all. I'd forgotten what we did exactly. I asked the same question awhile back and now I'm remembering that I never found a solution and gave up on it, so I'd love to know if you figure it out. On Thu, Feb 10, 2011 at 12:

Packaging Struts apps in deployment jars

2011-03-09 Thread Ben McCann
Hi, I did a lot of the development on the Google Guice and GXP plugins. Unfortunately, I've found that we cannot use both of these together internally. What we do at Google to package apps for deployment is unzip all the jars and then rezip them all together into a single jar. This is really nic

Re: Packaging Struts apps in deployment jars

2011-03-09 Thread Ben McCann
It crossed my mind, but I didn't think it'd go over real well to build a special case into our build system just for struts plugins. On Wed, Mar 9, 2011 at 10:12 PM, Chris Pratt wrote: > How about just merging the struts-plugin.xml files. > (*Chris*) > > On Wed, Mar 9

Re: Roadmap for 2.3

2011-03-15 Thread Ben McCann
I didn't realize you could setup Struts2 without XML. That sounds fantastic to me. I'd vote in favor of moving it to the core or at least highlighting it in the documentation. Having to do configuration in XML is the one thing I dislike about Struts2 despite being a longtime and happy user of th