Common Struts usage problems

2005-01-12 Thread Dave Brosius
Hi folks, I was wondering if you folks had a list of common coding mistakes that people do with regards to using Struts that could be found by analysing byte code? I am a developer on Findbugs (findbugs.sourceforge.net) and would like to add detectors for such, if they exist. Thanks!

patch to make sure streams get closed

2004-08-24 Thread Dave Brosius
This patch makes sure streams are closed even on exception paths. - To unsubscribe, e-mail: [EMAIL PROTECTED] For additional commands, e-mail: [EMAIL PROTECTED]

Re: patch to make sure streams get closed

2004-08-24 Thread Dave Brosius
- Original Message - From: "Dave Brosius" <[EMAIL PROTECTED]> To: <[EMAIL PROTECTED]> Sent: Tuesday, August 24, 2004 9:58 PM Subject: patch to make sure streams get closed > This patch makes sure streams are closed even on exception paths. > Hmmm,

Patch to make constants static

2004-08-24 Thread Dave Brosius
Constants might as well be static Index: src/share/org/apache/struts/validator/validwhen/ValidWhenParser.g === RCS file: /home/cvspublic/jakarta-struts/src/share/org/apache/struts/validator/validwh en

Re: patch to make sure streams get closed

2004-08-24 Thread Dave Brosius
#x27;s better to submit these through Bugzilla, so they don't get lost. http://struts.apache.org/using.html#Patches -Ted. On Tue, 24 Aug 2004 22:00:41 -0400, Dave Brosius wrote: > > > - Original Message - > From: "Dave Brosius" <[EMAIL PROTECTED]> > T