GitHub user quaff opened a pull request:
https://github.com/apache/struts/pull/30
Defend for NPE when performing async request
when I combined spring async mvc with struts2 sitemesh plugin, It will
throw NPE
java.lang.NullPointerException
at
org.apache.struts2
GitHub user quaff opened a pull request:
https://github.com/apache/struts/pull/35
Improve LocalizedTextUtil depend NPE
depend NPE if not ValueStack presented, for example non-struts request or
backend thread.
You can merge this pull request into a Git repository by running
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/35#issuecomment-77827292
@lukaszlenart , It doesn't add new thing just null-check added, It's safe
if existing unit tests passed.
---
If your project is set up for it, you can reply to
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/35#issuecomment-77971388
ValueStack will be always not null with struts2 request, so It wouldn't
change the behavior of struts2, this pull request is intend to use in
non-struts2 context.
-
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/35#issuecomment-78184739
simplest case
```java
import java.util.Locale;
public class Main {
public static void main(String[] args) {
System.out.println
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/35#issuecomment-78400068
It's just a static util class, It should be light and simple, your
suggestion is opposite.
---
If your project is set up for it, you can reply to this email and have
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/35#issuecomment-78441177
I hope so, please add a method drop last two arguments, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as
GitHub user quaff opened a pull request:
https://github.com/apache/struts/pull/48
Uniform comparison
Add more defense, like compare Enum to String or else.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/quaff/struts master
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/48#issuecomment-138866897
You are so quick, I create WW-4544 just now.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user quaff opened a pull request:
https://github.com/apache/struts/pull/50
Improve LocalizedTextUtil.getMessage() defend NPE
Defend NPE if not ValueStack presented, for example non-struts request like
static util method or backend thread.
reopen #35
You can merge this
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/50#issuecomment-141288110
It's up-to-date on branch master. you can check commit history.
https://github.com/quaff/struts/commits/master
https://github.com/apache/struts/commits/m
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/50#issuecomment-141368433
http://stackoverflow.com/questions/16721629/jenkins-returned-status-code-128-with-github
https://issues.jenkins-ci.org/browse/JENKINS-10385
I hope it helps
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/50#issuecomment-142159790
What should I do?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this
Github user quaff commented on the pull request:
https://github.com/apache/struts/pull/50#issuecomment-142492307
@wolpi , It's a very very simple and safe improvement, It doesn't increases
maintenance burden, It make struts more robust.
---
If your project is set up for i
GitHub user quaff opened a pull request:
https://github.com/apache/struts/pull/105
[WW-4620] Improve XWorkListPropertyAccessor to against DOS attack
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/quaff/struts master
Github user quaff commented on a diff in the pull request:
https://github.com/apache/struts/pull/105#discussion_r71092863
--- Diff:
core/src/main/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessor.java
---
@@ -45,6 +45,12 @@
private ObjectFactory
Github user quaff commented on a diff in the pull request:
https://github.com/apache/struts/pull/105#discussion_r72914158
--- Diff:
core/src/main/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessor.java
---
@@ -45,6 +45,12 @@
private ObjectFactory
Github user quaff commented on a diff in the pull request:
https://github.com/apache/struts/pull/105#discussion_r72952664
--- Diff:
core/src/main/java/com/opensymphony/xwork2/ognl/accessor/XWorkListPropertyAccessor.java
---
@@ -45,6 +45,12 @@
private ObjectFactory
18 matches
Mail list logo
