GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/110
updated javadoc after changing to enum
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4686-javadoc
Alternatively you can
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/111
registerd jira issue
[WW-4689](https://issues.apache.org/jira/browse/WW-4689)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/112
WW-4690 added version to jshint-maven-plugin
[issue WW-4690](https://issues.apache.org/jira/browse/WW-4690)
You can merge this pull request into a Git repository by running:
$ git pull https
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108343668
--- Diff:
struts2-custom-results-plugin/src/main/java/org/apache/struts2/result/HttpsOffloadAwareServletRedirectResult.java
---
@@ -0,0 +1,145
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108343998
--- Diff:
struts2-custom-results-plugin/src/main/java/org/apache/struts2/result/HttpsOffloadAwareServletRedirectResult.java
---
@@ -0,0 +1,145
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108344564
--- Diff:
struts2-custom-results-plugin/src/main/java/org/apache/struts2/result/HttpsOffloadAwareServletRedirectResult.java
---
@@ -0,0 +1,145
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108519883
--- Diff: struts2-custom-results-plugin/README.md ---
@@ -0,0 +1,42 @@
+# Apache Struts 2 Extras - custom results plugin
+
+[ please do another review.
Seeing as the issue where this idea
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/126
WW-4770 Fixes problem with dojo.version
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts issue/WW-4770
Alternatively you can
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/127
Drop deprecated logging layer
WW-4763
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4763
Alternatively you can review
Github user sdutry commented on the issue:
https://github.com/apache/struts-extras/pull/3
@lukaszlenart
Am i allowed to merge this now?
Or does this need to be reviewed and approved by someone else first?
---
If your project is set up for it, you can reply to this email
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/127
> Did you notice that this targets Struts 2.6
Oops, didn't notice that.
Best to just close this pull request then for now i guess.
---
If your project is set up for it, you
Github user sdutry closed the pull request at:
https://github.com/apache/struts/pull/127
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108511395
--- Diff: struts2-custom-results-plugin/README.md ---
@@ -0,0 +1,42 @@
+# Apache Struts 2 Extras - custom results plugin
+
+[![License](http
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108515260
--- Diff: struts2-custom-results-plugin/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108515221
--- Diff: struts2-custom-results-plugin/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108515681
--- Diff:
struts2-custom-results-plugin/src/main/java/org/apache/struts2/result/SslOffloadAwareServletRedirectResult.java
---
@@ -0,0 +1,188
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108515374
--- Diff: struts2-custom-results-plugin/pom.xml ---
@@ -0,0 +1,104 @@
+
+
+http://maven.apache.org/POM/4.0.0;
xmlns:xsi="http://www.w
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108515624
--- Diff:
struts2-custom-results-plugin/src/main/java/org/apache/struts2/result/SslOffloadAwareServletActionRedirectResult.java
---
@@ -0,0 +1,123
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts-extras/pull/3#discussion_r108516053
--- Diff:
struts2-custom-results-plugin/src/main/java/org/apache/struts2/result/SslOffloadAwareServletRedirectResult.java
---
@@ -0,0 +1,188
GitHub user sdutry opened a pull request:
https://github.com/apache/struts-extras/pull/3
added module for extra result types
This is still work in progress.
The reason i'm already having it as pull request is because any input is
welcome.
related to WW-4774
GitHub user sdutry opened a pull request:
https://github.com/apache/struts-site/pull/8
cleaned up remaining getting-started pages
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts-site cleanup
Alternatively you can
GitHub user sdutry opened a pull request:
https://github.com/apache/struts-site/pull/5
cleaned up hello-world-using-struts2 page
Tried cleaning up the hello-world-using-struts2 page.
- It's still missing a couple of links that were in the original page
GitHub user sdutry opened a pull request:
https://github.com/apache/struts-site/pull/6
cleaned up using-tags page
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts-site using-tags
Alternatively you can review
GitHub user sdutry opened a pull request:
https://github.com/apache/struts-site/pull/9
updated how-to-create-a-struts2-web-application page to current example
application
Tried updating this page to more reflect the application inside the
struts-examples git repo
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/132
WW-4780 : upgraded version of log4j2 to 2.8.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4780
Alternatively you can
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/132
@lukaszlenart
I know they can.
I just like having the confirmation from the automated build tools (jenkins
and travis) that i didn't break the builds before committing.
---
If your project
GitHub user sdutry opened a pull request:
https://github.com/apache/struts-site/pull/7
Cleaned up some of the markdown files
Not stating that they're perfect, but it should be an improved starting
point at least
You can merge this pull request into a Git repository by running
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/157
Ok,
I will wait.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/157
WW-4834 fixed faulty regex
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4834
Alternatively you can review and apply
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/157
> After the commit above, any IP with 3 digits in the last octet will not
pass validation
You are right, i forgot the grouping (meaning the or statements mean
something completely differ
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/157
@lukaszlenart
Sorry for breaking it in the first place. That wasn't my intention.
Do you want me to merge this now, or am i still overlooking stuff?
---
If your project is set up
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129281083
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129282110
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/151#discussion_r129283402
--- Diff: core/src/main/java/org/apache/struts2/dispatcher/Dispatcher.java
---
@@ -88,7 +88,7 @@
*/
public static final String
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/151
WW-4818 change default Multipart validation regex to comply with RFC1341
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4818
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/151
@lukaszlenart
I added 2 simple tests.
- one containing all the special allowed characters
- another one containing a single not-allowed character
Please feel free to tell me what
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/151
@lukaszlenart
Am i allowed to merge this or is there more work/checks that needs to
happen first?
---
If your project is set up for it, you can reply to this email and have your
reply appear
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/149
WW-4821 Upgrade Commons IO to 2.5
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4821
Alternatively you can review and apply
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/150
WW-4819 fixed commons-collections groupId in dependency management
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4819
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/152
WW-4826 upgrade to ASM version 5.2
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4826
Alternatively you can review and apply
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/156
WW-4834 Improve RegEx used to validate URLs
changed the regex according to
https://github.com/apache/struts/commit/8df5a897f61f3ef45c36fdd9275e9ae4516c#commitcomment-23414493
Can anyone
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/159
WW-4834 Improve RegEx used to validate URLs
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4834-support-2-3
Alternatively you
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/159
see #157 and #156
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/159
@lukaszlenart
i copied the regex after the changes from #157 .
So it should be the same. Feel free to check.
---
If your project is set up for it, you can reply to this email and have your
Github user sdutry closed the pull request at:
https://github.com/apache/struts/pull/136
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature
Github user sdutry commented on the issue:
https://github.com/apache/struts/pull/136
Given the input on the issue, this pull request should not be merged.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/136
WW-4793 only add JBossFileManager when supported
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4793
Alternatively you can
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/136#discussion_r114157280
--- Diff:
core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
@@ -210,4 +187,33 @@ private void addIfAbsent(List urls, URL fileUrl
Github user sdutry commented on a diff in the pull request:
https://github.com/apache/struts/pull/136#discussion_r114154579
--- Diff:
core/src/main/java/org/apache/struts2/util/fs/JBossFileManager.java ---
@@ -210,4 +187,33 @@ private void addIfAbsent(List urls, URL fileUrl
GitHub user sdutry opened a pull request:
https://github.com/apache/struts/pull/166
WW-4851 Upgrade to Log4j2 2.9.0
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/sdutry/struts WW-4851
Alternatively you can review and apply
51 matches
Mail list logo
