[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-21 Thread gregh3269
Github user gregh3269 commented on the issue:

https://github.com/apache/struts/pull/130
  
Last time I did some credit card validation, I needed to use a java script 
version as the payment process obscured the field names by not having the 
"name" attribute (so it was not obvious when these were sent over https) and I 
was unable to do server side validation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread cnenning
Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/130
  
If patterns change users have another reason to upgrade to latest struts 
😆 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/130
  
Good question... I have used those random card numbers in tests and looks 
ok (but we will see) 
https://www.paypalobjects.com/en_US/vhelp/paypalmanager_help/credit_card_numbers.htm


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread cnenning
Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/130
  
How often do credit card companies change their number-patterns in a way 
that the regex needs to be updated? 'guess it is rare enough.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/130
  
> I hope the regex is stable 

What do you mean by that? I have used this 
http://www.regular-expressions.info/creditcard.html


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread cnenning
Github user cnenning commented on the issue:

https://github.com/apache/struts/pull/130
  
I hope the regex is stable 😉 


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org



[GitHub] struts issue #130: WW-3952: Credit card validator

2017-04-20 Thread lukaszlenart
Github user lukaszlenart commented on the issue:

https://github.com/apache/struts/pull/130
  
This is ready for review


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

-
To unsubscribe, e-mail: dev-unsubscr...@struts.apache.org
For additional commands, e-mail: dev-h...@struts.apache.org