Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/142
@lukaszlenart
> The simplest solution is to add a flag, a constant that by default should
turn off this check, but the Spring Plugin should have this flag set on to
enable additional
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
Yes, you must branch off from the `support-2-3` branch and open a PR
against that branch after all
---
If your project is set up for it, you can reply to this email and have your
reply appear
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
@lukaszlenart , Yes with pleasure. I should come with a new PR but on
branch support-2-3, right?
---
If your project is set up for it, you can reply to this email and have your
reply appear on
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
@yasserzamani do you want to port some of those changes to 2.3.33? Or at
least implement what @aleksandr-m mentioned in a comment?
---
If your project is set up for it, you can reply to this
Github user cnenning commented on the issue:
https://github.com/apache/struts/pull/142
IMO this can be merged
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
If no objections I am going to merge this PR, btw. I have created a task to
implement Voters
https://issues.apache.org/jira/browse/WW-4807
---
If your project is set up for it, you can
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
Yeah I understand but still this affects non-Spring users. And I think this
can go in as is and we can improve and think about the Voters mechanism in 2.6.
---
If your project is set up for
Github user yasserzamani commented on the issue:
https://github.com/apache/struts/pull/142
Thank you @lukaszlenart , I got your point but what about when user uses
Spring but not S2's Spring Plugin? i.e. when user does not want to define
his/her actions as Spring beans but wants to
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
With the flag in place you can always disable it in your {{struts.xml}}
event it the Spring Plugin is present.
---
If your project is set up for it, you can reply to this email and have your
Github user aleksandr-m commented on the issue:
https://github.com/apache/struts/pull/142
@lukaszlenart Sounds good. Still, it would be nice to allow to turn this
checking completely off even when spring plugin is presented. The issue then
can be avoided with addition of a simple
Github user lukaszlenart commented on the issue:
https://github.com/apache/struts/pull/142
The case with those changes is that they will affect everyone even if you
don't use Spring so its scope should be narrowed just to the Spring Plugin. The
simplest solution is to add a flag, a
11 matches
Mail list logo
