RE: svn commit: r891672 - in /subversion/trunk/subversion: libsvn_client/commit_util.c tests/cmdline/externals_tests.py

2009-12-17 Thread Bert Huijben
-Original Message- From: style...@apache.org [mailto:style...@apache.org] Sent: donderdag 17 december 2009 13:31 To: comm...@subversion.apache.org Subject: svn commit: r891672 - in /subversion/trunk/subversion: libsvn_client/commit_util.c tests/cmdline/externals_tests.py Author:

Re: Subversion 1.6.7 on Dec. 16.

2009-12-17 Thread Philip Martin
Paul Burba ptbu...@gmail.com writes: Hyrum ran into a problem when reintegrating a branch back to 1.6.x using the (at the time) latest 1.6.x client. Here is the merge he did (though this has a pegged source because the backport branch was deleted): 1.6.x.svn merge

Failing JavaHL test

2009-12-17 Thread Mark Phippard
One of the JavaHL tests has been failing for a while now: 1) testBasicMerge(org.tigris.subversion.javahl.BasicTests)junit.framework.AssertionFailedError: Missing eligible merge info on

Re: mod_dav_svn not XML-escaping hook error messages

2009-12-17 Thread Julian Foad
On Mon, 2009-12-14, I (Julian Foad) wrote: Jon Foster wrote: It seems that mod_dav_svn doesn't escape special XML characters like and in the error messages from hook scripts. This causes corrupt XML to be sent across the wire. Here's a Wireshark capture of the response to the

Re: [PATCH] Replace some adm_access batons in externals.c

2009-12-17 Thread Philip Martin
Daniel Näslund dan...@longitudo.com writes: Index: subversion/libsvn_client/externals.c === --- subversion/libsvn_client/externals.c (revision 891778) +++ subversion/libsvn_client/externals.c (arbetskopia) @@ -894,53

Re: [PATCH] Replace some adm_access batons in externals.c

2009-12-17 Thread Daniel Näslund
On Thu, Dec 17, 2009 at 06:10:18PM +, Philip Martin wrote: Daniel Näslund dan...@longitudo.com writes: Index: subversion/libsvn_client/externals.c === --- subversion/libsvn_client/externals.c(revision 891778) +++

Re: Subversion 1.6.7 on Dec. 16.

2009-12-17 Thread Hyrum K. Wright
The end result of all this discussion appears to be that 1.6.7 can roll as-is, so I will proceed to do so sometime in the next 24 hours. -Hyrum On Dec 17, 2009, at 9:26 AM, Philip Martin wrote: Paul Burba ptbu...@gmail.com writes: Now that we correctly interpret mergeinfo with relative

[PATCH] Replace two deprecated wc functions

2009-12-17 Thread Daniel Näslund
Hi! NOTE: This patch depends on my patch for #3390 that has not been commited yet [1]. The external_func uses abspaths and that is fixed in the referred patch. I have two more patches that depend on [1]. make check passes with [1] applied. [[[ Replace deprecated

Re: CRITICAL bug: svn:externals referring to a revision does not work if the referred resource is deleted or moved later.

2009-12-17 Thread Mike Dixon
Gyorgy Foldvari wrote: echo -r1 ^/trunk/A/D/H external/here ../f I'm not an svn developer, but if you had asked this on the users@ list, I would have told you the following: This isn't a bug; you need to use a peg revision rather than the -r syntax if you want to access paths that have

Re: CRITICAL bug: svn:externals referring to a revision does not work if the referred resource is deleted or moved later.

2009-12-17 Thread Ben Collins-Sussman
http://svnbook.red-bean.com/nightly/en/svn.advanced.pegrevs.html On Thu, Dec 17, 2009 at 3:02 PM, Mike Dixon michael.di...@denovosoftware.com wrote: Gyorgy Foldvari wrote: echo -r1 ^/trunk/A/D/H external/here ../f I'm not an svn developer, but if you had asked this on the users@ list, I

Re: [PATCH] Replace two deprecated wc functions

2009-12-17 Thread Stefan Sperling
On Thu, Dec 17, 2009 at 08:40:15PM +0100, Daniel Näslund wrote: Hi! NOTE: This patch depends on my patch for #3390 that has not been commited yet [1]. The external_func uses abspaths and that is fixed in the referred patch. I have two more patches that depend on [1]. make check passes

Re: Subversion 1.6.7 on Dec. 16.

2009-12-17 Thread Branko Čibej
Paul Burba wrote: Regardless, I don't think this is a true regression, just a new bug, and as such, not something that should hold up 1.6.7. Sorry, what? Subversion will suddenly error out where it previously did not. No matter /how/ that mergeinfo got into the repository, if we don't fix

Re: mod_dav_svn not XML-escaping hook error messages

2009-12-17 Thread Julian Foad
http://subversion.tigris.org/issues/show_bug.cgi?id=3553 My test (the test patch that I posted a couple of messages back in this thread), running trunk without any patch to fix the bug, is producing: EXPECTED STDERR: svn: post-revprop-change hook failed (exit code 1) with output:

Re: Subversion 1.6.7 on Dec. 16.

2009-12-17 Thread Branko Čibej
Paul Burba wrote: On Thu, Dec 17, 2009 at 5:53 PM, Branko Čibej br...@xbc.nu wrote: Paul Burba wrote: Regardless, I don't think this is a true regression, just a new bug, and as such, not something that should hold up 1.6.7. Sorry, what? Subversion will suddenly error out

Re: Subversion 1.6.7 on Dec. 16.

2009-12-17 Thread Hyrum K. Wright
On Dec 17, 2009, at 9:10 PM, Branko Čibej wrote: Paul Burba wrote: On Thu, Dec 17, 2009 at 5:53 PM, Branko Čibej br...@xbc.nu wrote: Paul Burba wrote: Regardless, I don't think this is a true regression, just a new bug, and as such, not something that should hold up 1.6.7. Sorry,

Re: Standardizing python code using pylint

2009-12-17 Thread Bhuvaneswaran A
ping? Any comments on this proposal? On Sun, 2009-12-06 at 22:29 +0530, Bhuvaneswaran A wrote: As discussed in this email thread [1], I've come up with the pylint rules for standardizing the python code throughout the repository. Few of rules that would be of crowd's interest are as follows: