Re: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c workqueue.h

2010-02-18 Thread Philip Martin
Bert Huijben b...@qqmail.nl writes: This type of changes should be handled outside the WQ operation. All workqueue operations must be able to cope with restarting multiple times. This operation can delete the entry from the local_abspath. (One of the tiny details in fold_scheduling :( )

Re: [RFC] Comments on wc-metadata.sql PRISTINE and - translated size

2010-02-18 Thread Julian Foad
On Wed, 2010-02-17, Greg Stein wrote: To further illuminate here... the *same* pristine could have variant translated_size values based on each node's set of properties (svn:keywords, svn:eol-style, etc). That is why we attached the translated_size to the BASE_NODE and WORKING_NODE tables.

Re: [RFC] v2 Tree conflict resolver spec.

2010-02-18 Thread Daniel Näslund
Hi Neels! Thanks for all your feedback! The use of the libsvn_wc terms BASE, WORKING and ACTUAL will be replaced by your suggested (or was it Julians?) checked-in state and checked-out state in the next version of the RFC. Find further comments inline. On Tue, Feb 09, 2010 at 03:20:57PM +0100,

RE: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c workqueue.h

2010-02-18 Thread Bert Huijben
-Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: donderdag 18 februari 2010 11:07 To: Bert Huijben Cc: dev@subversion.apache.org; phi...@apache.org Subject: Re: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c

Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-18 Thread Matthew Bentham
On 17/02/2010 18:40, Greg Stein wrote: On Wed, Feb 17, 2010 at 12:22, Matthew Benthammj...@artvps.com wrote: ... Revised patch attached fixes the unit test (and hopefully the indentation, if I've understood the style correctly), but I have no real instinct as to whether I should be modifying a

RE: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client

2010-02-18 Thread Bert Huijben
-Original Message- From: Stefan Sperling [mailto:s...@elego.de] Sent: woensdag 17 februari 2010 19:30 To: Matthew Bentham Cc: dev@subversion.apache.org Subject: Re: [PATCH] wc-ng: remove a use of svn_wc_entry_t from libsvn_client On Wed, Feb 17, 2010 at 06:18:56PM +,

Re: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c workqueue.h

2010-02-18 Thread Philip Martin
Bert Huijben b...@qqmail.nl writes: My current code is just a copy of the old code, moved to a new location. No fixes there. (It still uses svn_wc__entry_modify2). In the rest of libsvn_wc we still rewrite BASE_NODE and WORKING_NODE records from just the limited state in svn_wc_entry_t...

RE: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c workqueue.h

2010-02-18 Thread Bert Huijben
-Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: donderdag 18 februari 2010 13:54 To: Bert Huijben Cc: dev@subversion.apache.org Subject: Re: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c workqueue.h Bert

Re: [RFC] Comments on wc-metadata.sql PRISTINE and

2010-02-18 Thread Julian Foad
Thanks, Greg. On Wed, 2010-02-17, Greg Stein wrote: WORKING_NODE rows exist for *all* affected nodes. Meaning all (grand)children of any affected directory as well, I take it. OK, Bert confirmed on IRC. Fixed. ACTUAL_NODE rows may exist w/o a corresponding WORKING_NODE row (in which case,

Re: [RFC] v2 Tree conflict resolver spec.

2010-02-18 Thread Daniel Näslund
Hi! My initial thought when I started writing on a spec for a TC resolver was that it would involve a lot of quirks and edge cases handled solely in subversion/svn/conflict-callbacks.c. That the svn resolver would only serve as a proof-of-concept for other API users. But if I could implement the

Re: Subversion is now an official ASF project!

2010-02-18 Thread Julian Foad
Hooray! Many thanks to you and the other people who each put in a lot of work to make this happen. - Julian Greg Stein wrote: The ASF Board just voted to approve the graduation of Subversion from the Incubator. We are now an official project of the Apache Software Foundation! Go forth!

Re: svn commit: r909093 - in /subversion/trunk/subversion/libsvn_wc: adm_ops.c workqueue.c workqueue.h

2010-02-18 Thread Philip Martin
Bert Huijben b...@qqmail.nl writes: One other thing that worries me is that mark_tree_deleted seems to doing deletes without doing the loggy/workqueue stuff. If I delete a replaced file svn_wc_delete4 sets up a workqueue item to handle the text-bases. However if I delete a directory

Re: Subversion is now an official ASF project!

2010-02-18 Thread Mark Phippard
Congrats all! BTW, I saw commits to update our web site but do not see them on the site. Is the publishing broken again? On Thu, Feb 18, 2010 at 6:06 AM, Julian Foad julian.f...@wandisco.com wrote: Hooray! Many thanks to you and the other people who each put in a lot of work to make this

Re: svn commit: r911370 - /subversion/trunk/subversion/libsvn_wc/workqueue.c

2010-02-18 Thread Philip Martin
hwri...@apache.org writes: Author: hwright Date: Thu Feb 18 12:49:20 2010 New Revision: 911370 URL: http://svn.apache.org/viewvc?rev=911370view=rev Log: * subversion/libsvn_wc/workqueue.c (run_delete): Do a bunch of casts, to get rid of a few warnings on 64-bit platforms.

Re: svn commit: r911370 - /subversion/trunk/subversion/libsvn_wc/workqueue.c

2010-02-18 Thread Hyrum K. Wright
On Feb 18, 2010, at 2:41 PM, Philip Martin wrote: hwri...@apache.org writes: Author: hwright Date: Thu Feb 18 12:49:20 2010 New Revision: 911370 URL: http://svn.apache.org/viewvc?rev=911370view=rev Log: * subversion/libsvn_wc/workqueue.c (run_delete): Do a bunch of casts, to get rid

Re: [PATCH] Re: svn: Can't check path '/.svn/wc.db': Permission denied

2010-02-18 Thread Peter Samuelson
[Stefan Sperling] Have you seen ^/subversion/branches/1.6.x-wc-ng-check-override ? I think that's the workaround you need. Log of the branch below. It's already nominated for backport, so if you like it, please vote :) I hadn't seen it. Yes, this solves the problem - but I'm not sure this

Re: memory leak? ref: merge test 4

2010-02-18 Thread C. Michael Pilato
I'm not seeing this problem, but then I don't think I'm setup to generate stderr spam on malloc/free errors (via the likes of MALLOC_CHECK_=1 in the environment or somesuch). Greg Stein wrote: I think the memory usage might actually be our test harness attempting to read all of the (stderr)

Re: [PATCH] Re: svn: Can't check path '/.svn/wc.db': Permission denied

2010-02-18 Thread Julian Foad
Peter Samuelson wrote: [Stefan Sperling] Have you seen ^/subversion/branches/1.6.x-wc-ng-check-override ? I think that's the workaround you need. Log of the branch below. It's already nominated for backport, so if you like it, please vote :) I hadn't seen it. Yes, this solves the

Re: Subversion is now an official ASF project!

2010-02-18 Thread Greg Stein
It was, yeah. I had infra kick it, and am seeking further data/solutions if it happens again... Thx! On Thu, Feb 18, 2010 at 09:30, Mark Phippard markp...@gmail.com wrote: Congrats all! BTW, I saw commits to update our web site but do not see them on the site.  Is the publishing broken

Re: [PATCH] Re: svn: Can't check path '/.svn/wc.db': Permission denied

2010-02-18 Thread Peter Samuelson
[Julian Foad] Let's check I understood the problem correctly: User has 1.6 client and 1.6 WCs, no 1.7 stuff involved at all. User's system has a WC rooted at the file system root: '/.svn' exists and is not readable by this user. In some normal operations that used to work with svn 1.6.x,

Re: svn commit: r911288 - /subversion/trunk/subversion/libsvn_wc/wc.h

2010-02-18 Thread Greg Stein
Oops. Had it backwards. Thanks! (tho I guess I can pester you that it should have been there when the bump happened... ;-) ) On Thu, Feb 18, 2010 at 03:53, rhuij...@apache.org wrote: Author: rhuijben Date: Thu Feb 18 08:53:48 2010 New Revision: 911288 URL:

Is sqlite fast enough?

2010-02-18 Thread Philip Martin
How fast are sqlite queries be compared to the old-wc entry caching? Operations like update benefit from faster locking, but in old-wc status does no locking at all. Also the multiple entries files give the data a tree-like organisation that is not modelled quite so well by an SQL table. Is

RE: Is sqlite fast enough?

2010-02-18 Thread Bert Huijben
-Original Message- From: Philip Martin [mailto:philip.mar...@wandisco.com] Sent: donderdag 18 februari 2010 19:22 To: dev@subversion.apache.org Subject: Is sqlite fast enough? How fast are sqlite queries be compared to the old-wc entry caching? Operations like update benefit

website navigation bar on IE7

2010-02-18 Thread Johan Corveleyn
A small nit on the new website: on IE 7, the left navigation bar seems slightly mis-indented. See screenshot in attachment. It looks like it's indented too much, making it appear to be right aligned. On IE 8 it shows up correctly though (meaning it seems ok to me, it's the same as in FF). Johan

Re: website navigation bar on IE7

2010-02-18 Thread C. Michael Pilato
Johan Corveleyn wrote: A small nit on the new website: on IE 7, the left navigation bar seems slightly mis-indented. See screenshot in attachment. It looks like it's indented too much, making it appear to be right aligned. On IE 8 it shows up correctly though (meaning it seems ok to me, it's

Re: [RFC] v2 Tree conflict resolver spec.

2010-02-18 Thread Neels J Hofmeyr
Daniel Näslund wrote: Hi Neels! Thanks for all your feedback! The use of the libsvn_wc terms BASE, WORKING and ACTUAL will be replaced by your suggested (or was it Julians?) checked-in state and checked-out state in the next version of the RFC. Hey father man :) I'd like to make sure

Re: svn commit: r911348 - /subversion/trunk/subversion/libsvn_wc/wc-metadata.sql

2010-02-18 Thread Greg Stein
On Thu, Feb 18, 2010 at 06:49, julianf...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_wc/wc-metadata.sql Thu Feb 18 11:49:25 2010 @@ -163,6 +163,12 @@  /* - */ + +/* The PRISTINE table keeps track

Re: [PATCH] Re: svn: Can't check path '/.svn/wc.db': Permission denied

2010-02-18 Thread Jon Daley
On Thu, 18 Feb 2010, Julian Foad wrote: Peter Samuelson wrote: [Stefan Sperling] Have you seen ^/subversion/branches/1.6.x-wc-ng-check-override ? I think that's the workaround you need. Log of the branch below. It's already nominated for backport, so if you like it, please vote :) I hadn't

Re: website navigation bar on IE7

2010-02-18 Thread Hyrum K. Wright
On Feb 18, 2010, at 11:22 PM, C. Michael Pilato wrote: Johan Corveleyn wrote: A small nit on the new website: on IE 7, the left navigation bar seems slightly mis-indented. See screenshot in attachment. It looks like it's indented too much, making it appear to be right aligned. On IE 8 it

Re: website navigation bar on IE7

2010-02-18 Thread Ivan Zhakov
On Fri, Feb 19, 2010 at 9:05 AM, Hyrum K. Wright hyrum_wri...@mail.utexas.edu wrote: On Feb 18, 2010, at 11:22 PM, C. Michael Pilato wrote: Johan Corveleyn wrote: A small nit on the new website: on IE 7, the left navigation bar seems slightly mis-indented. See screenshot in attachment. It