Re: Do we want 'svn patch' to be able to add empty files?

2010-09-04 Thread Branko Čibej
On 04.09.2010 02:44, Augie Fackler wrote: On Sep 3, 2010, at 7:10 AM, Daniel Näslund wrote: On Fri, Sep 03, 2010 at 12:18:37PM +0200, Branko Čibej wrote: On 02.09.2010 10:50, Branko Čibej wrote: Hmm, this is interesting. :) Git faithfully (blindly?) interprets Unix permission bits, whiles

Re: Do we want 'svn patch' to be able to add empty files?

2010-09-04 Thread Branko Čibej
On 04.09.2010 02:46, Augie Fackler wrote: On Sep 2, 2010, at 4:03 AM, Daniel Näslund wrote: $ svn diff --git Index: empty === diff --git a/trunk/empty b/trunk/empty new directory mode 10644 I'd recommend testing this

Re: [PATCH] don't do autoprops on symbolic links

2010-09-04 Thread Branko Čibej
On 03.09.2010 15:08, Stefan Sperling wrote: On Fri, Sep 03, 2010 at 08:58:09PM +0800, Wei-Yin Chen wrote: Sorry, that line should have been matching_filenames = [f for f in matching_filenames if not os.path.islink(dirname+'/'+f)] Hi, thanks for your patch! I think we should use os.sep

Re: [PATCH] don't do autoprops on symbolic links

2010-09-04 Thread Gavin Beau Baumanis
Hi Wei-Yin, Just thought I would mention that you did not attach your updated patch. Gavin Beau Baumanis E: ga...@thespidernet.com On 04/09/2010, at 2:19 PM, Wei-Yin Chen wrote: Hi Stefan, Thanks for your comment. I've updated the patch accordingly. Regards, Wei-Yin On Fri, Sep 3,

RE: Worried about single-db performance

2010-09-04 Thread Bert Huijben
-Original Message- From: justin.erenkra...@gmail.com [mailto:justin.erenkra...@gmail.com] On Behalf Of Justin Erenkrantz Sent: zaterdag 4 september 2010 8:33 To: Greg Stein Cc: Johan Corveleyn; Subversion Development Subject: Re: Worried about single-db performance On Fri, Sep

Re: Worried about single-db performance

2010-09-04 Thread Branko Čibej
On 04.09.2010 11:23, Bert Huijben wrote: -Original Message- From: justin.erenkra...@gmail.com [mailto:justin.erenkra...@gmail.com] On Behalf Of Justin Erenkrantz Sent: zaterdag 4 september 2010 8:33 To: Greg Stein Cc: Johan Corveleyn; Subversion Development Subject: Re: Worried

RE: [PROPOSAL] WC-NG: merge NODE_DATA, WORKING_NODE and BASE_NODE into a single table (NODES)

2010-09-04 Thread Bert Huijben
-Original Message- From: Greg Stein [mailto:gst...@gmail.com] Sent: zaterdag 4 september 2010 6:28 To: Bert Huijben Cc: Julian Foad; Erik Huelsmann; dev@subversion.apache.org Subject: Re: [PROPOSAL] WC-NG: merge NODE_DATA, WORKING_NODE and BASE_NODE into a single table (NODES)

Re: [PATCH] don't do autoprops on symbolic links

2010-09-04 Thread Wei-Yin Chen
Dear Gavin, Thanks. The attachment was in my sent box, but it's absent in the mailing archive. Don't know why. Per Branko's suggestion, I'm using join this time. In case the attachment gets missing again, it is also embedded in the mail body. Regards, Wei-Yin --- svn_apply_autoprops.py.old

[PATCH] Support command line options in svn_apply_autoprops.py

2010-09-04 Thread Wei-Yin Chen
Hi, This patch makes trunk/contrib/client-side/svn_apply_autoprops.py take command line options. The usage would be: svn_apply_autoprops.py [-c config_file] [paths to process...] The -c option specifies the configuration file name, and it overrides the setting in environment variable

Re: [PATCH] Support command line options in svn_apply_autoprops.py

2010-09-04 Thread Wei-Yin Chen
Sorry, don't know why the attachment was removed again. Does this mailing list have a strict Content-Type filter? I'm trying text/x-patch this time from my linux box. Type application/octet-stream doesn't seem to pass through. From web interface of the mailing archive, the format of the inlined

Re: Worried about single-db performance

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 2:23 AM, Bert Huijben b...@qqmail.nl wrote: SQLite also does a stat call per statement, unless there is already a shared lock open, just to check if there is no other process that opened a transaction. (On Windows this specific stat to check for other processes operating

Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
When compiled with SVN_DEBUG and SQLITE3_DEBUG and 'svn st' against a svn trunk WC, a number of things pop out. We perform 28,062 SQL queries. --- DBG: sqlite.c: 63: sql=select root, uuid from repository where id = 1; --- We execute *this* query (STMT_SELECT_REPOSITORY_BY_ID) 2215 times.

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: When compiled with SVN_DEBUG and SQLITE3_DEBUG and 'svn st' against a svn trunk WC, a number of things pop out. We perform 28,062 SQL queries. --- DBG: sqlite.c:  63: sql=select root, uuid from repository where

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: Notably, AFAICT, we're repeating a few of these queries: - STMT_SELECT_WORKING_NODE (2 times) - STMT_SELECT_ACTUAL_NODE (3 times) - STMT_SELECT_WORKING_PROPS (2 times) - STMT_SELECT_BASE_PROPS (2 times) I

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Justin Erenkrantz
On Sat, Sep 4, 2010 at 12:45 PM, Justin Erenkrantz jus...@erenkrantz.com wrote: I'm going to see what a quick check to retrieve just the kind and status will do for the query volume.  I think it's unlikely we have to pull everything out of sqlite to answer that basic question.  -- justin We

Re: svn commit: r990537 - /subversion/branches/performance/subversion/libsvn_subr/svn_temp_serializer.c

2010-09-04 Thread Johan Corveleyn
On Tue, Aug 31, 2010 at 11:35 PM, Johan Corveleyn jcor...@gmail.com wrote: Stefan, On Tue, Aug 31, 2010 at 10:07 PM, Johan Corveleyn jcor...@gmail.com wrote: Some additional info: - I couldn't reproduce the crash with a narrow range. Not even 9:0 would crash it (right after startup). - 

Re: [PATCH] Support command line options in svn_apply_autoprops.py

2010-09-04 Thread Hyrum K. Wright
Try renaming the file as a .txt ? -Hyrum On Sat, Sep 4, 2010 at 8:43 AM, Wei-Yin Chen wyc...@video.ee.ntu.edu.tw wrote: Sorry, don't know why the attachment was removed again. Does this mailing list have a strict Content-Type filter? I'm trying text/x-patch this time from my linux box. Type

Re: Repeated SQL queries when doing 'svn st'

2010-09-04 Thread Branko Čibej
On 04.09.2010 21:45, Justin Erenkrantz wrote: On Sat, Sep 4, 2010 at 10:18 AM, Justin Erenkrantz jus...@erenkrantz.com wrote: Notably, AFAICT, we're repeating a few of these queries: - STMT_SELECT_WORKING_NODE (2 times) - STMT_SELECT_ACTUAL_NODE (3 times) - STMT_SELECT_WORKING_PROPS (2

Re: [PROPOSAL] WC-NG: merge NODE_DATA, WORKING_NODE and BASE_NODE into a single table (NODES)

2010-09-04 Thread Hyrum K. Wright
On Sat, Sep 4, 2010 at 4:54 AM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: Greg Stein [mailto:gst...@gmail.com] Sent: zaterdag 4 september 2010 6:28 To: Bert Huijben Cc: Julian Foad; Erik Huelsmann; dev@subversion.apache.org Subject: Re: [PROPOSAL] WC-NG: merge