Re: Fix for issue 3620 - unlock command

2010-11-17 Thread Noorul Islam K M
Julian Foad writes: > On Mon, 2010-11-15, Noorul Islam K M wrote: > >> Noorul Islam K M writes: >> > Noorul Islam K M writes: >> >> Make 'svn unlock' verify that both working copy paths and URLs are >> >> not passed. >> >> >> >> * subversion/tests/cmdline/input_validation_tests.py >> >> (inva

[PATCH] Fix for issue 3620 - relocate command

2010-11-17 Thread Noorul Islam K M
Log [[[ Make 'svn relocate' verify that the target working copy root dir is local. * subversion/libsvn_client/relocate.c, subversion/svn/relocate-cmd.c (svn_client_relocate2, svn_cl__relocate): Raise an error if target working copy dir is not local. * subversion/tests/cmdline/input_valid

[PATCH] Fix for issue 3620 - switch command.

2010-11-17 Thread Noorul Islam K M
Log [[[ Make 'svn switch' verify that the target path is local. * subversion/libsvn_client/switch.c, subversion/svn/switch-cmd.c (svn_client_switch2, svn_cl__switch): Raise an error if target path is not local. * subversion/tests/cmdline/input_validation_tests.py (invalid_switch_target

Re: [PATCH] Re: test failure 1.6.14 (svnsync test 29 with bdb; copyfrom)

2010-11-17 Thread Daniel Shahaf
Daniel Shahaf wrote on Thu, Nov 18, 2010 at 06:07:07 +0200: > + SVN_ERR(svn_fs_node_history(&history, copyto_root, copyto_path, pool)); > + SVN_ERR(svn_fs_history_prev(&history_prev, history, TRUE /* cross copies > */, > + pool)); > + SVN_ERR(svn_fs_history_location

[PATCH] Re: test failure 1.6.14 (svnsync test 29 with bdb; copyfrom)

2010-11-17 Thread Daniel Shahaf
Stefan Sperling wrote on Thu, Nov 18, 2010 at 00:54:42 +0100: > With BDB, svnsync crashes as follows during during svnsync test 29. > It only happens with BDB. Running "./svnsync_tests.py 29 --fs-type=bdb" > triggers the problem for me on the 1.6.x branch, too. > > I guess this could be related to

RE: how to apply trademark symbols to Apache Subversion

2010-11-17 Thread Lawrence Rosen
Which trademarks are important here? > * Apache(tm) > * Subversion(r) > * Apache Subversion ... ?? The TM and R symbols are appropriate for the first two, because they are by far the most important marks referred to on that web page. Note that, because the first two are ASF marks, therefore the c

Re: svn commit: r1036078 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/fs.c libsvn_fs_base/tree.c libsvn_fs_base/tree.h libsvn_fs_fs/fs

2010-11-17 Thread Daniel Shahaf
Mike, this generates a compiler warning (see at the end): cmpil...@apache.org wrote on Wed, Nov 17, 2010 at 15:26:33 -: > Author: cmpilato > Date: Wed Nov 17 15:26:33 2010 > New Revision: 1036078 > > URL: http://svn.apache.org/viewvc?rev=1036078&view=rev > Log: > Fix a library dependency issu

Re: Issue triage: issues 3429 and 3474

2010-11-17 Thread Johan Corveleyn
On Wed, Nov 17, 2010 at 7:14 PM, Daniel Shahaf wrote: > Johan Corveleyn wrote on Wed, Nov 17, 2010 at 01:25:24 +0100: >> On Mon, Nov 8, 2010 at 1:02 PM, Philip Martin >> wrote: >> > Johan Corveleyn writes: >> > >> >> Or, maybe the best approach: I could add a regression test for these >> >> issu

Re: test failure 1.6.14 (svnsync test 29 with bdb; copyfrom)

2010-11-17 Thread Daniel Shahaf
Stefan Sperling wrote on Thu, Nov 18, 2010 at 00:54:42 +0100: > With BDB, svnsync crashes as follows during during svnsync test 29. > It only happens with BDB. Running "./svnsync_tests.py 29 --fs-type=bdb" > triggers the problem for me on the 1.6.x branch, too. > > I guess this could be related to

Re: test failure 1.6.14 (svnsync test 29 with bdb; copyfrom)

2010-11-17 Thread Paul Burba
Fails for me too: C:\SVN\src-branch-1.6.x>run.python.test.RELEASE.bat svnsync 29 -v --fs-type bdb C:\SVN\src-branch-1.6.x>set TESTNAME=svnsync C:\SVN\src-branch-1.6.x>set CONFIG=Release C:\SVN\src-branch-1.6.x>if not exist Release\subversion\tests\cmdline mkdir Release\subversion\tests\cmdline

test failure 1.6.14 (svnsync test 29 with bdb; copyfrom)

2010-11-17 Thread Stefan Sperling
With BDB, svnsync crashes as follows during during svnsync test 29. It only happens with BDB. Running "./svnsync_tests.py 29 --fs-type=bdb" triggers the problem for me on the 1.6.x branch, too. I guess this could be related to this backport item: * improve svnsync handling of dir copies (r96237

1.6.14 tarballs up for testing/signing

2010-11-17 Thread Hyrum K. Wright
1.6.14 tarballs are up for testing and signing. The magic revision is r1036150: http://people.apache.org/~hwright/svn/1.6.14/ In addition to sending your signatures to the mailing list, please use the new signature collection script, located here: http://work.hyrumwright.org/pub/svn/collect_sigs.

Re: svn commit: r1036078 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/fs.c libsvn_fs_base/tree.c libsvn_fs_base/tree.h libsvn_fs_fs/fs

2010-11-17 Thread C. Michael Pilato
On 11/17/2010 02:26 PM, Blair Zajac wrote: > On 11/17/2010 07:26 AM, cmpil...@apache.org wrote: >> Author: cmpilato >> Date: Wed Nov 17 15:26:33 2010 >> New Revision: 1036078 >> >> URL: http://svn.apache.org/viewvc?rev=1036078&view=rev >> Log: >> Fix a library dependency issue which was causing bui

Re: [Issue 3716] svnrdump does not support cancellation

2010-11-17 Thread Daniel Shahaf
Thanks! cmpil...@tigris.org wrote on Wed, Nov 17, 2010 at 11:10:57 -0800: > http://subversion.tigris.org/issues/show_bug.cgi?id=3716 > > > > User cmpilato changed the following: > > What|Old value |New value >

Re: svn commit: r1036078 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_fs/fs-loader.h libsvn_fs_base/fs.c libsvn_fs_base/tree.c libsvn_fs_base/tree.h libsvn_fs_fs/fs

2010-11-17 Thread Blair Zajac
On 11/17/2010 07:26 AM, cmpil...@apache.org wrote: Author: cmpilato Date: Wed Nov 17 15:26:33 2010 New Revision: 1036078 URL: http://svn.apache.org/viewvc?rev=1036078&view=rev Log: Fix a library dependency issue which was causing build failures. (As a general rule, code inside the FS providers

Re: Backport review - r1035992 in branches/1.6.x-r917523: ./ subversion/mod_dav_svn/mirror.c

2010-11-17 Thread Julian Foad
On Wed, 2010-11-17 at 18:57 +, Julian Foad wrote: > I've reviewed and tested this change. Here are the results. Executive > summary: basically works in the simple case, but I have too many > reservations to give a +1. A couple more points: * I mentioned we should consider canonicalization a

Re: svn commit: r1036138 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-11-17 Thread C. Michael Pilato
On 11/17/2010 01:22 PM, C. Michael Pilato wrote: > On 11/17/2010 01:07 PM, Daniel Shahaf wrote: >> Hmm. I realize this is preexisting code, but the bit about "external >> locking" doesn't apply to svnrdump, since unlike svnsync it doesn't have >> a --use-external-locking flag. > > I *knew* there

Backport review - r1035992 in branches/1.6.x-r917523: ./ subversion/mod_dav_svn/mirror.c

2010-11-17 Thread Julian Foad
I've reviewed and tested this change. Here are the results. Executive summary: basically works in the simple case, but I have too many reservations to give a +1. The patch attempts to fix DAV mirroring when the Location directive value contains a space, such as . For the original log message of

Re: svn commit: r1036138 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-11-17 Thread C. Michael Pilato
On 11/17/2010 01:07 PM, Daniel Shahaf wrote: >> - err = svn_error_create( >> - SVN_ERR_UNSUPPORTED_FEATURE, NULL, >> - _("Target server does not support atomic revision property " >> -"edits; consider upgrading it to 1.7 or using an external " >> -

Re: Issue triage: issues 3429 and 3474

2010-11-17 Thread Daniel Shahaf
Johan Corveleyn wrote on Wed, Nov 17, 2010 at 01:25:24 +0100: > On Mon, Nov 8, 2010 at 1:02 PM, Philip Martin > wrote: > > Johan Corveleyn writes: > > > >> Or, maybe the best approach: I could add a regression test for these > >> issues, so we can all be sure that they are fixed (and remain fixed

Re: svn commit: r1036138 - /subversion/trunk/subversion/svnrdump/load_editor.c

2010-11-17 Thread Daniel Shahaf
> - err = svn_error_create( > - SVN_ERR_UNSUPPORTED_FEATURE, NULL, > - _("Target server does not support atomic revision property " > -"edits; consider upgrading it to 1.7 or using an external " > -"locking program")); > + /* Pre-1

Re: how to apply trademark symbols to Apache Subversion

2010-11-17 Thread C. Michael Pilato
On 11/17/2010 10:35 AM, Greg Stein wrote: > On Wed, Nov 17, 2010 at 09:08, C. Michael Pilato wrote: >> On 11/17/2010 08:56 AM, Greg Stein wrote: >>> Hi Legal peeps, >>> >>> The Subversion community updated the website to conform to the new >>> guidelines, but we have a question on how to apply the

Re: how to apply trademark symbols to Apache Subversion

2010-11-17 Thread Greg Stein
On Wed, Nov 17, 2010 at 09:08, C. Michael Pilato wrote: > On 11/17/2010 08:56 AM, Greg Stein wrote: >> Hi Legal peeps, >> >> The Subversion community updated the website to conform to the new >> guidelines, but we have a question on how to apply the appropriate >> trademark symbols. The guideline

Re: svn commit: r1035894 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_client/ subversion/libsvn_fs/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/

2010-11-17 Thread Paul Burba
On Wed, Nov 17, 2010 at 5:45 AM, Julian Foad wrote: > Hi Paul. > > On Wed, 2010-11-17, pbu...@apache.org wrote: >> Log: >> Reintegrate the issue-3668-3669 branch. > > If you could insert a summary of this change here in the log message, > that would be helpful. Sure thing, I added a bit more expl

Re: Windows svnsync test suite failures and a clue

2010-11-17 Thread Paul Burba
On Wed, Nov 17, 2010 at 8:31 AM, Daniel Shahaf wrote: > Paul Burba wrote on Tue, Nov 16, 2010 at 17:55:30 -0500: >> As some of you know I've recently had some strange failures with the >> svnsync tests on both trunk and 1.6.x.  All the tests started failing >> during setup when the stdout of svnsy

Re: how to apply trademark symbols to Apache Subversion

2010-11-17 Thread C. Michael Pilato
On 11/17/2010 08:56 AM, Greg Stein wrote: > Hi Legal peeps, > > The Subversion community updated the website to conform to the new > guidelines, but we have a question on how to apply the appropriate > trademark symbols. The guideline says to put a (tm) at the end of the > first use of "Apache Sub

how to apply trademark symbols to Apache Subversion

2010-11-17 Thread Greg Stein
Hi Legal peeps, The Subversion community updated the website to conform to the new guidelines, but we have a question on how to apply the appropriate trademark symbols. The guideline says to put a (tm) at the end of the first use of "Apache Subversion", however, "Subversion" (alone) is a *register

Re: The new "warning: The depth of this commit is 'empty', but copied dirs ..."

2010-11-17 Thread Julian Foad
On Wed, 2010-11-17, Stefan Sperling wrote: > On Wed, Nov 17, 2010 at 12:04:21PM +, Julian Foad wrote: > > I think it would be better if we only issue this warning when the > > proposed commit does in fact include a copy, otherwise it's going to be > > too much noise. > > > > Thoughts? > > Th

Re: Windows svnsync test suite failures and a clue

2010-11-17 Thread Daniel Shahaf
Paul Burba wrote on Tue, Nov 16, 2010 at 17:55:30 -0500: > As some of you know I've recently had some strange failures with the > svnsync tests on both trunk and 1.6.x. All the tests started failing > during setup when the stdout of svnsync init was lost, e.g.: > > [[[ > CMD: svnsync.exe initiali

Re: svn commit: r1035894 - undefined reference to 'svn_fs_validate_mergeinfo'

2010-11-17 Thread Daniel Shahaf
Julian Foad wrote on Wed, Nov 17, 2010 at 10:18:05 +: > Since r1035894 I'm getting a link error on Linux (and so is Noorul): > > cd subversion/libsvn_fs_fs && /usr/share/apr-1.0/build/libtool --tag=CC > --silent --mode=link gcc -W[...] -D[...] -g -pthread > -rpath /home/julianfoad/local/subve

Re: The new "warning: The depth of this commit is 'empty', but copied dirs ..."

2010-11-17 Thread Stefan Sperling
On Wed, Nov 17, 2010 at 12:04:21PM +, Julian Foad wrote: > Today I committed the result of a merge, which included mergeinfo change > on ".", but I didn't want to include a file that I have locally modified > for testing purposes, so I explicitly specified "." and the required > target file. >

The new "warning: The depth of this commit is 'empty', but copied dirs ..."

2010-11-17 Thread Julian Foad
Today I committed the result of a merge, which included mergeinfo change on ".", but I didn't want to include a file that I have locally modified for testing purposes, so I explicitly specified "." and the required target file. [[[ svn commit -N -m "..." . subversion/mod_dav_svn/mirror.c svn: warn

Re: scan_deletion - why?

2010-11-17 Thread Philip Martin
Julian Foad writes: > To expand: I may not be the brightest kid on the block but I find that > with hours of effort I still can't see precisely what many of these > functions are *trying* to do. (Obviously I can see precisely what they > *are* doing in terms of shuffling bits around.) I am extr

Re: svn commit: r1035894 - in /subversion/trunk: ./ subversion/include/ subversion/include/private/ subversion/libsvn_client/ subversion/libsvn_fs/ subversion/libsvn_fs_base/ subversion/libsvn_fs_fs/

2010-11-17 Thread Julian Foad
Hi Paul. On Wed, 2010-11-17, pbu...@apache.org wrote: > Log: > Reintegrate the issue-3668-3669 branch. If you could insert a summary of this change here in the log message, that would be helpful. I see it's ... rather large. > Modified: > subversion/trunk/ (props changed) > subversion

Re: scan_deletion - why?

2010-11-17 Thread Julian Foad
On Tue, 2010-11-16, Greg Stein wrote: > I'm not sure that I understand the goal here. Is there a problem that > is trying to be solved? If not, then I'd recommend just marking this > down as an item to "review in 1.8". Quting myself: "My goals: to be able to understand the callers, and then adapt

Re: svn commit: r1035894 - undefined reference to 'svn_fs_validate_mergeinfo'

2010-11-17 Thread Julian Foad
Since r1035894 I'm getting a link error on Linux (and so is Noorul): cd subversion/libsvn_fs_fs && /usr/share/apr-1.0/build/libtool --tag=CC --silent --mode=link gcc -W[...] -D[...] -g -pthread -rpath /home/julianfoad/local/subversion-d/lib -Wl,--no-undefined -o libsvn_fs_fs-1.la caching.lo dag.