Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Sat, 2011-01-08, Hyrum K Wright wrote: On Fri, Jan 7, 2011 at 10:06 AM, Julian Foad julian.f...@wandisco.com wrote: On Fri, 2011-01-07 at 15:19 +, Philip Martin wrote: Julian Foad julian.f...@wandisco.com writes: The only case that SQLite doesn't handle automatically is the

[PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Prabhu Gnana Sundar
Hi all, Currently, when creating a repo, svnadmin accepts the --config-dir option. But clearly, the code does not use the 'config' option being passed. Hence I am passing NULL value instead of sending the 'config' value. This change has passed all the tests and is working fine. I have

[RFC] Require SQLite = 3.6.18

2011-01-11 Thread Julian Foad
Any objection to requiring SQLite = 3.6.18 as in the attached patch? WHY? In order to use SQLite triggers to automatically update the pristine text reference counts (see the thread Ref-counting for pristine texts: http://svn.haxx.se/dev/archive-2011-01/0104.shtml), we have to either * enable

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11, Julian Foad wrote: The complete patch (with log message) is attached. Any review would be appreciated. To be more specific: I'm happy with the way this patch uses triggers to inc and dec the ref counts. Review of impl details here would be appreciated. I'm not 100% sure

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 08:20 AM, Julian Foad wrote: I'm not 100% sure whether close_wcroot() is the best place to delete unreferenced pristines. Review of the concept would be useful here, in comparison with other options such as deleting after flushing the work queue or at some other place. Just

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 09:01 AM, Mark Phippard wrote: On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato cmpil...@collab.net wrote: On 01/11/2011 08:20 AM, Julian Foad wrote: I'm not 100% sure whether close_wcroot() is the best place to delete unreferenced pristines. Review of the concept would be

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11 at 09:01 -0500, Mark Phippard wrote: On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato cmpil...@collab.net wrote: On 01/11/2011 08:20 AM, Julian Foad wrote: I'm not 100% sure whether close_wcroot() is the best place to delete unreferenced pristines. Review of the

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 09:19 AM, Julian Foad wrote: I think it would be an embarrassing regression. Only a few people would ever actually bother to read the release notes and do regular svn cleanups before their disks fill up. I dunno about regression. My 1.6 working copies routinely have many, many

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 8:07 AM, C. Michael Pilato cmpil...@collab.net wrote: On 01/11/2011 09:01 AM, Mark Phippard wrote: On Tue, Jan 11, 2011 at 8:43 AM, C. Michael Pilato cmpil...@collab.net wrote: On 01/11/2011 08:20 AM, Julian Foad wrote: I'm not 100% sure whether close_wcroot() is the

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11, C. Michael Pilato wrote: On 01/11/2011 09:19 AM, Julian Foad wrote: I think it would be an embarrassing regression. Only a few people would ever actually bother to read the release notes and do regular svn cleanups before their disks fill up. I dunno about

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Branko Čibej
On 11.01.2011 16:01, Julian Foad wrote: I see a different issue here: The close_wcroot() call is normally handled from pool cleanup for users of the svn_client api. (The svn_wc_context_t is cached in the client context, which is only closed on pool cleanup). Thanks for pointing that out.

Re: [PATCH] pass NULL instead of an unused parameter

2011-01-11 Thread Daniel Shahaf
C. Michael Pilato wrote on Tue, Jan 11, 2011 at 10:03:23 -0500: On 01/11/2011 07:17 AM, Prabhu Gnana Sundar wrote: Hi Kamesh, On Tuesday 11 January 2011 05:23 PM, Kamesh Jayachandran wrote: Hi Prabhu, SVN_ERR(svn_config_get_config(config, opt_state-config_dir, pool));

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Ramkumar Ramachandra
Hi Julian and Daniel, Here's another revision after your suggestions on IRC. Thanks. [[[ Determine default perms in an elegant thread-safe way, not racily. * subversion/libsvn_subr/io.c (default_perms_baton, perms_init_state): New struct, variable. (get_default_file_perms): Remove all

Re: [PATCH in progress] Ref-counting for pristine texts

2011-01-11 Thread Julian Foad
Branko Čibej wrote: On 11.01.2011 16:01, Julian Foad wrote: I see a different issue here: The close_wcroot() call is normally handled from pool cleanup for users of the svn_client api. (The svn_wc_context_t is cached in the client context, which is only closed on pool cleanup). Thanks

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Daniel Shahaf
I believe this is semantically correct. Ramkumar, Julian: is the struct still needed? IIRC the reasons for originally introducing (namely the 'volatile' qualifier) it have since disappeared. Daniel Ramkumar Ramachandra wrote on Tue, Jan 11, 2011 at 21:33:33 +0530: Hi Julian and Daniel,

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Julian Foad
On Tue, 2011-01-11, Daniel Shahaf wrote: I believe this is semantically correct. Ramkumar, Julian: is the struct still needed? IIRC the reasons for originally introducing (namely the 'volatile' qualifier) it have since disappeared. It's not strictly needed but it's a good way to structure

Re: svn commit: r1004286 - in /subversion/trunk: ./ subversion/libsvn_subr/io.c

2011-01-11 Thread Daniel Shahaf
Daniel Shahaf wrote on Tue, Jan 11, 2011 at 18:34:57 +0200: Ramkumar Ramachandra wrote on Tue, Jan 11, 2011 at 21:33:33 +0530: - /* Get the perms for a newly created file to find out what bits -should be set. - -Normally del_on_close can be problematic because APR

Re: Feature Request: [Was: Best way to maintain patches to a 3rd party library?]

2011-01-11 Thread Daniel Shahaf
Stefan Sperling wrote on Tue, Jan 11, 2011 at 19:02:00 +0100: See here: http://subversion.apache.org/faq.html#multi-merge This contains a broken link to http://subversion.apache.org/links.html#misc_utils.

Canonicalizing relative URLs

2011-01-11 Thread C. Michael Pilato
I'm looking at issue #3601, and am reworking the way that svn_uri_canonicalize() behaves -- namely, I'm teaching it to normalize the case of hex-digit pairs (of the %AB variety) for all URIs, not just URLs. (Currently, it does this only for URIs with scheme data.) But I find myself with a small

Re: svn commit: r1057908 - /subversion/trunk/subversion/libsvn_client/patch.c

2011-01-11 Thread Hyrum K Wright
On Tue, Jan 11, 2011 at 4:56 PM, s...@apache.org wrote: Author: stsp Date: Tue Jan 11 22:56:34 2011 New Revision: 1057908 URL: http://svn.apache.org/viewvc?rev=1057908view=rev Log: Significantly reduce the time spent by svn patch to figure out whether there are empty directories to be

RE: Canonicalizing relative URLs

2011-01-11 Thread Bert Huijben
-Original Message- From: C. Michael Pilato [mailto:cmpil...@gmail.com] On Behalf Of C. Michael Pilato Sent: dinsdag 11 januari 2011 22:16 To: Subversion Development Subject: Canonicalizing relative URLs I'm looking at issue #3601, and am reworking the way that

Re: Canonicalizing relative URLs

2011-01-11 Thread C. Michael Pilato
On 01/11/2011 06:21 PM, Bert Huijben wrote: -Original Message- From: C. Michael Pilato [mailto:cmpil...@gmail.com] On Behalf Of C. Michael Pilato Sent: dinsdag 11 januari 2011 22:16 To: Subversion Development Subject: Canonicalizing relative URLs I'm looking at issue #3601, and

[l10n] Translation status report for trunk r1057984

2011-01-11 Thread SVN DEV
X-Mailer: l10n-report.py r1055713 Reply-To: dev@subversion.apache.org Mail-Followup-To: dev@subversion.apache.org Auto-Submitted: auto-generated Translation status report for tr...@r1057984 lang trans untrans fuzzy obs -- de2051 126