Re: crash during svn blame on windows 64-bit version

2011-03-03 Thread Stefan Fuhrmann
On 24.02.2011 08:53, Marc Haesen wrote: I saw a crash when running svn blame with a svn.exe compiled for win64 on trunk. After some investigation I found the reason for the crash. The reason is because apr.h is using the define WIN64 for defining the APR_SIZEOF_VOIDP define. (I am using the

RE: svn commit: r1076556 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c libsvn_subr/eol.c

2011-03-03 Thread Bert Huijben
-Original Message- From: stef...@apache.org [mailto:stef...@apache.org] Sent: donderdag 3 maart 2011 9:45 To: comm...@subversion.apache.org Subject: svn commit: r1076556 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c libsvn_subr/eol.c Author: stefan2 Date: Thu Mar

Re: Last batch of performance improvements for 1.7

2011-03-03 Thread Arnout van Meer
On 3 March 2011 08:36, Stefan Fuhrmann eq...@web.de wrote: Hi Arnout, Thanks for your review! See my answers below. -- Stefan^2. On 28.02.2011 23:36, Arnout van Meer wrote: On 23 February 2011 08:43, Stefan Fuhrmannstefanfuhrm...@alice-dsl.de   wrote: List of integration branches:

Re: Last batch of performance improvements for 1.7

2011-03-03 Thread Arnout van Meer
On 3 March 2011 11:42, Arnout van Meer rr2...@splashdamage.com wrote: On 3 March 2011 08:36, Stefan Fuhrmann eq...@web.de wrote: Hi Arnout, Thanks for your review! See my answers below. -- Stefan^2. On 28.02.2011 23:36, Arnout van Meer wrote: On 23 February 2011 08:43, Stefan

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 9:03 AM, phi...@apache.org wrote: Author: philip Date: Thu Mar  3 15:03:42 2011 New Revision: 1076645 URL: http://svn.apache.org/viewvc?rev=1076645view=rev Log: Wrap pointer in a baton to avoid a complier warning or cast. I think a single cast is better than the

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Greg Stein
On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright hy...@hyrumwright.org wrote: On Thu, Mar 3, 2011 at 9:03 AM,  phi...@apache.org wrote: Author: philip Date: Thu Mar  3 15:03:42 2011 New Revision: 1076645 URL: http://svn.apache.org/viewvc?rev=1076645view=rev Log: Wrap pointer in a baton to

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Philip Martin
Greg Stein gst...@gmail.com writes: On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright hy...@hyrumwright.org wrote: On Thu, Mar 3, 2011 at 9:03 AM,  phi...@apache.org wrote: Author: philip Date: Thu Mar  3 15:03:42 2011 New Revision: 1076645 URL: http://svn.apache.org/viewvc?rev=1076645view=rev

Re: [PATCH] Fix for issue 3826

2011-03-03 Thread Julian Foad
On Wed, 2011-03-02, Noorul Islam K M wrote: Please find attached patch for issue 3826. All tests pass using 'make check' [...] Index: subversion/svn/diff-cmd.c === --- subversion/svn/diff-cmd.c (revision 1076214) +++

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Branko Čibej
On 03.03.2011 17:33, Philip Martin wrote: Greg Stein gst...@gmail.com writes: On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright hy...@hyrumwright.org wrote: On Thu, Mar 3, 2011 at 9:03 AM, phi...@apache.org wrote: Author: philip Date: Thu Mar 3 15:03:42 2011 New Revision: 1076645 URL:

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Julian Foad
On Thu, 2011-03-03 at 16:33 +, Philip Martin wrote: Greg Stein gst...@gmail.com writes: On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright hy...@hyrumwright.org wrote: On Thu, Mar 3, 2011 at 9:03 AM, phi...@apache.org wrote: Author: philip Date: Thu Mar 3 15:03:42 2011 New Revision:

Re: [PATCH] - Fix for issue #3792

2011-03-03 Thread Noorul Islam K M
Stefan Sperling s...@elego.de writes: On Sat, Feb 05, 2011 at 12:55:55PM +0530, Noorul Islam K M wrote: Daniel Shahaf d...@daniel.shahaf.name writes: @@ -363,6 +364,9 @@ SVN_ERR(svn_cmdline_printf(pool, _(Copied From Rev: %ld\n),

Re: [PATCH] Fix for issue 3826

2011-03-03 Thread Noorul Islam K M
Julian Foad julian.f...@wandisco.com writes: On Wed, 2011-03-02, Noorul Islam K M wrote: Please find attached patch for issue 3826. All tests pass using 'make check' [...] Index: subversion/svn/diff-cmd.c === ---

Re: [PATCH] - Fix for issue #3792

2011-03-03 Thread Stefan Sperling
On Thu, Mar 03, 2011 at 10:39:11PM +0530, Noorul Islam K M wrote: @@ -164,9 +171,18 @@ if (tmpinfo-depth == svn_depth_unknown) tmpinfo-depth = svn_depth_infinity; - SVN_ERR(svn_wc__node_get_schedule(tmpinfo-schedule, NULL, -wc_ctx,

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Greg Stein
On Thu, Mar 3, 2011 at 11:47, Julian Foad julian.f...@wandisco.com wrote: On Thu, 2011-03-03 at 16:33 +, Philip Martin wrote: Greg Stein gst...@gmail.com writes: On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright hy...@hyrumwright.org wrote: On Thu, Mar 3, 2011 at 9:03 AM,  phi...@apache.org

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 10:47 AM, Julian Foad julian.f...@wandisco.com wrote: On Thu, 2011-03-03 at 16:33 +, Philip Martin wrote: Greg Stein gst...@gmail.com writes: On Thu, Mar 3, 2011 at 10:35, Hyrum K Wright hy...@hyrumwright.org wrote: On Thu, Mar 3, 2011 at 9:03 AM,  

Breakage on trunk?

2011-03-03 Thread John Beranek
Hi, This afternoon, I checked out the trunk from Subversion in order to build a dev system running 1.7. I updated a sandbox I had lying around, made it 'extraclean', built and installed serf 0.7.1, ran autogen.sh, ran configure (with --prefix /usr/local/subversion-1.7 --with-serf=/usr/local),

Re: svn commit: r1076645 - /subversion/trunk/subversion/libsvn_wc/wc_db.c

2011-03-03 Thread Philip Martin
Greg Stein gst...@gmail.com writes: It is a lot of crap just to avoid a single cast. It makes the code more complicated than it needs to be. I don't see the cast as an improvement but I won't object if somebody changes it (a bit like one variable declaration per line which I think is crap :)

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
John Beranek j...@redux.org.uk writes: This afternoon, I checked out the trunk from Subversion in order to build a dev system running 1.7. I updated a sandbox I had lying around, made it 'extraclean', built and installed serf 0.7.1, ran autogen.sh, ran configure (with --prefix

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

2011-03-03 Thread C. Michael Pilato
On 03/03/2011 01:15 PM, s...@apache.org wrote: Author: stsp Date: Thu Mar 3 18:15:46 2011 New Revision: 1076712 URL: http://svn.apache.org/viewvc?rev=1076712view=rev Log: As a first step towards eliminating use of the node walker in svn_wc_revision_status2(), use a DB query to determine

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

2011-03-03 Thread Stefan Sperling
On Thu, Mar 03, 2011 at 07:48:22PM +0100, Stefan Sperling wrote: On Thu, Mar 03, 2011 at 01:40:55PM -0500, C. Michael Pilato wrote: On 03/03/2011 01:15 PM, s...@apache.org wrote: Author: stsp Date: Thu Mar 3 18:15:46 2011 New Revision: 1076712 URL:

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

2011-03-03 Thread C. Michael Pilato
On 03/03/2011 01:48 PM, Stefan Sperling wrote: On Thu, Mar 03, 2011 at 01:40:55PM -0500, C. Michael Pilato wrote: On 03/03/2011 01:15 PM, s...@apache.org wrote: Author: stsp Date: Thu Mar 3 18:15:46 2011 New Revision: 1076712 URL: http://svn.apache.org/viewvc?rev=1076712view=rev Log: As

Re: svn commit: r1076712 - in /subversion/trunk/subversion/libsvn_wc: revision_status.c wc-queries.sql wc_db.c wc_db.h

2011-03-03 Thread C. Michael Pilato
On 03/03/2011 01:50 PM, Stefan Sperling wrote: I think that, going forward, we'll need a better representation of externals in the DB in order to be able to make queries consider them in a more straightforward way. Hmmm... until then, we could probably use this hack in the NODES table:

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
John Beranek j...@redux.org.uk writes: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: Am I doing something stupid, or is there some breakage on the trunk? Some, but not that. http://subversion.apache.org/buildbot Do the regression tests pass on

Subversion 1.6.16 Released

2011-03-03 Thread Hyrum Wright
I'm happy to announce Subversion 1.6.16, available from: http://subversion.tigris.org/downloads/subversion-1.6.16.tar.bz2 http://subversion.tigris.org/downloads/subversion-1.6.16.tar.gz http://subversion.tigris.org/downloads/subversion-1.6.16.zip

Re: Breakage on trunk?

2011-03-03 Thread John Beranek
On 03/03/2011 19:38, John Beranek wrote: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: This afternoon, I checked out the trunk from Subversion in order to build a dev system running 1.7. I updated a sandbox I had lying around, made it 'extraclean', built

Re: Breakage on trunk?

2011-03-03 Thread John Beranek
On 03/03/2011 20:01, Philip Martin wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: Am I doing something stupid, or is there some breakage on the trunk? That looks like a problem with your build, tests.log

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
John Beranek j...@redux.org.uk writes: On 03/03/2011 20:01, Philip Martin wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: Am I doing something stupid, or is there some breakage on the trunk? That looks

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
John Beranek j...@redux.org.uk writes: On 03/03/2011 20:01, Philip Martin wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: Am I doing something stupid, or is there some breakage on the trunk? That looks

Re: Breakage on trunk?

2011-03-03 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 2:48 PM, Philip Martin philip.mar...@wandisco.com wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 20:01, Philip Martin wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: Am I

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
Hyrum K Wright hy...@hyrumwright.org writes: Random observation from the sideline: It appears that the failure is happening in the code which Stefan^2 recently merged. As this code is relatively new, it may not have been very well exercised on the branch or on trunk. We shouldn't discount

Re: Breakage on trunk?

2011-03-03 Thread John Beranek
On 03/03/2011 20:48, Philip Martin wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 20:01, Philip Martin wrote: John Beranek j...@redux.org.uk writes: On 03/03/2011 18:30, Philip Martin wrote: John Beranek j...@redux.org.uk writes: Am I doing something stupid, or is there

Subversion 1.7 through (squid) proxy

2011-03-03 Thread John Beranek
Following on from my earlier post, I thought I'd use my trunk Subversion (built with ra_serf) to access some external Subversion repositories from work. To get access I have to use the corporate Squid proxy, and that all works with the Subversion clients I've previously used. However, when I try

Re: Subversion 1.7 through (squid) proxy

2011-03-03 Thread John Beranek
On 03/03/2011 22:12, John Beranek wrote: Has HTTPv2 been tested through a proxy at all? Note: I have ensured Squid is compliled to support a number of additional HTTP methods to support Subversion: Sorry, s/compiled/configured/ John. -- John Beranek To generalise

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Hyrum K Wright hy...@hyrumwright.org writes: Random observation from the sideline: It appears that the failure is happening in the code which Stefan^2 recently merged. As this code is relatively new, it may not have been very well exercised

Re: Subversion 1.7 through (squid) proxy

2011-03-03 Thread Mark Phippard
Try using Neon. I believe Squid does not support HTTP 1.1 and does not work with Serf. Sent from my iPhone On Mar 3, 2011, at 5:12 PM, John Beranek j...@redux.org.uk wrote: Following on from my earlier post, I thought I'd use my trunk Subversion (built with ra_serf) to access some external

Re: svn commit: r1076854 - in /subversion/trunk/subversion: libsvn_diff/diff_file.c libsvn_subr/eol.c

2011-03-03 Thread Hyrum K Wright
On Thu, Mar 3, 2011 at 4:37 PM, stef...@apache.org wrote: Author: stefan2 Date: Thu Mar  3 22:37:52 2011 New Revision: 1076854 URL: http://svn.apache.org/viewvc?rev=1076854view=rev Log: Follow-up to r1076846. * subversion/libsvn_diff/diff_file.c, subversion/libsvn_subr/eol.c: These

Re: Subversion 1.7 through (squid) proxy

2011-03-03 Thread Philip Martin
John Beranek j...@redux.org.uk writes: On 03/03/2011 22:12, John Beranek wrote: Has HTTPv2 been tested through a proxy at all? Note: I have ensured Squid is compliled to support a number of additional HTTP methods to support Subversion: Sorry, s/compiled/configured/ You need a proxy

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: There does appear to be a bug on trunk: $ valgrind --num-callers=20 -q ./.libs/lt-client-test 3 ==26565== Conditional jump or move depends on uninitialised value(s) ==26565==at 0x4C2367A: bcmp (mc_replace_strmem.c:541) Fixed by r1076872.

Re: Subversion 1.7 through (squid) proxy

2011-03-03 Thread John Beranek
On 03/03/2011 22:42, Mark Phippard wrote: Try using Neon. I believe Squid does not support HTTP 1.1 and does not work with Serf. Ah, well I specifically built with serf, because one of the major things I wanted to test was the performance enhancements in the HTTP protocol, and the release

Re: Breakage on trunk?

2011-03-03 Thread John Beranek
On 03/03/2011 23:08, Philip Martin wrote: Philip Martin philip.mar...@wandisco.com writes: There does appear to be a bug on trunk: $ valgrind --num-callers=20 -q ./.libs/lt-client-test 3 ==26565== Conditional jump or move depends on uninitialised value(s) ==26565==at 0x4C2367A: bcmp

Re: Breakage on trunk?

2011-03-03 Thread John Beranek
On 03/03/2011 23:27, John Beranek wrote: On 03/03/2011 23:08, Philip Martin wrote: Philip Martin philip.mar...@wandisco.com writes: There does appear to be a bug on trunk: $ valgrind --num-callers=20 -q ./.libs/lt-client-test 3 ==26565== Conditional jump or move depends on uninitialised

Re: Breakage on trunk?

2011-03-03 Thread Philip Martin
John Beranek j...@redux.org.uk writes: Forgot to note, same assertion failure: START: client-test lt-client-test: subversion/libsvn_subr/svn_temp_serializer.c:282: svn_temp_deserializer__resolve: Assertion `*ptr buffer' failed. A stack trace please: $ cd subversion/tests/libsvn_client $

Re: [PATCH] - Fix for issue #3792

2011-03-03 Thread Noorul Islam K M
Stefan Sperling s...@elego.de writes: On Thu, Mar 03, 2011 at 10:39:11PM +0530, Noorul Islam K M wrote: @@ -164,9 +171,18 @@ if (tmpinfo-depth == svn_depth_unknown) tmpinfo-depth = svn_depth_infinity; - SVN_ERR(svn_wc__node_get_schedule(tmpinfo-schedule, NULL, -

Re: Subversion 1.7 through (squid) proxy

2011-03-03 Thread Ivan Zhakov
On Fri, Mar 4, 2011 at 01:12, John Beranek j...@redux.org.uk wrote: Following on from my earlier post, I thought I'd use my trunk Subversion (built with ra_serf) to access some external Subversion repositories from work. To get access I have to use the corporate Squid proxy, and that all