Re: FSFS caching doc strings

2011-06-26 Thread Stefan Fuhrmann
On 15.06.2011 10:25, Julian Foad wrote: Stefan2, I'm posting this attempt to add more detail to some of the FSFS caching doc strings. It's incomplete but I've had this sitting in my WC for a couple of weeks now and am unlikely to look deeper in the short term. Thanks for the suggestions! [[[ I

Re: svn commit: r1139573 - /subversion/trunk/subversion/libsvn_ra_serf/util.c

2011-06-26 Thread Justin Erenkrantz
On Sat, Jun 25, 2011 at 12:50 PM, Ivan Zhakov wrote: >> Why apr_fnmatch() here? These aren't filenames. Shouldn't this just be >> a case-insensitive string compare? >> > I think because of wildcard certificates, e.g  *.example.com. Yup - what he said. -- justin

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: "XX\n", Expected: "Cc\n\n"

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 11:32 PM, Johan Corveleyn wrote: > On Sun, Jun 26, 2011 at 11:08 PM, Johan Corveleyn wrote: >> On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf >> wrote: >>> libsvn_diff/diff-diff3-test 2 >>> fails for me: >>> >>> [[[ >>> subversion/tests/libsvn_diff/diff-diff3-test.c:653:

Re: [sqlite] PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-26 Thread Richard Hipp
On Sun, Jun 26, 2011 at 7:28 PM, Richard Hipp wrote: > On Sun, Jun 26, 2011 at 6:52 PM, Richard Hipp wrote: > >> The big mystery is why this problem is not showing up in our rather >> extensive test suite. I'm still investigating that aspect of the issue. >> >> > > The reason our tests didn't p

Re: [sqlite] PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-26 Thread Daniel Shahaf
Greg Stein wrote on Sun, Jun 26, 2011 at 19:20:30 -0400: > On Sun, Jun 26, 2011 at 18:52, Richard Hipp wrote: > > On Sun, Jun 26, 2011 at 3:59 PM, Greg Stein wrote: > > > >> Hey all, > >> > >> There is a bug in 3.7.7 that affects Apache Subversion. We've verified > >> that it is this latest relea

Re: [sqlite] PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-26 Thread Richard Hipp
On Sun, Jun 26, 2011 at 6:52 PM, Richard Hipp wrote: > The big mystery is why this problem is not showing up in our rather > extensive test suite. I'm still investigating that aspect of the issue. > > The reason our tests didn't pick up on this is that the error only occurs if you use the older

Re: [sqlite] PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-26 Thread Greg Stein
On Sun, Jun 26, 2011 at 18:52, Richard Hipp wrote: > On Sun, Jun 26, 2011 at 3:59 PM, Greg Stein wrote: > >> Hey all, >> >> There is a bug in 3.7.7 that affects Apache Subversion. We've verified >> that it is this latest release, as prior releases have worked just >> fine for us. >> >> Below is t

Re: [sqlite] PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-26 Thread Richard Hipp
On Sun, Jun 26, 2011 at 3:59 PM, Greg Stein wrote: > Hey all, > > There is a bug in 3.7.7 that affects Apache Subversion. We've verified > that it is this latest release, as prior releases have worked just > fine for us. > > Below is the reproduction script, thanks to Daniel Shahaf. With this > p

Re: svn commit: r1139725 - /subversion/trunk/subversion/libsvn_diff/diff3.c

2011-06-26 Thread Daniel Shahaf
mo...@apache.org wrote on Sun, Jun 26, 2011 at 07:49:37 -: > Author: moklo > Date: Sun Jun 26 07:49:36 2011 > New Revision: 1139725 > > URL: http://svn.apache.org/viewvc?rev=1139725&view=rev > Log: > Whitespace adjustments > > * subversion/libsvn_diff/diff3.c > Made first half of file match

Re: [PATCH] Speed-up of libsvn_diff by restarts of LCS algorithm

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 11:23 AM, Morten Kloster wrote: > On Tue, Jun 14, 2011 at 11:12 PM, Johan Corveleyn wrote: >> On Tue, Jun 14, 2011 at 7:32 PM, Morten Kloster wrote: >>> On Tue, Jun 14, 2011 at 2:49 AM, Johan Corveleyn wrote: On Tue, Jun 7, 2011 at 10:16 PM, Morten Kloster wrote: >

Re: Running benchmarks/suite1 on Windows

2011-06-26 Thread Stefan Fuhrmann
On 21.06.2011 22:01, Johan Corveleyn wrote: 2011/6/21 Daniel Klíma: 2011/6/21 Johan Corveleyn: Hi, I managed to get the benchmark 'suite1' (tools/dev/benchmarks/suite1, which is used for the automated benchmarks [svnbench] on svn-qavm) running on Windows. I did that by translating the 'run' sc

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: "XX\n", Expected: "Cc\n\n"

2011-06-26 Thread Daniel Shahaf
Johan Corveleyn wrote on Sun, Jun 26, 2011 at 23:08:39 +0200: > On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf > wrote: > > libsvn_diff/diff-diff3-test 2 > > fails for me: > > > > [[[ > > subversion/tests/libsvn_diff/diff-diff3-test.c:653: (apr_err=26) > > subversion/tests/libsvn_diff/diff-di

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: "XX\n", Expected: "Cc\n\n"

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 11:08 PM, Johan Corveleyn wrote: > On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf > wrote: >> libsvn_diff/diff-diff3-test 2 >> fails for me: >> >> [[[ >> subversion/tests/libsvn_diff/diff-diff3-test.c:653: (apr_err=26) >> subversion/tests/libsvn_diff/diff-diff3-test.c

Re: svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: "XX\n", Expected: "Cc\n\n"

2011-06-26 Thread Johan Corveleyn
On Sun, Jun 26, 2011 at 5:35 PM, Daniel Shahaf wrote: > libsvn_diff/diff-diff3-test 2 > fails for me: > > [[[ > subversion/tests/libsvn_diff/diff-diff3-test.c:653: (apr_err=26) > subversion/tests/libsvn_diff/diff-diff3-test.c:316: (apr_err=26) > subversion/tests/libsvn_diff/diff-diff3-test

Re: svn commit: r1127709 - /subversion/trunk/subversion/libsvn_subr/cache-membuffer.c

2011-06-26 Thread Stefan Fuhrmann
On 11.06.2011 14:53, Daniel Shahaf wrote: Stefan Fuhrmann wrote on Sat, Jun 11, 2011 at 10:13:27 +0200: On 10.06.2011 22:28, Daniel Shahaf wrote: stef...@apache.org wrote on Wed, May 25, 2011 at 22:20:25 -: Author: stefan2 Date: Wed May 25 22:20:25 2011 New Revision: 1127709 URL: http://s

Re: svn commit: r1130118 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_subr/subst.c

2011-06-26 Thread Stefan Fuhrmann
On 02.06.2011 23:12, Stefan Sperling wrote: On Thu, Jun 02, 2011 at 10:59:15PM +0200, Stefan Sperling wrote: I've ripped out mark/seek from the patch code in r1130809. I think we could now remove mark and seek from the stream API before 1.7 release. Hmmm, stream.c:stream_readline_chunky() still

Re: API change - rename svn_hash_get_cstring/bool() to svn_config_hash_get_*()

2011-06-26 Thread Stefan Fuhrmann
On 23.06.2011 12:48, Julian Foad wrote: On Mon, 2011-06-20, Julian Foad wrote: On Wed, 2011-06-15, Stefan Fuhrmann wrote: On 15.06.2011 15:29, Julian Foad wrote: A heads-up: I'm renaming svn_hash_get_bool() to svn_config_hash_get_bool(), and svn_hash_get_cstring() to svn_config_hash_get(), mov

Re: cache-membuffer.c entry_t

2011-06-26 Thread Stefan Fuhrmann
On 23.06.2011 23:24, Daniel Shahaf wrote: Stefan, [[[ /* A single dictionary entry. Since they are allocated statically, these * entries can either be in use or in used state. An entry is unused, iff * the offset member is NO_OFFSET. In that case, it must not be linked in * the list of use

Re: [PATCH] svn_base64.c encode_bytes docstring

2011-06-26 Thread Stefan Fuhrmann
On 25.06.2011 13:25, Daniel Shahaf wrote: [[[ * subversion/libsvn_subr/svn_base64.c (encode_bytes, decode_bytes): Clarify docstrings. ]]] [[[ Index: subversion/libsvn_subr/svn_base64.c === --- subversion/libsvn_subr/svn_base64.c

PRAGMA bug in 3.7.7 (but fine in 3.7.6.3)

2011-06-26 Thread Greg Stein
Hey all, There is a bug in 3.7.7 that affects Apache Subversion. We've verified that it is this latest release, as prior releases have worked just fine for us. Below is the reproduction script, thanks to Daniel Shahaf. With this pragma not working, we cannot even start up :-( Please help! Thank

Re: Subversion does not work with SQLite 3.7.7

2011-06-26 Thread Greg Stein
On Sun, Jun 26, 2011 at 15:20, Daniel Shahaf wrote: > Greg Stein wrote on Sun, Jun 26, 2011 at 15:11:43 -0400: >> On Jun 26, 2011 9:45 AM, "Daniel Shahaf" wrote: >> > >> > Daniel Shahaf wrote on Sun, Jun 26, 2011 at 16:21:00 +0300: >> > > Running it: >> > > [[[ >> > > % for i in foo-*; do echo ./

Re: Subversion does not work with SQLite 3.7.7

2011-06-26 Thread Daniel Shahaf
Greg Stein wrote on Sun, Jun 26, 2011 at 15:11:43 -0400: > On Jun 26, 2011 9:45 AM, "Daniel Shahaf" wrote: > > > > Daniel Shahaf wrote on Sun, Jun 26, 2011 at 16:21:00 +0300: > > > Running it: > > > [[[ > > > % for i in foo-*; do echo ./$i; ./$i; done > > > ./foo-3.7.6.3 > > > ./foo-3.7.7 > > > Er

Re: Subversion does not work with SQLite 3.7.7

2011-06-26 Thread Greg Stein
On Jun 26, 2011 9:45 AM, "Daniel Shahaf" wrote: > > Daniel Shahaf wrote on Sun, Jun 26, 2011 at 16:21:00 +0300: > > Running it: > > [[[ > > % for i in foo-*; do echo ./$i; ./$i; done > > ./foo-3.7.6.3 > > ./foo-3.7.7 > > Error 17: database schema has changed > > % > > ]]] > > > > Correction: > > [

svn_tests: E200006: failed merging diff 'foo6d' to 'bar6d' into 'foo6d'; Found: "XX\n", Expected: "Cc\n\n"

2011-06-26 Thread Daniel Shahaf
libsvn_diff/diff-diff3-test 2 fails for me: [[[ subversion/tests/libsvn_diff/diff-diff3-test.c:653: (apr_err=26) subversion/tests/libsvn_diff/diff-diff3-test.c:316: (apr_err=26) subversion/tests/libsvn_diff/diff-diff3-test.c:220: (apr_err=26) svn_tests: E26: failed merging diff 'fo

Re: Subversion does not work with SQLite 3.7.7

2011-06-26 Thread Daniel Shahaf
Daniel Shahaf wrote on Sun, Jun 26, 2011 at 16:21:00 +0300: > Running it: > [[[ > % for i in foo-*; do echo ./$i; ./$i; done > ./foo-3.7.6.3 > ./foo-3.7.7 > Error 17: database schema has changed > % > ]]] > Correction: [[[ % for i in foo-*; do rm foo.db && echo $i && ./$i; done foo-3.7.6.3 foo-

Re: Subversion does not work with SQLite 3.7.7

2011-06-26 Thread Daniel Shahaf
Daniel Shahaf wrote on Sun, Jun 26, 2011 at 15:40:04 +0300: > Hyrum K Wright wrote on Sat, Jun 25, 2011 at 21:11:28 -0500: > > On Sat, Jun 25, 2011 at 7:26 PM, Daniel Shahaf > > wrote: > > > Arfrever Frehtes Taifersar Arahesis wrote on Sat, Jun 25, 2011 at > > > 21:16:31 +0200: > > >> svn: E2000

Re: Subversion does not work with SQLite 3.7.7

2011-06-26 Thread Daniel Shahaf
Hyrum K Wright wrote on Sat, Jun 25, 2011 at 21:11:28 -0500: > On Sat, Jun 25, 2011 at 7:26 PM, Daniel Shahaf > wrote: > > Arfrever Frehtes Taifersar Arahesis wrote on Sat, Jun 25, 2011 at 21:16:31 > > +0200: > >> svn: E200030: database schema has changed, executing statement 'PRAGMA > >> case_

Re: [PATCH] Speed-up of libsvn_diff by restarts of LCS algorithm

2011-06-26 Thread Morten Kloster
On Tue, Jun 14, 2011 at 11:12 PM, Johan Corveleyn wrote: > On Tue, Jun 14, 2011 at 7:32 PM, Morten Kloster wrote: >> On Tue, Jun 14, 2011 at 2:49 AM, Johan Corveleyn wrote: >>> On Tue, Jun 7, 2011 at 10:16 PM, Morten Kloster wrote: >> [] Here's an updated patch based on the current HE