Re: Issue 3552 reopen ?

2011-11-25 Thread Daniel Shahaf
I don't know and don't have the time to look right now, sorry. Please follow up on us...@subversion.apache.org. Please also avoid sending a 250KB image with each email, it's a waste of bandwidth as these lists are text-only. I'll note that we have a regression test for #3552: wc_repos_file_exter

Re: Choice of constant in libsvn_fs_base

2011-11-25 Thread Julian Foad
Daniel Shahaf wrote: > While reviewing r1205726 I came across this pearl: > > reps-strings.c-  /* Make a list of all the rep's we need to undeltify this > range. > reps-strings.c-    We'll have to read them within this trail anyway, so we > might > reps-strings.c-    as well do it once and up

Re: scan-log-moves hash structure

2011-11-25 Thread Philip Martin
"Bert Huijben" writes: > I think this is exactly the same thing as when using strings: You pass the > address of the characters and the length of the string (without the final \0 > if I remember correctly). Ah! Yes. -- uberSVN: Apache Subversion Made Easy http://www.uberSVN.com

RE: scan-log-moves hash structure

2011-11-25 Thread Bert Huijben
> -Original Message- > From: MARTIN PHILIP [mailto:codematt...@ntlworld.com] On Behalf Of > Philip Martin > Sent: vrijdag 25 november 2011 14:18 > To: dev@subversion.apache.org > Cc: s...@elego.de > Subject: scan-log-moves hash structure > > scan_moves_log_receiver does: > > m

scan-log-moves hash structure

2011-11-25 Thread Philip Martin
scan_moves_log_receiver does: moves = apr_hash_get(b->moves, &new_move->revision, sizeof(svn_revnum_t)); if (moves == NULL) { moves = apr_array_make(result_pool, 1, sizeof(svn_wc_repo