Re: XPASS of op-depth-test 40

2012-04-23 Thread Philip Martin
Hyrum K Wright hyrum.wri...@wandisco.com writes: It isn't killing the bots, but something is causing op-depth-test 40 to unexpectedly pass. Thought I'd mention it so somebody with knowledge of the guts of that test, and its purpose could take a look. That's where I'm currently working. I

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Hyrum K Wright
On Sun, Apr 22, 2012 at 8:11 PM, Greg Stein gst...@gmail.com wrote: On Sun, Apr 22, 2012 at 20:59,  gst...@apache.org wrote: Author: gstein Date: Mon Apr 23 00:59:46 2012 New Revision: 1329015 URL: http://svn.apache.org/viewvc?rev=1329015view=rev Log: Provide a first pass at (private) APIs

RE: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c

2012-04-23 Thread Bert Huijben
-Original Message- From: hwri...@apache.org [mailto:hwri...@apache.org] Sent: maandag 23 april 2012 15:44 To: comm...@subversion.apache.org Subject: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c Author: hwright Date: Mon Apr 23 13:43:33 2012

Re: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c

2012-04-23 Thread Hyrum K Wright
On Mon, Apr 23, 2012 at 8:53 AM, Bert Huijben b...@qqmail.nl wrote: -Original Message- From: hwri...@apache.org [mailto:hwri...@apache.org] Sent: maandag 23 april 2012 15:44 To: comm...@subversion.apache.org Subject: svn commit: r1329234 - in /subversion/trunk: ./

Re: [RFC][PATCH 00/22] JavaHL Ra API Implementation

2012-04-23 Thread Hyrum K Wright
I haven't reviewed the patched, but some comments about the general ideas below. On Sat, Apr 21, 2012 at 10:51 PM, Vladimir Berezniker v...@hitechman.com wrote: Hi All,   I am sending patch series that adds support for subset of SVN Ra layer to the JavaHL API. Initial goal was to expose

Re: [RFC] Non-normalizing Unicode Composition Awareness

2012-04-23 Thread Thomas Åkesson
Hi Philip, Thanks for your comments in the wiki article. They raised some important points and potentially an idea that might simplify the solution. All three paths are in UTF-8 but NFC/NFD is not currently specified. local_relpath/parent_relpath get converted from UTF-8 to whatever

Re: [RFC] Non-normalizing Unicode Composition Awareness

2012-04-23 Thread Philip Martin
Thomas Åkesson tho...@akesson.cc writes: If you, or someone else with WC insight, could provide some details on when/how conversions in the opposite direction is performed (e.g. svn stat and most commands taking path arguments), that would be incredibly useful to me. I would like to explore

Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Julian Foad
Bert Huijben wrote: you could just use assert(svn_relpath_is_canonical(base_relpath)); for a debug only check. (or SVN_ERR_ASSERT() if you also want to slow down release versions) The policy is: always use 'SVN_ERR_ASSERT' rather than 'assert' (in functions that return svn_error_t). Of

Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Daniel Shahaf
Julian Foad wrote on Mon, Apr 23, 2012 at 17:01:33 +0100: Bert Huijben wrote: you could just use assert(svn_relpath_is_canonical(base_relpath)); for a debug only check. (or SVN_ERR_ASSERT() if you also want to slow down release versions) The policy is: always use 'SVN_ERR_ASSERT'

Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Julian Foad
I (Julian Foad) wrote: There isn't currently an easy build switch (such as NDEBUG) to disable SVN_ERR_ASSERT completely at compile time.  That's just a side issue.  If you want such a switch, just ask; we can easily create one.  Or if you think we need two levels of assertions -- one for

Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Hyrum K Wright
On Mon, Apr 23, 2012 at 11:01 AM, Julian Foad julianf...@btopenworld.com wrote: Bert Huijben wrote: you could just use assert(svn_relpath_is_canonical(base_relpath)); for a debug only check. (or SVN_ERR_ASSERT() if you also want to slow down release versions) The policy is: always use

neon pool problem causing buildbot fail

2012-04-23 Thread Philip Martin
The openbsd buildbot failed: http://ci.apache.org/builders/bb-openbsd/builds/1139 like this: tree_conflicts_tests-23 is failing when importing a file that 2012-04-22 16:55:49 [WARNING] subversion/svn/import-cmd.c:127: (apr_err=2) subversion/libsvn_client/commit.c:971: (apr_err=2)

Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Daniel Shahaf
Julian Foad wrote on Mon, Apr 23, 2012 at 17:18:22 +0100: I (Julian Foad) wrote: There isn't currently an easy build switch (such as NDEBUG) to disable SVN_ERR_ASSERT completely at compile time.  That's just a side issue.  If you want such a switch, just ask; we can easily create one. 

RE: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Bert Huijben
-Original Message- From: Julian Foad [mailto:julianf...@btopenworld.com] Sent: maandag 23 april 2012 18:02 To: Bert Huijben Cc: dev@subversion.apache.org Subject: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

Re: Merge policies

2012-04-23 Thread Paul Burba
On Fri, Apr 20, 2012 at 5:07 PM, Paul Burba ptbu...@gmail.com wrote: On Fri, Apr 20, 2012 at 6:17 AM, Julian Foad julianf...@btopenworld.com wrote: Paul Burba wrote: On Thu, Apr 19, 2012 at 12:57 PM, Julian Foad wrote:  Branko Čibej wrote:  By the way, I'm all for removing support for

Re: svn commit: r1329083 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/editor.c

2012-04-23 Thread Greg Stein
On Apr 23, 2012 8:00 AM, Blair Zajac bl...@orcaware.com wrote: On Apr 23, 2012, at 2:45 AM, gst...@apache.org wrote: Author: gstein Date: Mon Apr 23 06:45:46 2012 New Revision: 1329083 URL: http://svn.apache.org/viewvc?rev=1329083view=rev Log: Add a flag that we'll need. mod_dav_svn

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Greg Stein
On Apr 23, 2012 8:00 AM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: ... I added an Ev2 capability to svn_ra.h on the ev2-export branch, which we could use to check the ability of the client and/or server to receiver Ev2-encoded deltas. Feel free to poach the one-line patch. I'm not sure

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Hyrum K Wright
On Mon, Apr 23, 2012 at 12:08 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 8:00 AM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: ... I added an Ev2 capability to svn_ra.h on the ev2-export branch, which we could use to check the ability of the client and/or server to receiver

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Greg Stein
On Apr 23, 2012 1:12 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:08 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 8:00 AM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: ... I added an Ev2 capability to svn_ra.h on the ev2-export branch,

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Hyrum K Wright
On Mon, Apr 23, 2012 at 12:18 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 1:12 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:08 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 8:00 AM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: ...

Re: svn commit: r1329214 - in /subversion/branches/ev2-export: ./ build/ notes/merge-tracking/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs/ subversion

2012-04-23 Thread Greg Stein
On Apr 23, 2012 8:45 AM, hwri...@apache.org wrote: ... +++ subversion/branches/ev2-export/subversion/include/svn_delta.h Mon Apr 23 12:44:31 2012 @@ -1167,51 +1167,6 @@ typedef svn_error_t *(*svn_delta_unlock_ apr_pool_t *scratch_pool); This context indicates a few more typedefs to clear

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Greg Stein
On Apr 23, 2012 1:36 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:18 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 1:12 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:08 PM, Greg Stein gst...@gmail.com wrote:

Re: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c

2012-04-23 Thread Greg Stein
On Apr 23, 2012 10:00 AM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: ... As an aside, I thought SVN_ERR_ASSERT() was compiled out of production builds. Perhaps not? Nope. They remain.

Re: svn commit: r1329214 - in /subversion/branches/ev2-export: ./ build/ notes/merge-tracking/ subversion/include/ subversion/include/private/ subversion/libsvn_delta/ subversion/libsvn_fs/ subversion

2012-04-23 Thread Greg Stein
On Apr 23, 2012 1:39 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 8:45 AM, hwri...@apache.org wrote: ... +++ subversion/branches/ev2-export/subversion/include/svn_delta.h Mon Apr 23 12:44:31 2012 @@ -1167,51 +1167,6 @@ typedef svn_error_t *(*svn_delta_unlock_ apr_pool_t

Re: neon pool problem causing buildbot fail

2012-04-23 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: I can fix the valgrind errors with this patch: Index: subversion/libsvn_client/commit.c === --- subversion/libsvn_client/commit.c (revision 1327801) +++

Re: neon pool problem causing buildbot fail

2012-04-23 Thread Philip Martin
Philip Martin philip.mar...@wandisco.com writes: Philip Martin philip.mar...@wandisco.com writes: I can fix the valgrind errors with this patch: Index: subversion/libsvn_client/commit.c === ---

Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Daniel Shahaf
Julian Foad wrote on Mon, Apr 23, 2012 at 20:40:59 +0100: Daniel Shahaf wrote: Julian Foad wrote: I (Julian Foad) wrote: There isn't currently an easy build switch (such as NDEBUG) to disable SVN_ERR_ASSERT completely at compile time.  That's just a side issue.  If you

Re: Always use SVN_ERR_ASSERT [was: svn commit: r1329234 - in /subversion/trunk: ./ subversion/libsvn_delta/compat.c]

2012-04-23 Thread Julian Foad
- Original Message - From: Daniel Shahaf danie...@elego.de To: Julian Foad julianf...@btopenworld.com Cc: Bert Huijben b...@qqmail.nl; dev@subversion.apache.org dev@subversion.apache.org Sent: Monday, 23 April 2012, 20:59 Subject: Re: Always use SVN_ERR_ASSERT [was: svn commit:

RE: svn commit: r1329417 - in /subversion/trunk/subversion: libsvn_client/merge.c tests/cmdline/merge_tests.py

2012-04-23 Thread Bert Huijben
-Original Message- From: pbu...@apache.org [mailto:pbu...@apache.org] Sent: maandag 23 april 2012 22:13 To: comm...@subversion.apache.org Subject: svn commit: r1329417 - in /subversion/trunk/subversion: libsvn_client/merge.c tests/cmdline/merge_tests.py Author: pburba Date: Mon

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Hyrum K Wright
On Mon, Apr 23, 2012 at 12:52 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 1:36 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:18 PM, Greg Stein gst...@gmail.com wrote: On Apr 23, 2012 1:12 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote:

Re: Error svn: E155010 when merging Add then Delete in the same merge operation

2012-04-23 Thread Paul Burba
On Fri, Apr 20, 2012 at 10:55 AM, Andrea Antonio Maleci a.mal...@iwbank.it wrote: Hi all, I’m doing some sparse merge operation, unsing –r option. If in the same merge action I merge a revision that contains an add action on a file and then another revision that contain a delete of the same

Re: svn commit: r1329404 - in /subversion/trunk/subversion: include/private/ libsvn_client/ libsvn_wc/

2012-04-23 Thread Greg Stein
On Mon, Apr 23, 2012 at 15:44, julianf...@apache.org wrote: ... +++ subversion/trunk/subversion/include/private/svn_wc_private.h Mon Apr 23 19:44:31 2012 @@ -628,21 +628,31 @@ svn_wc__node_has_working(svn_boolean_t *  /** - * Get the base revision of @a local_abspath using @a wc_ctx.  If

Re: svn commit: r1329404 - in /subversion/trunk/subversion: include/private/ libsvn_client/ libsvn_wc/

2012-04-23 Thread Greg Stein
On Mon, Apr 23, 2012 at 15:44, julianf...@apache.org wrote: ... +++ subversion/trunk/subversion/libsvn_wc/node.c Mon Apr 23 19:44:31 2012 @@ -876,41 +876,43 @@ svn_wc__node_has_working(svn_boolean_t *  } -static svn_error_t * -get_base_rev(svn_revnum_t *base_revision, -            

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Greg Stein
On Mon, Apr 23, 2012 at 16:21, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:52 PM, Greg Stein gst...@gmail.com wrote: ... Alright. It sounds like svn_ra.h has two purposes: stuff for libsvn_client, and stuff for all RA layers to use internally. Ugh. But the

Re: svn commit: r1329083 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/editor.c

2012-04-23 Thread Blair Zajac
On Apr 23, 2012, at 1:01 PM, Greg Stein wrote: On Apr 23, 2012 8:00 AM, Blair Zajac bl...@orcaware.com wrote: On Apr 23, 2012, at 2:45 AM, gst...@apache.org wrote: Author: gstein Date: Mon Apr 23 06:45:46 2012 New Revision: 1329083 URL:

Re: svn commit: r1329083 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/editor.c

2012-04-23 Thread Greg Stein
On Mon, Apr 23, 2012 at 17:58, Blair Zajac bl...@orcaware.com wrote: On Apr 23, 2012, at 1:01 PM, Greg Stein wrote: On Apr 23, 2012 8:00 AM, Blair Zajac bl...@orcaware.com wrote: On Apr 23, 2012, at 2:45 AM, gst...@apache.org wrote: Author: gstein Date: Mon Apr 23 06:45:46 2012

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Hyrum K Wright
On Mon, Apr 23, 2012 at 4:55 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 23, 2012 at 16:21, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:52 PM, Greg Stein gst...@gmail.com wrote: ... Alright. It sounds like svn_ra.h has two purposes: stuff for

Re: svn commit: r1329015 - in /subversion/trunk/subversion: include/private/svn_ra_private.h libsvn_ra/editor.c libsvn_ra/ra_loader.c libsvn_ra/ra_loader.h

2012-04-23 Thread Greg Stein
On Apr 23, 2012 7:20 PM, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 4:55 PM, Greg Stein gst...@gmail.com wrote: On Mon, Apr 23, 2012 at 16:21, Hyrum K Wright hyrum.wri...@wandisco.com wrote: On Mon, Apr 23, 2012 at 12:52 PM, Greg Stein gst...@gmail.com wrote: