Re: -Werror flag set unconditionally

2012-12-19 Thread Branko Čibej
On 20.12.2012 05:08, Arfrever Frehtes Taifersar Arahesis wrote: > 2012-12-20 04:41:56 Branko Čibej napisał(a): >> We want to always use -Werror=implicit-function-declaration (if compiler >> supports it) >> to ensure that nobody forgets to include required headers. >> I'm not convinced. We add -Wmi

Re: -Werror flag set unconditionally

2012-12-19 Thread Arfrever Frehtes Taifersar Arahesis
2012-12-20 04:41:56 Branko Čibej napisał(a): > On 20.12.2012 04:31, Arfrever Frehtes Taifersar Arahesis wrote: > > 2012-12-20 03:39:30 Branko Čibej napisał(a): > >> I found the following in configure.ac which unconditionally adds a > >> -Werror flag: > >> > >> dnl Add -Werror=implicit-function-decl

Re: svn commit: r1413451 - /subversion/branches/cache-server/BRANCH-README

2012-12-19 Thread Branko Čibej
On 20.12.2012 02:08, Stefan Fuhrmann wrote: > The ineffectiveness of our use of memcached in 1.6 had > prompted the development of membuffer in the first place. > > Despite the relevant APR bug that got fixed only recently, > there are fundamental limitations compared to a SHM-based > implementatio

Re: -Werror flag set unconditionally

2012-12-19 Thread Branko Čibej
On 20.12.2012 04:41, Branko Čibej wrote: >> We want to always use -Werror=implicit-function-declaration (if compiler >> supports it) > ... which we don't check ... Never mind this bit, I was thinking of something else entirely when I wrote this. Sorry. -- Brane -- Branko Čibej Director of Subv

Re: -Werror flag set unconditionally

2012-12-19 Thread Branko Čibej
On 20.12.2012 04:31, Arfrever Frehtes Taifersar Arahesis wrote: > 2012-12-20 03:39:30 Branko Čibej napisał(a): >> I found the following in configure.ac which unconditionally adds a >> -Werror flag: >> >> dnl Add -Werror=implicit-function-declaration to CFLAGS >> CFLAGS_KEEP="$CFLAGS" >> CFLAGS="$CF

Re: -Werror flag set unconditionally

2012-12-19 Thread Arfrever Frehtes Taifersar Arahesis
2012-12-20 03:39:30 Branko Čibej napisał(a): > I found the following in configure.ac which unconditionally adds a > -Werror flag: > > dnl Add -Werror=implicit-function-declaration to CFLAGS > CFLAGS_KEEP="$CFLAGS" > CFLAGS="$CFLAGS_KEEP -Werror=implicit-function-declaration" > AC_COMPILE_IFELSE([A

-Werror flag set unconditionally

2012-12-19 Thread Branko Čibej
I found the following in configure.ac which unconditionally adds a -Werror flag: dnl Add -Werror=implicit-function-declaration to CFLAGS CFLAGS_KEEP="$CFLAGS" CFLAGS="$CFLAGS_KEEP -Werror=implicit-function-declaration" AC_COMPILE_IFELSE([AC_LANG_SOURCE([[]])], [CFLAGS_KEEP="$CFLAGS"]) CFLAGS="$CFL

Re: svn commit: r1413451 - /subversion/branches/cache-server/BRANCH-README

2012-12-19 Thread Stefan Fuhrmann
On Mon, Dec 17, 2012 at 1:29 PM, Branko Čibej wrote: > Resent to the correct list. > > On 17.12.2012 11:41, Branko Čibej wrote: > > On 17.12.2012 11:25, Daniel Shahaf wrote: > >> stef...@apache.org wrote on Mon, Nov 26, 2012 at 00:21:26 -: > >>> Author: stefan2 > >>> Date: Mon Nov 26 00:21:26

Re: backgrounding 'svn log' over serf

2012-12-19 Thread Philip Martin
Lieven Govaerts writes: > On Ubuntu I can reproduce this issue at the first try, On Mac OS X not at all. > > Attached patch to serf fixes the issue for me. > > [..] > > Lieven > > Index: context.c > === > --- context.c (revision 1701

Re: svn commit: r1422042 - /subversion/trunk/subversion/libsvn_fs_fs/rep-cache.c

2012-12-19 Thread Julian Foad
Philip Martin wrote: > Julian Foad writes: >>>  URL: http://svn.apache.org/viewvc?rev=1422042&view=rev >> >>>  Log: >>>  Fix issue 4210, rep-cache not reseting SQLite statements on error. >> >>  I noticed the other day that WC DB code in many places fails to reset >>  stmts on error, but that sv

Re: In-Repo-Authz

2012-12-19 Thread Julian Foad
Ben Reser wrote: > Julian Foad wrote: >>  Only the standard general benefits of committing separate changes >> separately, such as being able to revert one without another, or >> backport one without another, or review one at a time. > > The changes in the branch are clearly split.  I could proba

Re: backgrounding 'svn log' over serf

2012-12-19 Thread Lieven Govaerts
On Wed, Dec 19, 2012 at 8:31 PM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> On 12/19/2012 01:59 PM, C. Michael Pilato wrote: >>> On 12/19/2012 01:53 PM, Daniel Shahaf wrote: Actual result: backgrounding svn killed it. Expected result: after 'bg\n', keep fetching+filter

Re: svn commit: r1424037 - in /subversion/trunk/subversion: include/svn_cmdline.h libsvn_subr/cmdline.c svn/cl.h svn/svn.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout tests/cmdline/upda

2012-12-19 Thread Stefan Sperling
On Wed, Dec 19, 2012 at 08:18:44PM +0100, Bert Huijben wrote: > > + /* If stdin is not a terminal and --force-interactive was not passed, > > + * set --non-interactive. */ > > + if (!opt_state.force_interactive) > > + opt_state.non_interactive = !svn_cmdline__stdin_isatty(); > > + > > Thi

Re: backgrounding 'svn log' over serf

2012-12-19 Thread Philip Martin
"C. Michael Pilato" writes: > On 12/19/2012 01:59 PM, C. Michael Pilato wrote: >> On 12/19/2012 01:53 PM, Daniel Shahaf wrote: >>> Actual result: backgrounding svn killed it. >>> >>> Expected result: after 'bg\n', keep fetching+filtering+printing log >>> messages in the background. >>> >>> It wor

RE: svn commit: r1424037 - in /subversion/trunk/subversion: include/svn_cmdline.h libsvn_subr/cmdline.c svn/cl.h svn/svn.c tests/cmdline/getopt_tests_data/svn_help_log_switch_stdout tests/cmdline/upda

2012-12-19 Thread Bert Huijben
> -Original Message- > From: s...@apache.org [mailto:s...@apache.org] > Sent: woensdag 19 december 2012 20:13 > To: comm...@subversion.apache.org > Subject: svn commit: r1424037 - in /subversion/trunk/subversion: > include/svn_cmdline.h libsvn_subr/cmdline.c svn/cl.h svn/svn.c > tests/cmd

Re: backgrounding 'svn log' over serf

2012-12-19 Thread Daniel Shahaf
C. Michael Pilato wrote on Wed, Dec 19, 2012 at 13:59:21 -0500: > On 12/19/2012 01:53 PM, Daniel Shahaf wrote: > > Actual result: backgrounding svn killed it. > > > > Expected result: after 'bg\n', keep fetching+filtering+printing log > > messages in the background. > > > > It worked in 1.7 with

Re: backgrounding 'svn log' over serf

2012-12-19 Thread C. Michael Pilato
On 12/19/2012 01:59 PM, C. Michael Pilato wrote: > On 12/19/2012 01:53 PM, Daniel Shahaf wrote: >> Actual result: backgrounding svn killed it. >> >> Expected result: after 'bg\n', keep fetching+filtering+printing log >> messages in the background. >> >> It worked in 1.7 with neon. Can we make it w

Re: backgrounding 'svn log' over serf

2012-12-19 Thread C. Michael Pilato
On 12/19/2012 01:53 PM, Daniel Shahaf wrote: > Actual result: backgrounding svn killed it. > > Expected result: after 'bg\n', keep fetching+filtering+printing log > messages in the background. > > It worked in 1.7 with neon. Can we make it work in 1.8 too? Please file an issue. With as much co

backgrounding 'svn log' over serf

2012-12-19 Thread Daniel Shahaf
With trunk@HEAD and serf-1.2.x@HEAD (r1707), I tried to background an 'svn log': [[[ % $svn log --search stefan2 --search-and truncate r1398509 | stefan2 | 2012-10-15 20:53:19 + (Mon, 15 Oct 2012) | 12 lines Fix more in

Re: Relocate and inherited props

2012-12-19 Thread Philip Martin
Paul Burba writes: > On Wed, Dec 19, 2012 at 11:32 AM, Philip Martin > wrote: >> $ svnadmin create repo >> $ svn mkdir -mm --parents file://`pwd`/repo/A/B/C >> $ svnmucc -mm -U file://`pwd`/repo propset svn:inheritable:ppp vv1 A propset >> svn:inheritable:ppp vv2 A/B >> $ svn co file://`pwd`/re

Re: svn commit: r1423955 - in /subversion/trunk/subversion: libsvn_subr/opt.c svn/help-cmd.c

2012-12-19 Thread C. Michael Pilato
On 12/19/2012 12:16 PM, Branko Čibej wrote: > I decided to move the generation of this warning out of libsvn_subr into > the client (where it more properly belongs), so that we can check the > configuration to see if it really is (globally) enabled. > > As far as I can see, basic_test.py #48 (basi

Re: Request: Issue Triage Cleanup

2012-12-19 Thread C. Michael Pilato
On 12/19/2012 11:48 AM, Paul Burba wrote: > Not sure about 'blue-sky'. There are only 16 open issues with this > milestone. I always took it mean something along the lines of 'not > going to happen before 2.0 or without a massive amount of work for > limited gain', but I don't know that there is

Re: svn commit: r1423955 - in /subversion/trunk/subversion: libsvn_subr/opt.c svn/help-cmd.c

2012-12-19 Thread Branko Čibej
On 19.12.2012 18:05, br...@apache.org wrote: > Author: brane > Date: Wed Dec 19 17:05:16 2012 > New Revision: 1423955 > > URL: http://svn.apache.org/viewvc?rev=1423955&view=rev > Log: > Make "svn --version"'s warning about enabled plaintext passwords depend on > configuration file settings, not jus

RE: Relocate and inherited props

2012-12-19 Thread Bert Huijben
We should store relative paths. Bert Huijben (Cell phone) From: Philip Martin Sent: 19-12-2012 17:33 To: dev@subversion.apache.org Subject: Relocate and inherited props $ svnadmin create repo $ svn mkdir -mm --parents file://`pwd`/repo/A/B/C $ svnmucc -mm -U file://`pwd`/repo propset svn:inheritab

Re: Relocate and inherited props

2012-12-19 Thread Paul Burba
On Wed, Dec 19, 2012 at 11:32 AM, Philip Martin wrote: > $ svnadmin create repo > $ svn mkdir -mm --parents file://`pwd`/repo/A/B/C > $ svnmucc -mm -U file://`pwd`/repo propset svn:inheritable:ppp vv1 A propset > svn:inheritable:ppp vv2 A/B > $ svn co file://`pwd`/repo/A/B/C wc > $ mv repo repo2

Re: Request: Issue Triage Cleanup

2012-12-19 Thread Paul Burba
On Wed, Dec 19, 2012 at 11:39 AM, Philip Martin wrote: >>> I don't mean milestones of 'unscheduled', 'nonblocking', of 'blue-sky', > > Do those milestones have an agreed meaning? What is the difference? My understanding of unscheduled and nonblocking as is per http://subversion.tigris.org/issue-

Re: In-Repo-Authz

2012-12-19 Thread Ben Reser
On Wed, Dec 19, 2012 at 8:30 AM, Julian Foad wrote: > Only the standard general benefits of committing separate changes separately, > such as being able to revert one without another, or backport one without > another, or review one at a time. The changes in the branch are clearly split. I cou

Re: Request: Issue Triage Cleanup

2012-12-19 Thread Philip Martin
>> I don't mean milestones of 'unscheduled', 'nonblocking', of 'blue-sky', Do those milestones have an agreed meaning? What is the difference? -- Certified & Supported Apache Subversion Downloads: http://www.wandisco.com/subversion/download

Relocate and inherited props

2012-12-19 Thread Philip Martin
$ svnadmin create repo $ svn mkdir -mm --parents file://`pwd`/repo/A/B/C $ svnmucc -mm -U file://`pwd`/repo propset svn:inheritable:ppp vv1 A propset svn:inheritable:ppp vv2 A/B $ svn co file://`pwd`/repo/A/B/C wc $ mv repo repo2 $ svn relocate file://`pwd`/repo file://`pwd`/repo2 wc The inherite

Re: In-Repo-Authz

2012-12-19 Thread Julian Foad
Ben Reser wrote: > Julian Foad wrote: >> Just a thought.  Some of these changes are significant (in both >> lines touched and functionality) on their own.  One that stands >> out is "svnserve --config-file no longer caches the password and >> authz db ...".  Would it be a good idea (and not too m

Re: In-Repo-Authz

2012-12-19 Thread Ben Reser
On Wed, Dec 19, 2012 at 6:41 AM, C. Michael Pilato wrote: > +1, but why wait until next week? If you are confident in your changes, > then get 'em into the practically visible/reviewable space ASAP! At this > point in the merry month of December, "next week" for many folks translates > effective

Re: In-Repo-Authz

2012-12-19 Thread Ben Reser
On Wed, Dec 19, 2012 at 6:57 AM, Julian Foad wrote: > Just a thought. Some of these changes are significant (in both lines touched > and functionality) on their own. One that stands out is "svnserve > --config-file no longer caches the password and authz db ...". Would it be a > good idea (a

Please vote for 1.6.x backports this week.

2012-12-19 Thread Ben Reser
We should get a 1.6.x release out with the Vary change and the rep_write_cleanup() change (the later is already merged). Please vote for the Vary change and any additional changes you'd like to see included in 1.6.20 this week. Given our goal for 1.8.x I suspect this will be the last 1.6.x releas

Re: 1.7.8 up for testing/signing

2012-12-19 Thread Ben Reser
On Wed, Dec 19, 2012 at 7:59 AM, Ben Reser wrote: > Release is not staging to the mirrors. I'll announce it first thing > tomorrow morning for me (US/Pacific aka GMT-8). s/not/now/

Re: 1.7.8 up for testing/signing

2012-12-19 Thread Ben Reser
On Wed, Dec 19, 2012 at 2:43 AM, Bert Huijben wrote: >> On Fri, Dec 14, 2012 at 3:57 PM, Ben Reser wrote: >> > I need one more signature for Windows in order to release. Listed >> > expected release day is Monday December 17th. So I'll need to get the >> > signatures by Sunday in order to have

Re: Request: Issue Triage Cleanup

2012-12-19 Thread Mark Phippard
I think if you are logged in to tigris, this URL will show you all the issues you have entered: http://subversion.tigris.org/issues/buglist.cgi?cmdtype=runuserdefault If you click on Change Columns you can add the Target Milestone column. This makes it easy to see if you have entered any issues

Request: Issue Triage Cleanup

2012-12-19 Thread Paul Burba
One of the regular tasks in preparation for a new release is review all outstanding issues that may block the release, e.g. "Issue triage -- Review open issues for the 1.8.0, 1.8-consider, and 1.7.x, milestones." Obviously when somebody marks an issue with milestone of 1.8.0 this indicates the iss

Re: In-Repo-Authz

2012-12-19 Thread Julian Foad
Ben Reser wrote: > I've finished the work needed to implement in-repo-authz on the branch. > > I'd like to merge this code back to trunk.  If there are no objections > I'll merge it into trunk next week. > > Please review my changes.  You can view the overall set of changes > that would be merge

Re: In-Repo-Authz

2012-12-19 Thread C. Michael Pilato
On 12/18/2012 10:41 PM, Ben Reser wrote: > I've finished the work needed to implement in-repo-authz on the branch. > > I'd like to merge this code back to trunk. If there are no objections > I'll merge it into trunk next week. +1, but why wait until next week? If you are confident in your chang

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2012-12-19 Thread Daniel Shahaf
> +@SkipUnless(svntest.main.is_ra_type_dav) > +def dump_url_not_in_head(sbox) : Spurious whitespace. > + "dump: URL deleted in HEAD should return error" > + sbox.build(create_wc = False) > + > + E_url = sbox.repo_url + '/A/B/E' > > + # Delete directory 'E'from repository. > + svntest

Re: [PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-19 Thread Stefan Sperling
On Wed, Dec 19, 2012 at 03:48:25PM +0200, Daniel Shahaf wrote: > Gabriela Gibson wrote on Wed, Dec 19, 2012 at 12:40:42 +: > > in APR (look in 'apr/include/'): > > > > > > -memory pools: apr_pools.h > > -filesystem access: apr_file_io.h > > -hashes and arrays: apr_hash.h, apr_tables.h >

Re: [PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-19 Thread Daniel Shahaf
Gabriela Gibson wrote on Wed, Dec 19, 2012 at 12:40:42 +: > in APR (look in 'apr/include/'): > > > -memory pools: apr_pools.h > -filesystem access: apr_file_io.h > -hashes and arrays: apr_hash.h, apr_tables.h > +memory pools: href="https://svn.apache.org/repos/asf/subversion/trunk/sub

Re: [PATCH] Improve error handling in svn_ra_serf__replay_range()

2012-12-19 Thread Philip Martin
vijay writes: > Index: subversion/tests/cmdline/svnrdump_tests.py > === > --- subversion/tests/cmdline/svnrdump_tests.py(revision 1423268) > +++ subversion/tests/cmdline/svnrdump_tests.py(working copy) > @@ -765,8 +76

RE: [PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-19 Thread Bert Huijben
> -Original Message- > From: Gabriela Gibson [mailto:gabriela.gib...@gmail.com] > Sent: woensdag 19 december 2012 13:41 > To: dev@subversion.apache.org > Subject: [PATCH] code file names linkified in general.html of the Hacking > Guide > > [[[ > Linkified code file names in file general.

Re: [PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-19 Thread Stefan Sperling
On Wed, Dec 19, 2012 at 12:40:42PM +, Gabriela Gibson wrote: > [[[ > Linkified code file names in file general.htm of the Hacking Guide > > Converted file names into links pointing to the current revision on page: > > http://subversion.apache.org/docs/community-guide/general.html#code-to-read

[PATCH] code file names linkified in general.html of the Hacking Guide

2012-12-19 Thread Gabriela Gibson
[[[ Linkified code file names in file general.htm of the Hacking Guide Converted file names into links pointing to the current revision on page: http://subversion.apache.org/docs/community-guide/general.html#code-to-read Converted directory names into links pointing to the current revision on p

RE: svn commit: r1422706 - in /subversion/trunk/subversion: libsvn_subr/opt.c tests/cmdline/svntest/main.py

2012-12-19 Thread Bert Huijben
> -Original Message- > From: Stefan Sperling [mailto:s...@elego.de] > Sent: dinsdag 18 december 2012 10:46 > To: Peter Samuelson; dev@subversion.apache.org > Subject: Re: svn commit: r1422706 - in /subversion/trunk/subversion: > libsvn_subr/opt.c tests/cmdline/svntest/main.py > > On Mon,

RE: 1.7.8 up for testing/signing

2012-12-19 Thread Bert Huijben
> -Original Message- > From: Ben Reser [mailto:b...@reser.org] > Sent: maandag 17 december 2012 19:36 > To: Subversion Development > Subject: Re: 1.7.8 up for testing/signing > > On Fri, Dec 14, 2012 at 3:57 PM, Ben Reser wrote: > > I need one more signature for Windows in order to rele

Re: In-Repo-Authz

2012-12-19 Thread Stefan Sperling
Sounds great! Just recently I was talking to people who wrote their own web frontend wrapper to manage authz. I believe this new feature will make things easier for them since it allows them to skip the authz file deploy step. On Tue, Dec 18, 2012 at 07:41:11PM -0800, Ben Reser wrote: > I've fini