Re: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

2013-04-23 Thread Branko Čibej
On 23.04.2013 21:06, Bert Huijben wrote: > >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: dinsdag 23 april 2013 20:47 >> To: Philip Martin >> Cc: dev@subversion.apache.org >> Subject: Re: svn commit: r1470936 - in /subversion/trunk/subversion: >> include/svn

Re: log --search test failures on trunk and 1.8.x

2013-04-23 Thread Branko Čibej
On 23.04.2013 14:51, Stefan Sperling wrote: > On Tue, Apr 23, 2013 at 02:27:08PM +0200, Branko Čibej wrote: >> You're missing the point. tolower() works on individual characters, not >> whole strings; so it in general /cannot/ do correct locale-specific > Do you really mean characters, or bytes? >

Issue 4359 fix not merged to 1.8.x (was svn commit: r1471243 - in /subversion/branches/1.8.x: ./ STATUS)

2013-04-23 Thread Blair Zajac
It looks like the wrong revision number was given in STATUS, as it's a tomcat commit: http://svn.apache.org/viewvc?view=revision&revision=r1471029 Blair --- Begin Message --- Author: svn-role Date: Wed Apr 24 04:01:30 2013 New Revision: 1471243 URL: http://svn.apache.org/r1471243 Log: Merge r1

Re: svn commit: r1470238 - /subversion/trunk/subversion/svn/conflict-callbacks.c

2013-04-23 Thread Julian Foad
I (Julian Foad) wrote: > Daniel Shahaf wrote: >>  Have you considered flipping the order to >> >>  --- relpath/to/file.r123\t- THEIRS >>  +++ relpath/to/file\t- MERGED >> >>  (with a real tab instead of \t)?  This would allow copy-pasting the >>  displayed diff into 'patch -i -' (or, presumably,

Re: svn commit: r1470238 - /subversion/trunk/subversion/svn/conflict-callbacks.c

2013-04-23 Thread Julian Foad
Daniel Shahaf wrote: > julianf...@apache.org wrote on Sat, Apr 20, 2013 at 21:47:39 -: >> Author: julianfoad >> Date: Sat Apr 20 21:47:39 2013 >> New Revision: 1470238 >> >> URL: http://svn.apache.org/r1470238 >> Log: >> Improve labelling of the file diff in interactive conflict resolut

Re: svn commit: r1470238 - /subversion/trunk/subversion/svn/conflict-callbacks.c

2013-04-23 Thread Daniel Shahaf
julianf...@apache.org wrote on Sat, Apr 20, 2013 at 21:47:39 -: > Author: julianfoad > Date: Sat Apr 20 21:47:39 2013 > New Revision: 1470238 > > URL: http://svn.apache.org/r1470238 > Log: > Improve labelling of the file diff in interactive conflict resolution. Show > labels like > > --- T

Re: New API svn_stream_lazyopen_create - documentation

2013-04-23 Thread Julian Foad
Philip Martin wrote: > C. Michael Pilato writes: >> Strictly speaking, though, any of the 'read', >> 'mark', 'skip' or 'write' operations will trigger the >> open-if-not-yet-opened() logic of the lazyopen stream. > > As will 'skip' and 'seek', i.e. all public operations apart from > 'close'. 

RE: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

2013-04-23 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: dinsdag 23 april 2013 20:47 > To: Philip Martin > Cc: dev@subversion.apache.org > Subject: Re: svn commit: r1470936 - in /subversion/trunk/subversion: > include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c >

Re: New API svn_stream_lazyopen_create - documentation

2013-04-23 Thread C. Michael Pilato
On 04/23/2013 02:23 PM, Philip Martin wrote: > "C. Michael Pilato" writes: > >> Strictly speaking, though, any of the 'read', >> 'mark', 'skip' or 'write' operations will trigger the >> open-if-not-yet-opened() logic of the lazyopen stream. > > As will 'skip' and 'seek', i.e. all public operatio

Re: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

2013-04-23 Thread Ivan Zhakov
On Tue, Apr 23, 2013 at 9:09 PM, Philip Martin wrote: > Ivan Zhakov writes: > >> On Tue, Apr 23, 2013 at 5:04 PM, wrote: >>> Author: philip >>> Date: Tue Apr 23 13:04:42 2013 >>> New Revision: 1470936 >>> >>> URL: http://svn.apache.org/r1470936 >>> Log: >>> Significantly reduce the number of op

Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

2013-04-23 Thread Stefan Fuhrmann
On Tue, Apr 23, 2013 at 8:18 PM, Philip Martin wrote: > Stefan Fuhrmann writes: > > > On Tue, Apr 23, 2013 at 6:54 PM, Philip Martin > > wrote: > >> At the start of the log > >> you say it is essential to use consistent configs. Does using NULL > >> result in consistent configs? > >> > > > > Co

Re: New API svn_stream_lazyopen_create - documentation

2013-04-23 Thread Philip Martin
"C. Michael Pilato" writes: > Strictly speaking, though, any of the 'read', > 'mark', 'skip' or 'write' operations will trigger the > open-if-not-yet-opened() logic of the lazyopen stream. As will 'skip' and 'seek', i.e. all public operations apart from 'close'. The new flag allows 'close' to t

Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

2013-04-23 Thread Philip Martin
Stefan Fuhrmann writes: > On Tue, Apr 23, 2013 at 6:54 PM, Philip Martin > wrote: >> At the start of the log >> you say it is essential to use consistent configs. Does using NULL >> result in consistent configs? >> > > Consistent as in "same as in all other API calls potentially opening a FS".

Re: New API svn_stream_lazyopen_create - documentation

2013-04-23 Thread C. Michael Pilato
On 04/23/2013 01:53 PM, Julian Foad wrote: > This new API was introduced recently and is intended to be back-ported to > 1.8.0. It needs better documentation. I suggest: > > > [[[ > > Index: subversion/include/svn_io.h > === > --

New API svn_stream_lazyopen_create - documentation

2013-04-23 Thread Julian Foad
This new API was introduced recently and is intended to be back-ported to 1.8.0.  It needs better documentation.  I suggest: [[[ Index: subversion/include/svn_io.h === --- subversion/include/svn_io.h    (revision 1471068) +++ subve

Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

2013-04-23 Thread Stefan Fuhrmann
On Tue, Apr 23, 2013 at 6:54 PM, Philip Martin wrote: > stef...@apache.org writes: > > > Author: stefan2 > > Date: Mon Apr 22 22:26:39 2013 > > New Revision: 1470738 > > > > URL: http://svn.apache.org/r1470738 > > Log: > > Make svn_fs_verify accept a FS_CONFIG parameter similar to svn_fs_open() >

Re: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

2013-04-23 Thread Philip Martin
Ivan Zhakov writes: > On Tue, Apr 23, 2013 at 5:04 PM, wrote: >> Author: philip >> Date: Tue Apr 23 13:04:42 2013 >> New Revision: 1470936 >> >> URL: http://svn.apache.org/r1470936 >> Log: >> Significantly reduce the number of open files during a typical update >> over ra_serf by using lazy-ope

Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

2013-04-23 Thread Philip Martin
stef...@apache.org writes: > Author: stefan2 > Date: Mon Apr 22 22:26:39 2013 > New Revision: 1470738 > > URL: http://svn.apache.org/r1470738 > Log: > Make svn_fs_verify accept a FS_CONFIG parameter similar to svn_fs_open() > and svn_fs_create(). Use that in svn_repos_verify_fs2 to check FS with

Re: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

2013-04-23 Thread Ivan Zhakov
On Tue, Apr 23, 2013 at 5:04 PM, wrote: > Author: philip > Date: Tue Apr 23 13:04:42 2013 > New Revision: 1470936 > > URL: http://svn.apache.org/r1470936 > Log: > Significantly reduce the number of open files during a typical update > over ra_serf by using lazy-opening streams to delay opening un

Re: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

2013-04-23 Thread Stefan Fuhrmann
On Tue, Apr 23, 2013 at 3:25 PM, Bert Huijben wrote: > > > > -Original Message- > > From: stef...@apache.org [mailto:stef...@apache.org] > > Sent: dinsdag 23 april 2013 00:27 > > To: comm...@subversion.apache.org > > Subject: svn commit: r1470738 - in /subversion/trunk/subversion: > > inc

Re: svn commit: r1470936 - in /subversion/trunk/subversion: include/svn_io.h libsvn_subr/stream.c libsvn_wc/adm_ops.c libsvn_wc/update_editor.c

2013-04-23 Thread C. Michael Pilato
On 04/23/2013 09:04 AM, phi...@apache.org wrote: > Author: philip > Date: Tue Apr 23 13:04:42 2013 > New Revision: 1470936 > > URL: http://svn.apache.org/r1470936 > Log: > Significantly reduce the number of open files during a typical update > over ra_serf by using lazy-opening streams to delay op

RE: svn commit: r1470738 - in /subversion/trunk/subversion: include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c

2013-04-23 Thread Bert Huijben
> -Original Message- > From: stef...@apache.org [mailto:stef...@apache.org] > Sent: dinsdag 23 april 2013 00:27 > To: comm...@subversion.apache.org > Subject: svn commit: r1470738 - in /subversion/trunk/subversion: > include/svn_fs.h libsvn_fs/fs-loader.c libsvn_repos/dump.c > > Author:

Re: log --search test failures on trunk and 1.8.x

2013-04-23 Thread Stefan Sperling
On Tue, Apr 23, 2013 at 02:27:08PM +0200, Branko Čibej wrote: > You're missing the point. tolower() works on individual characters, not > whole strings; so it in general /cannot/ do correct locale-specific Do you really mean characters, or bytes? It sounds like you mean bytes. tolower() works on i

Re: log --search test failures on trunk and 1.8.x

2013-04-23 Thread Branko Čibej
On 23.04.2013 08:53, Stefan Sperling wrote: > On Mon, Apr 22, 2013 at 01:13:43PM +0200, Branko Čibej wrote: >> On 22.04.2013 12:59, Bert Huijben wrote: >>> The assertion shows a design problem which we should handle for future >>> compatibility and you suggest just adding some bandages to patch/hi

RE: svn commit: r1470871 - /subversion/trunk/COMMITTERS

2013-04-23 Thread Bert Huijben
> -Original Message- > From: rsch...@apache.org [mailto:rsch...@apache.org] > Sent: dinsdag 23 april 2013 12:07 > To: comm...@subversion.apache.org > Subject: svn commit: r1470871 - /subversion/trunk/COMMITTERS > > Author: rschupp > Date: Tue Apr 23 10:07:05 2013 > New Revision: 1470871

Re: Diff Project --invoke-diff-cmd part

2013-04-23 Thread Gabriela Gibson
Many thanks for the inspiring feedback! Gabriela Julian Foad wrote: >> * This patch breaks the override --internal-diff for now, because >> this part has to be revised anyway when the invoke-diff3-cmd part >> gets added. > OK, we'll have to dec