Re: sqlite3.c won't compile with -std=c89

2013-04-30 Thread Mattias Engdegård
25 mar 2013 kl. 23.03 skrev Mattias Engdegård: [[[ Work around a problem on older OS X systems: sqlite3.c includes , which uses 'inline' and thus cannot be compiled with -std=c89 that we are using for all files. * subversion/libsvn_subr/sqlite3wrapper.c (toplevel): Define 'inline' as '__inline

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Johan Corveleyn
On Tue, Apr 30, 2013 at 9:26 PM, Daniel Shahaf wrote: > FWIW, I did find two references: > >> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3 > > No opinion as I don't build on windows any more, but CCing jcorvel. > (Johan: the question is whether we want to update the zlib version used > by window

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 12:38 PM, Daniel Shahaf wrote: > I figured we'd either release 1.6.22 without a -deps tarball, or > resurrect the script from svn history. We could indeed do that, it's come up before.

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Daniel Shahaf
Ben Reser wrote on Tue, Apr 30, 2013 at 12:36:03 -0700: > On Tue, Apr 30, 2013 at 12:26 PM, Daniel Shahaf wrote: > >> tools/dist/make-deps-tarball.sh:ZLIB=zlib-1.2.7 > > > > Script only used for 1.6 and earlier; we can probably remove the script > > from HEAD. > > Yes, but it needs to stay until

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 12:26 PM, Daniel Shahaf wrote: > FWIW, I did find two references: Ahh I did miss these. >> tools/dev/windows-build/Makefile:ZLIBVER=1.2.3 > > No opinion as I don't build on windows any more, but CCing jcorvel. > (Johan: the question is whether we want to update the zlib v

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Daniel Shahaf
Ben Reser wrote on Tue, Apr 30, 2013 at 12:03:29 -0700: > On Tue, Apr 30, 2013 at 10:52 AM, Daniel Shahaf wrote: > > 4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever > > else we mention what the recommended zlib version is > > Not sure where that's from, but we don't recommend a v

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 10:52 AM, Daniel Shahaf wrote: > 4) Update INSTALL, README, build/ac-macros/zlib.m4, and wherever > else we mention what the recommended zlib version is Not sure where that's from, but we don't recommend a version of zlib. The closest we come to that is the Windows docs sa

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Daniel Shahaf
Ben Reser wrote on Tue, Apr 30, 2013 at 10:27:18 -0700: > On Tue, Apr 30, 2013 at 8:07 AM, Gabriela Gibson > wrote: > > [[[ > > > > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz > > > > * subversion/build/get-deps.sh: > > (): Update zlib version number. > > (get_zlib):

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 10:11 AM, Branko Čibej wrote: > +1, and I think this should go into 1.8 as well as trunk. It will, part of our release process is to check that get-deps.sh works now, and given that the zlib folks remove the link we use with every version, we would have found this then.

[PATCH] Add scratch pool to svn_config_read3

2013-04-30 Thread Philip Martin
Philip Martin writes: > br...@apache.org writes: > >> Author: brane >> Date: Thu Apr 25 13:48:46 2013 >> New Revision: 1475772 >> >> URL: http://svn.apache.org/r1475772 >> Log: >> Fix issue #4361 (user/group names in authz files are case-insensitive). >> >> * subversion/include/svn_config.h >>

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Ben Reser
On Tue, Apr 30, 2013 at 8:07 AM, Gabriela Gibson wrote: > [[[ > > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz > > * subversion/build/get-deps.sh: > (): Update zlib version number. > (get_zlib): Modify tar command and file extension. > > ]]] Applied in r1477730 with s

Re: Diff Project --invoke-diff-cmd part

2013-04-30 Thread Branko Čibej
On 28.04.2013 11:24, Daniel Shahaf wrote: > P.S. It appears our config files' %-interpolation feature doesn't kick > in for --config-option's argument. I'm not sure whether that's a good > thing or not. This is probably because we interpolate upon getting a value from the svn_config_t, not during

Re: [PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Branko Čibej
On 30.04.2013 17:07, Gabriela Gibson wrote: > [[[ > > Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz > > * subversion/build/get-deps.sh: > (): Update zlib version number. > (get_zlib): Modify tar command and file extension. > > ]]] +1, and I think this should go into 1.8

Fwd: Re: Are we ready for a 1.8.0 release candidate

2013-04-30 Thread Branko Čibej
Here's me forwarding a reply that got mis-addressed on the phone. -- Brane Original Message Subject:Re: Are we ready for a 1.8.0 release candidate Date: Tue, 30 Apr 2013 12:53:08 +0200 From: Branko Čibej To: Ben Reser I actually dared to take a few days' va

Re: Are we ready for a 1.8.0 release candidate

2013-04-30 Thread Paul Burba
On Mon, Apr 29, 2013 at 6:42 PM, Ben Reser wrote: > There is only one issue open against 1.8.0: > http://subversion.tigris.org/issues/show_bug.cgi?id=4358 > > Based on what I understand I believe that issue can be moved to some > future target since the conclusion seems to be it's not a blocker. >

RE: Are we ready for a 1.8.0 release candidate

2013-04-30 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: dinsdag 30 april 2013 15:00 > To: C. Michael Pilato > Cc: Ben Reser; Subversion Development > Subject: Re: Are we ready for a 1.8.0 release candidate > > On Tue, Apr 30, 2013 at 4:58 PM, C. Michael Pilato > wro

[PATCH] get-deps.sh zlib version number and file type changed

2013-04-30 Thread Gabriela Gibson
[[[ Update the zlib HTTP link to fetch http://zlib.net/zlib-1.2.8.tar.gz * subversion/build/get-deps.sh: (): Update zlib version number. (get_zlib): Modify tar command and file extension. ]]] Index: get-deps.sh === --- get-dep

Re: Are we ready for a 1.8.0 release candidate

2013-04-30 Thread Ivan Zhakov
On Tue, Apr 30, 2013 at 4:58 PM, C. Michael Pilato wrote: > On 04/29/2013 06:42 PM, Ben Reser wrote: >> Unless someone is aware of something else, once we wrap up some of the >> STATUS changes I think we can cut a release candidate for 1.8.0, >> probably this week? > > +1. > +1. -- Ivan Zhakov

Re: Are we ready for a 1.8.0 release candidate

2013-04-30 Thread C. Michael Pilato
On 04/29/2013 06:42 PM, Ben Reser wrote: > Unless someone is aware of something else, once we wrap up some of the > STATUS changes I think we can cut a release candidate for 1.8.0, > probably this week? +1. -- C. Michael Pilato CollabNet <> www.collab.net <> Enterprise Cloud Development