Re: --invoke-diff-cmd test suite woes

2013-05-08 Thread Stefan Sperling
On Wed, May 08, 2013 at 09:10:49PM +0300, Daniel Shahaf wrote: > You could use tools/diff/diff. Or 'svn diff --old some-file --new some-other-file' :)

Re: --invoke-diff-cmd test suite woes

2013-05-08 Thread Daniel Shahaf
Ben Reser wrote on Wed, May 08, 2013 at 10:53:48 -0700: > On Wed, May 8, 2013 at 10:08 AM, Gabriela Gibson > wrote: > > All my manual tests for the current --invoke-diff-cmd work fine, but I > > cannot get the test suite to work. > > 1) You're not providing a path for the diff command are you sur

Re: --invoke-diff-cmd test suite woes

2013-05-08 Thread Ben Reser
On Wed, May 8, 2013 at 10:08 AM, Gabriela Gibson wrote: > All my manual tests for the current --invoke-diff-cmd work fine, but I > cannot get the test suite to work. 1) You're not providing a path for the diff command are you sure that it's on the PATH in the environment that svn is running the c

--invoke-diff-cmd test suite woes

2013-05-08 Thread Gabriela Gibson
Hi, All my manual tests for the current --invoke-diff-cmd work fine, but I cannot get the test suite to work. I added the following new test (nr 49) to diff_tests.py: [[[ # Check the order of the arguments for an external diff tool def diff_invoke_external_diffcmd(sbox): "svn diff --diff-invo

RE: Running JavaHL from win-tests.py

2013-05-08 Thread Bert Huijben
> -Original Message- > From: Mark Phippard [mailto:markp...@gmail.com] > Sent: woensdag 8 mei 2013 15:32 > To: Bert Huijben > Cc: Subversion Development > Subject: Re: Running JavaHL from win-tests.py > > On Wed, May 8, 2013 at 2:54 AM, Bert Huijben wrote: > > On the windows builbot I p

Re: Make option parsing error messages translatable

2013-05-08 Thread Stefan Sperling
On Wed, May 08, 2013 at 03:57:22PM +0300, Daniel Shahaf wrote: > I don't really have much to say to the rest of your mail that I didn't > already say. It boils down to a disagreement over whether > lambda x: !strcmp(x, "invalid option") > is a stable API. I think this problem should be fixed

Re: Running JavaHL from win-tests.py

2013-05-08 Thread Mark Phippard
On Wed, May 8, 2013 at 2:54 AM, Bert Huijben wrote: > On the windows builbot I pass the junit location to gen-make.py and then I > can compile and run the junit tests. I also need the junit location during > building as it is not installed in the standard environment. > > The exact invocations are

Re: Make option parsing error messages translatable

2013-05-08 Thread Daniel Shahaf
Mattias Engdegård wrote on Tue, May 07, 2013 at 21:44:00 +0200: > 7 maj 2013 kl. 01.00 skrev Daniel Shahaf: > >> Of course there is, if someday APR uses "invalid option" in another >> meaning than the one this patch assumes it does. > > Believe it or not, that is already how gettext translation wor

Re: 1.8.0-rc1 up for testing/signing

2013-05-08 Thread Branko Čibej
It seems obvious that we'll not release this tarball after all, given the svnserve threading problems. I tested it anyway and it looks good, bar a few nits and a failure in the ctypes-python bindings test that don't recall being reported yet. -- Brane Summary: +0 to release Platform Ma

Re: Thread issues in svnserve (was Re: 1.8.0-rc1 up for testing/signing)

2013-05-08 Thread Ivan Zhakov
On Wed, May 8, 2013 at 1:00 PM, Bert Huijben wrote: >> -Original Message- >> From: Ivan Zhakov [mailto:i...@visualsvn.com] >> Sent: woensdag 8 mei 2013 01:46 >> To: Subversion Development >> Subject: Re: Thread issues in svnserve (was Re: 1.8.0-rc1 up for >> testing/signing) >> >> On Sun,

RE: Thread issues in svnserve (was Re: 1.8.0-rc1 up for testing/signing)

2013-05-08 Thread Bert Huijben
> -Original Message- > From: Ivan Zhakov [mailto:i...@visualsvn.com] > Sent: woensdag 8 mei 2013 01:46 > To: Subversion Development > Subject: Re: Thread issues in svnserve (was Re: 1.8.0-rc1 up for > testing/signing) > > On Sun, May 5, 2013 at 8:27 PM, Ivan Zhakov wrote: > > On Sun, Ma