Should 'svn patch' say nothing when it does nothing?

I tried to commit r1820518 by extracting the patch from the mail to a file and using 'svn patch': % svn patch /tmp/patch % svn status % Now, in this situation, should 'svn patch' have said something to the effect of "svn: No patch found in input"? I'm aware of "Nothing done, nothing said", but

Re: [PATCH] swig-py svn_stream_t read() glue

Thanks for the reviews; committed in r1820518 and nominated for backport for 1.10.x and for 1.9.x as well (although I can see that the risk/benefit balance could be different for the two). Daniel

Re: [PATCH] swig-py svn_stream_t read() glue

On 07.01.2018 16:17, Troy Curtis Jr wrote: > On Wed, Jan 3, 2018 at 10:55 PM Daniel Shahaf > wrote: > >> svn_swig_py_make_stream() is a function that wraps a PyObject in an >> svn_stream_t. Its read implementation, read_handler_pyio(), just calls >> the PyObject's .read() method. >> >> According

Re: [PATCH] swig-py svn_stream_t read() glue

On Wed, Jan 3, 2018 at 10:55 PM Daniel Shahaf wrote: > svn_swig_py_make_stream() is a function that wraps a PyObject in an > svn_stream_t. Its read implementation, read_handler_pyio(), just calls > the PyObject's .read() method. > > According to

Making build bots happy

As per Community Guide, I approved two subversion/test fixes with < 3 "+1" votes in r1820444 and r1820445, respectively. That should fix the build bot failures for 1.9 and 1.10 that we saw for some time now. -- Stefan^2.