Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Philip Martin
Joe Orton writes: > I thought about that, but the SVN buildsystem is building & installing > them like libraries not like DSOs (which should be linked with libtool's > -module argument and not installed directly in $libdir), I suspect that is accidental. The RA/FS option

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Joe Orton
On Wed, May 02, 2018 at 04:32:26PM +0100, Philip Martin wrote: > Philip Martin writes: > > >> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and > >> make dependencies private. > > > > Looks OK to me. > > Perhaps we should delete the .pc files for

Re: [PATCH] fix libsvn_auth_gnome_keyring.pc w/libsecret

2018-05-03 Thread Stefan Sperling
On Thu, May 03, 2018 at 09:11:33AM +0100, Philip Martin wrote: > Philip Martin writes: > > > Philip Martin writes: > > > >>> Fixes libsvn_auth_gnome_keyring.pc when configured with libsecret, and > >>> make dependencies private. > >> > >>